From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/3] nvme-pci: Fix timeouts in connecting state
Date: Fri, 9 Feb 2018 10:41:25 -0700 [thread overview]
Message-ID: <20180209174127.7224-1-keith.busch@intel.com> (raw)
We need to halt the controller immediately if we haven't completed
initialization as indicated by the new "connecting" state.
Fixes: ad70062cdb ("nvme-pci: introduce RECONNECTING state to mark initializing procedure")
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
drivers/nvme/host/pci.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index ab9c19525fa8..90e276c05f79 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1215,13 +1215,17 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved)
* cancellation error. All outstanding requests are completed on
* shutdown, so we return BLK_EH_HANDLED.
*/
- if (dev->ctrl.state == NVME_CTRL_RESETTING) {
+ switch (dev->ctrl.state) {
+ case NVME_CTRL_CONNECTING:
+ case NVME_CTRL_RESETTING:
dev_warn(dev->ctrl.device,
"I/O %d QID %d timeout, disable controller\n",
req->tag, nvmeq->qid);
nvme_dev_disable(dev, false);
nvme_req(req)->flags |= NVME_REQ_CANCELLED;
return BLK_EH_HANDLED;
+ default:
+ break;
}
/*
--
2.14.3
next reply other threads:[~2018-02-09 17:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 17:41 Keith Busch [this message]
2018-02-09 17:41 ` [PATCH 2/3] nvme: Sync queues on controller resets Keith Busch
2018-02-10 1:55 ` jianchao.wang
2018-02-11 1:53 ` jianchao.wang
2018-02-12 21:46 ` Keith Busch
2018-04-18 2:26 ` jianchao.wang
2018-04-19 14:33 ` Keith Busch
2018-02-09 17:41 ` [PATCH 3/3] nvme: Fail controller on timeouts during reset Keith Busch
2018-02-11 8:26 ` jianchao.wang
2018-02-11 9:53 ` Sagi Grimberg
2018-02-12 7:59 ` jianchao.wang
2018-02-12 18:37 ` Sagi Grimberg
2018-02-13 2:21 ` jianchao.wang
2018-02-10 2:14 ` [PATCH 1/3] nvme-pci: Fix timeouts in connecting state jianchao.wang
2018-02-12 14:18 ` Keith Busch
2018-02-13 2:21 ` jianchao.wang
2018-02-13 2:33 ` jianchao.wang
2018-02-13 14:47 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180209174127.7224-1-keith.busch@intel.com \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox