Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: jianchao.w.wang@oracle.com (jianchao.wang)
Subject: [PATCH 2/3] nvme: Sync queues on controller resets
Date: Wed, 18 Apr 2018 10:26:28 +0800	[thread overview]
Message-ID: <2e46f418-ea62-eebf-f2a6-0627645dcfff@oracle.com> (raw)
In-Reply-To: <20180212214601.GB20962@localhost.localdomain>

Hi Keith

On 02/13/2018 05:46 AM, Keith Busch wrote:
> On Sun, Feb 11, 2018@09:53:03AM +0800, jianchao.wang wrote:
>> On 02/10/2018 09:55 AM, jianchao.wang wrote:
>>> There could be a circular pattern here. Please consider the following scenario:
>>>
>>> timeout_work context                    reset_work context
>>> nvme_timeout                            nvme_reset_work
>>>   -> nvme_dev_disable                     -> nvme_sync_queues // hold namespace_mutex
>>>     -> nvme_stop_queues                     -> blk_sync_queue
>>>       -> require namespaces_mutex               -> cancel_work_sync(&q->timeout_work)
>>>
>>
>> Looks like we could use rwsem to replace namespaces_mutex.
> 
> Looks like rwsem is queued up for 4.17. I'll send an update based on
> that. I guess this one and 3/3 can wait for 4.17, but 1/3 should still
> go in 4.16.
> 

Would you please queue this patch for next ?
I incurred this issue when NVMe card died with a lot of in-flight requests.

Thanks
Jianchao

  reply	other threads:[~2018-04-18  2:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09 17:41 [PATCH 1/3] nvme-pci: Fix timeouts in connecting state Keith Busch
2018-02-09 17:41 ` [PATCH 2/3] nvme: Sync queues on controller resets Keith Busch
2018-02-10  1:55   ` jianchao.wang
2018-02-11  1:53     ` jianchao.wang
2018-02-12 21:46       ` Keith Busch
2018-04-18  2:26         ` jianchao.wang [this message]
2018-04-19 14:33           ` Keith Busch
2018-02-09 17:41 ` [PATCH 3/3] nvme: Fail controller on timeouts during reset Keith Busch
2018-02-11  8:26   ` jianchao.wang
2018-02-11  9:53     ` Sagi Grimberg
2018-02-12  7:59       ` jianchao.wang
2018-02-12 18:37         ` Sagi Grimberg
2018-02-13  2:21           ` jianchao.wang
2018-02-10  2:14 ` [PATCH 1/3] nvme-pci: Fix timeouts in connecting state jianchao.wang
2018-02-12 14:18   ` Keith Busch
2018-02-13  2:21     ` jianchao.wang
2018-02-13  2:33       ` jianchao.wang
2018-02-13 14:47         ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e46f418-ea62-eebf-f2a6-0627645dcfff@oracle.com \
    --to=jianchao.w.wang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox