From: jianchao.w.wang@oracle.com (jianchao.wang)
Subject: [PATCH 3/3] nvme: Fail controller on timeouts during reset
Date: Tue, 13 Feb 2018 10:21:44 +0800 [thread overview]
Message-ID: <eab525b0-c986-5bec-88f0-998625a05b3c@oracle.com> (raw)
In-Reply-To: <14a17a6a-c626-8cb2-78a8-aa79249efb90@grimberg.me>
Hi Sagi
Sorry for bothering you.
On 02/13/2018 02:37 AM, Sagi Grimberg wrote:
>
>> Hi Sagi
>>
>> On 02/11/2018 05:53 PM, Sagi Grimberg wrote:
>>> Actually, they are already in nvme-4.16-rc.
>>>
>>> I'd like to pick these up as well once they converge (even
>>> taking 1+3 would be a good start).
>>
>> Please don't refer to my test result here.
>> It is tested on my patchset, not the currently source code on your git tree.
>
> OK, what I don't understand is what is your feedback on this patchset as
> I'd like to take it for 4.16-rc and I want a review for it
This bug was seen when I tested the patchset nvme-pci: fixes on nvme_timeout and nvme_dev_disable patchset.
Because it is also a issue for current source code, so I reported this and had some talking with Keith,
then Keith gave this solution (Really appreciate for this).
Then I ported this with the patchset nvme-pci: fixes on nvme_timeout and nvme_dev_disable patchset and the issue
I met was gone. So I posted a feedback here as you saw.
It is certainly fine to fix that issue.
Really sorry for bothering you.
Sincerely
Jianchao
next prev parent reply other threads:[~2018-02-13 2:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 17:41 [PATCH 1/3] nvme-pci: Fix timeouts in connecting state Keith Busch
2018-02-09 17:41 ` [PATCH 2/3] nvme: Sync queues on controller resets Keith Busch
2018-02-10 1:55 ` jianchao.wang
2018-02-11 1:53 ` jianchao.wang
2018-02-12 21:46 ` Keith Busch
2018-04-18 2:26 ` jianchao.wang
2018-04-19 14:33 ` Keith Busch
2018-02-09 17:41 ` [PATCH 3/3] nvme: Fail controller on timeouts during reset Keith Busch
2018-02-11 8:26 ` jianchao.wang
2018-02-11 9:53 ` Sagi Grimberg
2018-02-12 7:59 ` jianchao.wang
2018-02-12 18:37 ` Sagi Grimberg
2018-02-13 2:21 ` jianchao.wang [this message]
2018-02-10 2:14 ` [PATCH 1/3] nvme-pci: Fix timeouts in connecting state jianchao.wang
2018-02-12 14:18 ` Keith Busch
2018-02-13 2:21 ` jianchao.wang
2018-02-13 2:33 ` jianchao.wang
2018-02-13 14:47 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eab525b0-c986-5bec-88f0-998625a05b3c@oracle.com \
--to=jianchao.w.wang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox