* [PATCH] nvme: Use admin command effects for admin commands
@ 2018-04-11 20:48 Keith Busch
2018-04-12 5:39 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Keith Busch @ 2018-04-11 20:48 UTC (permalink / raw)
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
This was correct in the first few versions of this patch, and goofed up
on the last one somehow. Didn't notice until I tested a drive with the
capability today.
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index b70f02bafac6..6ed91ae7f740 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1102,7 +1102,7 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
}
if (ctrl->effects)
- effects = le32_to_cpu(ctrl->effects->iocs[opcode]);
+ effects = le32_to_cpu(ctrl->effects->acs[opcode]);
else
effects = nvme_known_admin_effects(opcode);
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] nvme: Use admin command effects for admin commands
2018-04-11 20:48 [PATCH] nvme: Use admin command effects for admin commands Keith Busch
@ 2018-04-12 5:39 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2018-04-12 5:39 UTC (permalink / raw)
On Wed, Apr 11, 2018@02:48:12PM -0600, Keith Busch wrote:
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
> This was correct in the first few versions of this patch, and goofed up
> on the last one somehow. Didn't notice until I tested a drive with the
> capability today.
>
> drivers/nvme/host/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks good!
Btw, time to send another nvme update to Jens?
>
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index b70f02bafac6..6ed91ae7f740 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1102,7 +1102,7 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> }
>
> if (ctrl->effects)
> - effects = le32_to_cpu(ctrl->effects->iocs[opcode]);
> + effects = le32_to_cpu(ctrl->effects->acs[opcode]);
> else
> effects = nvme_known_admin_effects(opcode);
>
> --
> 2.14.3
---end quoted text---
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-12 5:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-11 20:48 [PATCH] nvme: Use admin command effects for admin commands Keith Busch
2018-04-12 5:39 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox