Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/3] nvme: enable multipathing by default
Date: Tue, 20 Nov 2018 17:27:32 +0100	[thread overview]
Message-ID: <20181120162734.2013-2-hch@lst.de> (raw)
In-Reply-To: <20181120162734.2013-1-hch@lst.de>

And make it a little more clear that the only reason to disable it is
to optimize for size in constrained environment.

Signed-off-by: Christoph Hellwig <hch at lst.de>
---
 drivers/nvme/host/Kconfig | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
index 88a8b5916624..d2ae6954ce7e 100644
--- a/drivers/nvme/host/Kconfig
+++ b/drivers/nvme/host/Kconfig
@@ -16,12 +16,20 @@ config BLK_DEV_NVME
 config NVME_MULTIPATH
 	bool "NVMe multipath support"
 	depends on NVME_CORE
+	default y
 	---help---
 	   This option enables support for multipath access to NVMe
 	   subsystems.  If this option is enabled only a single
 	   /dev/nvmeXnY device will show up for each NVMe namespaces,
 	   even if it is accessible through multiple controllers.
 
+	   Say Y here unless you need to optimize for size in embedded
+	   systems that are never going to see multi-port NVMe devices.
+
+	   If you say N multiple ports of the same subsystem will show
+	   up as separate devices, and none of the normal block device
+	   exclusion mechanisms will work.
+
 config NVME_FABRICS
 	tristate
 
-- 
2.19.1

  reply	other threads:[~2018-11-20 16:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20 16:27 tweak multipath kconfig and options Christoph Hellwig
2018-11-20 16:27 ` Christoph Hellwig [this message]
2018-11-20 18:47   ` [PATCH 1/3] nvme: enable multipathing by default Keith Busch
2018-11-21  8:27     ` Christoph Hellwig
2018-11-22  2:44       ` Sagi Grimberg
2018-11-26 15:40         ` Keith Busch
2018-11-20 16:27 ` [PATCH 2/3] nvme: warn when finding multi-port subsystems without multipathing enabled Christoph Hellwig
2018-11-22  2:45   ` Sagi Grimberg
2018-11-20 16:27 ` [PATCH 3/3] nvme: deprecate the multipath=0 module option Christoph Hellwig
2018-11-22  2:49   ` Sagi Grimberg
2018-11-27 15:06     ` [PATCH 3/3 v2] " Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181120162734.2013-2-hch@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox