Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/3] nvme: enable multipathing by default
Date: Wed, 21 Nov 2018 09:27:24 +0100	[thread overview]
Message-ID: <20181121082724.GA29231@lst.de> (raw)
In-Reply-To: <20181120184749.GF26707@localhost.localdomain>

On Tue, Nov 20, 2018@11:47:49AM -0700, Keith Busch wrote:
> This is okay with me, but I have one little follow-on I'd like to RFC here:
> 
> The /dev/nvme naming convention with multiplath has broken people's
> minds, and making it default will invite a lot of repeat questions on
> how to match up block to admin handles.
> 
> Could we promote /dev/nvme0 to be a subsystem handle instead of a
> controller handle, and add new per-controller handles, like /dev/nvme0c1,
> nvme0c2, etc...? The subsystem handle's management interface can just use
> the first active controller to forward admin commands, and per-controller
> specific administration can be taught to use the new handles as needed.
> 
> Tooling shouldn't care about the names, but I am not sure if this could
> possibly break productino scripts. The naming disconnect has broken
> some things, though, so I hope this doesn't end up being a pick your
> poision suggestion...

The problem is that typical admin command are sensitive to the controller
they are sent to, so a per-subsystem handle does not make whole lot
sense.  But I like the idea of the nvmeXcY names.  Maybe we just keep
the nvmeX names as an additional alias for the first found controller
in a subsystem and otherwise use nvmeXcY? 

  reply	other threads:[~2018-11-21  8:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20 16:27 tweak multipath kconfig and options Christoph Hellwig
2018-11-20 16:27 ` [PATCH 1/3] nvme: enable multipathing by default Christoph Hellwig
2018-11-20 18:47   ` Keith Busch
2018-11-21  8:27     ` Christoph Hellwig [this message]
2018-11-22  2:44       ` Sagi Grimberg
2018-11-26 15:40         ` Keith Busch
2018-11-20 16:27 ` [PATCH 2/3] nvme: warn when finding multi-port subsystems without multipathing enabled Christoph Hellwig
2018-11-22  2:45   ` Sagi Grimberg
2018-11-20 16:27 ` [PATCH 3/3] nvme: deprecate the multipath=0 module option Christoph Hellwig
2018-11-22  2:49   ` Sagi Grimberg
2018-11-27 15:06     ` [PATCH 3/3 v2] " Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181121082724.GA29231@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox