Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH 8/8] blk-mq: add plug case for devices that implement ->commits_rqs()
Date: Tue, 27 Nov 2018 23:26:55 -0800	[thread overview]
Message-ID: <20181128072655.GE11774@infradead.org> (raw)
In-Reply-To: <20181126163556.5181-9-axboe@kernel.dk>

> +	} else if (plug && q->mq_ops->commit_rqs) {
> +		/*
> +		 * If we have a ->commit_rqs(), then we know the driver can
> +		 * batch submission doorbell updates. Add rq to plug list,
> +		 * and flush if we exceed the plug count only.
> +		 */
> +		blk_mq_bio_to_request(rq, bio);
> +		blk_mq_put_ctx(data.ctx);
> +
> +		/*
> +		 * If we have requests for more than one queue here, we
> +		 * should sort the list when it's flushed.
> +		 */
> +		if (!plug->do_sort && !list_empty(&plug->mq_list)) {
> +			same_queue_rq = list_first_entry(&plug->mq_list,
> +						struct request, queuelist);
> +			if (same_queue_rq->q != q)
> +				plug->do_sort = true;
> +		}
> +
> +		list_add_tail(&rq->queuelist, &plug->mq_list);
> +		plug->rq_count++;
> +		if (plug->rq_count >= BLK_MAX_REQUEST_COUNT) {
> +			blk_flush_plug_list(plug, false);
> +			trace_block_plug(q);
> +		}

This seems like a slight variation of the the single queue plug
case.  Can we share the code instead of having slightly differing
logic?

Also that should this respect blk_queue_nomerges?

  reply	other threads:[~2018-11-28  7:26 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26 16:35 [PATCHSET 0/8] block plugging improvements Jens Axboe
2018-11-26 16:35 ` [PATCH 1/8] block: sum requests in the plug structure Jens Axboe
2018-11-26 17:02   ` Christoph Hellwig
2018-11-26 16:35 ` [PATCH 2/8] block: improve logic around when to sort a plug list Jens Axboe
2018-11-27 23:31   ` Omar Sandoval
2018-11-27 23:49     ` Jens Axboe
2018-11-27 23:55       ` Omar Sandoval
2018-11-27 23:59       ` Jens Axboe
2018-11-28  0:05         ` Omar Sandoval
2018-11-28  0:16           ` Jens Axboe
2018-11-26 16:35 ` [PATCH 3/8] blk-mq: add mq_ops->commit_rqs() Jens Axboe
2018-11-27 23:43   ` Omar Sandoval
2018-11-28  1:38   ` Ming Lei
2018-11-28  7:16   ` Christoph Hellwig
2018-11-28 12:54     ` Jens Axboe
2018-11-26 16:35 ` [PATCH 4/8] nvme: implement mq_ops->commit_rqs() hook Jens Axboe
2018-11-28  7:20   ` Christoph Hellwig
2018-11-28 13:07     ` Jens Axboe
2018-11-26 16:35 ` [PATCH 5/8] virtio_blk: " Jens Axboe
2018-11-27 23:45   ` Omar Sandoval
2018-11-28  3:05     ` Michael S. Tsirkin
2018-11-28  2:10   ` Ming Lei
2018-11-28  2:34     ` Jens Axboe
2018-11-29  1:23       ` Ming Lei
2018-11-29  2:19         ` Jens Axboe
2018-11-29  2:51           ` Ming Lei
2018-11-29  3:13             ` Jens Axboe
2018-11-29  3:27               ` Ming Lei
2018-11-29  3:53                 ` Jens Axboe
2018-11-28  7:21   ` Christoph Hellwig
2018-11-26 16:35 ` [PATCH 6/8] ataflop: " Jens Axboe
2018-11-27 23:46   ` Omar Sandoval
2018-11-28  7:22   ` Christoph Hellwig
2018-11-28 13:09     ` Jens Axboe
2018-11-26 16:35 ` [PATCH 7/8] blk-mq: use bd->last == true for list inserts Jens Axboe
2018-11-27 23:49   ` Omar Sandoval
2018-11-27 23:51     ` Jens Axboe
2018-11-28  1:49   ` Ming Lei
2018-11-28  2:37     ` Jens Axboe
2018-11-26 16:35 ` [PATCH 8/8] blk-mq: add plug case for devices that implement ->commits_rqs() Jens Axboe
2018-11-28  7:26   ` Christoph Hellwig [this message]
2018-11-28 13:11     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181128072655.GE11774@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox