From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH 3/8] blk-mq: add mq_ops->commit_rqs()
Date: Wed, 28 Nov 2018 05:54:04 -0700 [thread overview]
Message-ID: <dd6bf846-c5f4-8aea-64fa-bf613d5079d2@kernel.dk> (raw)
In-Reply-To: <20181128071601.GA11774@infradead.org>
On 11/28/18 12:16 AM, Christoph Hellwig wrote:
> On Mon, Nov 26, 2018@09:35:51AM -0700, Jens Axboe wrote:
>> blk-mq passes information to the hardware about any given request being
>> the last that we will issue in this sequence. The point is that hardware
>> can defer costly doorbell type writes to the last request. But if we run
>> into errors issuing a sequence of requests, we may never send the request
>> with bd->last == true set. For that case, we need a hook that tells the
>> hardware that nothing else is coming right now.
>>
>> For failures returned by the drivers ->queue_rq() hook, the driver is
>> responsible for flushing pending requests, if it uses bd->last to
>> optimize that part. This works like before, no changes there.
>>
>> Signed-off-by: Jens Axboe <axboe at kernel.dk>
>
> This looks fine, but normally I would only add the method together with
> the actual user..
I included the two hunks from patch 7 in this one, so there's a real
use (and fix) with it.
--
Jens Axboe
next prev parent reply other threads:[~2018-11-28 12:54 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 16:35 [PATCHSET 0/8] block plugging improvements Jens Axboe
2018-11-26 16:35 ` [PATCH 1/8] block: sum requests in the plug structure Jens Axboe
2018-11-26 17:02 ` Christoph Hellwig
2018-11-26 16:35 ` [PATCH 2/8] block: improve logic around when to sort a plug list Jens Axboe
2018-11-27 23:31 ` Omar Sandoval
2018-11-27 23:49 ` Jens Axboe
2018-11-27 23:55 ` Omar Sandoval
2018-11-27 23:59 ` Jens Axboe
2018-11-28 0:05 ` Omar Sandoval
2018-11-28 0:16 ` Jens Axboe
2018-11-26 16:35 ` [PATCH 3/8] blk-mq: add mq_ops->commit_rqs() Jens Axboe
2018-11-27 23:43 ` Omar Sandoval
2018-11-28 1:38 ` Ming Lei
2018-11-28 7:16 ` Christoph Hellwig
2018-11-28 12:54 ` Jens Axboe [this message]
2018-11-26 16:35 ` [PATCH 4/8] nvme: implement mq_ops->commit_rqs() hook Jens Axboe
2018-11-28 7:20 ` Christoph Hellwig
2018-11-28 13:07 ` Jens Axboe
2018-11-26 16:35 ` [PATCH 5/8] virtio_blk: " Jens Axboe
2018-11-27 23:45 ` Omar Sandoval
2018-11-28 3:05 ` Michael S. Tsirkin
2018-11-28 2:10 ` Ming Lei
2018-11-28 2:34 ` Jens Axboe
2018-11-29 1:23 ` Ming Lei
2018-11-29 2:19 ` Jens Axboe
2018-11-29 2:51 ` Ming Lei
2018-11-29 3:13 ` Jens Axboe
2018-11-29 3:27 ` Ming Lei
2018-11-29 3:53 ` Jens Axboe
2018-11-28 7:21 ` Christoph Hellwig
2018-11-26 16:35 ` [PATCH 6/8] ataflop: " Jens Axboe
2018-11-27 23:46 ` Omar Sandoval
2018-11-28 7:22 ` Christoph Hellwig
2018-11-28 13:09 ` Jens Axboe
2018-11-26 16:35 ` [PATCH 7/8] blk-mq: use bd->last == true for list inserts Jens Axboe
2018-11-27 23:49 ` Omar Sandoval
2018-11-27 23:51 ` Jens Axboe
2018-11-28 1:49 ` Ming Lei
2018-11-28 2:37 ` Jens Axboe
2018-11-26 16:35 ` [PATCH 8/8] blk-mq: add plug case for devices that implement ->commits_rqs() Jens Axboe
2018-11-28 7:26 ` Christoph Hellwig
2018-11-28 13:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd6bf846-c5f4-8aea-64fa-bf613d5079d2@kernel.dk \
--to=axboe@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox