From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 1/1] nvme: add get-feature to admin cmds tracer
Date: Fri, 8 Feb 2019 09:42:16 +0100 [thread overview]
Message-ID: <20190208084216.GA23155@lst.de> (raw)
In-Reply-To: <f973dcd6-3455-449d-bf5b-117647d04b12@mellanox.com>
On Thu, Feb 07, 2019@12:28:07PM +0200, Max Gurtovoy wrote:
>> I'm open for both sides, but we're already decoding a bunch of commands
>> in the kernel and so does the SCSI tracing, so I don't see a compelling
>> reason to stop it now.
>
> Yup, I also think we shouldn't throw all cmd decoding from kernel and we
> can add more decoding incrementally as I did in this commit.
>
> Sagi/Christoph,
>
> what is your standing in this topic ? should I send V2 ?
I don't really care. We clearly have command decoding in the trace
points, so adding a little more won't hurt, but I'm also not sure
we really need it.
next prev parent reply other threads:[~2019-02-08 8:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 15:13 [PATCH 1/1] nvme: add get-feature to admin cmds tracer Max Gurtovoy
2019-01-31 16:11 ` Keith Busch
2019-01-31 17:01 ` Max Gurtovoy
2019-02-04 8:23 ` Johannes Thumshirn
2019-02-07 10:28 ` Max Gurtovoy
2019-02-08 8:42 ` Christoph Hellwig [this message]
2019-02-08 8:49 ` Johannes Thumshirn
2019-02-08 15:30 ` Keith Busch
2019-02-08 15:39 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208084216.GA23155@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox