[PATCH 1/1] nvme: add get-feature to admin cmds tracer

[jthumshirn@suse.de (Johannes Thumshirn)]

On 08/02/2019 09:42, Christoph Hellwig wrote:
> I don't really care.  We clearly have command decoding in the trace
> points, so adding a little more won't hurt, but I'm also not sure
> we really need it.

Hmm one thing, *iff* we want to decode the commands in user-space we
have to agree on one input format for the decoder which then becomes an
ABI (see for example blktrace). If we decode in the kernel we can easily
extent it (like we already did with the tracepoints).

IMHO maintaining an ABI like format is a major pain in the lower body
parts and the benefits from it aren't worth it.

Just my .2$.

Byte,
	Johannes
-- 
Johannes Thumshirn                            SUSE Labs Filesystems
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850