From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 1/1] nvme: add get-feature to admin cmds tracer
Date: Fri, 8 Feb 2019 08:30:40 -0700 [thread overview]
Message-ID: <20190208153039.GA32695@localhost.localdomain> (raw)
In-Reply-To: <c4db17c4-c9fb-cf79-12ae-e2d3ceab123a@suse.de>
On Fri, Feb 08, 2019@12:49:47AM -0800, Johannes Thumshirn wrote:
> On 08/02/2019 09:42, Christoph Hellwig wrote:
> > I don't really care. We clearly have command decoding in the trace
> > points, so adding a little more won't hurt, but I'm also not sure
> > we really need it.
>
> Hmm one thing, *iff* we want to decode the commands in user-space we
> have to agree on one input format for the decoder which then becomes an
> ABI (see for example blktrace). If we decode in the kernel we can easily
> extent it (like we already did with the tracepoints).
>
> IMHO maintaining an ABI like format is a major pain in the lower body
> parts and the benefits from it aren't worth it.
That's fine, I certainly won't nak this and am okay to see this staged for
the next merge window. I just wanted to confirm preference on maintaining
the kernel vs tooling as the spec changes.
next prev parent reply other threads:[~2019-02-08 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 15:13 [PATCH 1/1] nvme: add get-feature to admin cmds tracer Max Gurtovoy
2019-01-31 16:11 ` Keith Busch
2019-01-31 17:01 ` Max Gurtovoy
2019-02-04 8:23 ` Johannes Thumshirn
2019-02-07 10:28 ` Max Gurtovoy
2019-02-08 8:42 ` Christoph Hellwig
2019-02-08 8:49 ` Johannes Thumshirn
2019-02-08 15:30 ` Keith Busch [this message]
2019-02-08 15:39 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208153039.GA32695@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox