From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH, RFC 2/2] nvme: validate cntlid during controller initialisation
Date: Wed, 8 May 2019 08:28:14 -0600 [thread overview]
Message-ID: <20190508142814.GB7113@localhost.localdomain> (raw)
In-Reply-To: <20190508075508.28552-2-hch@lst.de>
On Wed, May 08, 2019@09:55:08AM +0200, Christoph Hellwig wrote:
> + list_for_each_entry(tmp, &subsys->ctrls, subsys_entry) {
> + if (ctrl->state == NVME_CTRL_DELETING ||
> + ctrl->state == NVME_CTRL_DEAD)
> + continue;
> +
> + if (tmp->cntlid == ctrl->cntlid) {
> + dev_err(ctrl->device,
> + "Duplicate cntlid %u, rejecting\n",
> + ctrl->cntlid);
Patch looks great, but let's make this print more informative by showing
tmp's device name too:
dev_err(ctrl->device,
"Duplicate cntlid %u with %s, rejecting\n",
ctrl->cntlid, dev_name(tmp->device));
next prev parent reply other threads:[~2019-05-08 14:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 7:55 [PATCH, RFC 1/2] nvme: change locking for the per-subsystem controller list Christoph Hellwig
2019-05-08 7:55 ` [PATCH, RFC 2/2] nvme: validate cntlid during controller initialisation Christoph Hellwig
2019-05-08 14:28 ` Keith Busch [this message]
2019-05-09 6:15 ` Christoph Hellwig
2019-05-08 18:51 ` Chaitanya Kulkarni
2019-05-09 6:16 ` Christoph Hellwig
2019-05-08 16:47 ` [PATCH, RFC 1/2] nvme: change locking for the per-subsystem controller list Edmund Nadolski
2019-05-09 6:17 ` Christoph Hellwig
2019-05-09 21:43 ` Edmund Nadolski
2019-05-08 22:42 ` Chaitanya Kulkarni
2019-05-09 5:13 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508142814.GB7113@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox