Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 0/3] nvme: Improve processing paused support
Date: Fri, 24 May 2019 14:20:33 -0600	[thread overview]
Message-ID: <20190524202036.17265-1-keith.busch@intel.com> (raw)

From: Keith Busch <kbusch@kernel.org>

Improve firmware activation over what we're currently doing. The main
thing is that we do not want to esacalate recovery while the current
status has CSTS.PP set as the recovery attempt may interfere with a
critical controller operation.

There still exists a race where the controller may clear CSTS Processing
Paused at the same time a stalled request times out. We would normally
want to reset the timer for that, but this is at least a state that can
handle error recovery without interrupting background operations, so
the only harm caused from encountering this unlikely event is a longer
latency back to ready.

My previous patch to address this used help from the block layer, but
had some issues. This series only involves the nvme driver and just
addresses the main concern without addressing the corner cases.

Keith Busch (3):
  nvme-pci: reset timeout when processing is paused
  nvme: rearm fw notification in admin only state
  nvme: quiesce admin queue for fw activation

 drivers/nvme/host/core.c | 9 ++++++++-
 drivers/nvme/host/pci.c  | 2 +-
 2 files changed, 9 insertions(+), 2 deletions(-)

-- 
2.14.4

             reply	other threads:[~2019-05-24 20:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24 20:20 Keith Busch [this message]
2019-05-24 20:20 ` [PATCH 1/3] nvme-pci: reset timeout when processing is paused Keith Busch
2019-05-25 13:22   ` Minwoo Im
2019-06-01  9:07   ` Christoph Hellwig
2019-05-24 20:20 ` [PATCH 2/3] nvme: rearm fw notification in admin only state Keith Busch
2019-06-01  9:08   ` Christoph Hellwig
2019-05-24 20:20 ` [PATCH 3/3] nvme: quiesce admin queue for fw activation Keith Busch
2019-05-25 13:17   ` Minwoo Im
2019-05-25 14:07     ` Keith Busch
2019-05-25 15:05       ` Minwoo Im
2019-05-31 23:32 ` [PATCH 0/3] nvme: Improve processing paused support Sagi Grimberg
2019-06-01  2:45   ` Minwoo Im

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190524202036.17265-1-keith.busch@intel.com \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox