From: minwoo.im.dev@gmail.com (Minwoo Im)
Subject: [PATCH 0/3] nvme: Improve processing paused support
Date: Sat, 1 Jun 2019 11:45:27 +0900 [thread overview]
Message-ID: <20190601024525.GB3349@minwooim-desktop> (raw)
In-Reply-To: <76f0ba18-fb80-7a96-6f53-d4df1d637da5@grimberg.me>
On 19-05-31 16:32:24, Sagi Grimberg wrote:
> This looks sensible to me,
>
> Minwoo, do you have any concerns or feedback? If not
> can I get your review tag?
Actually this series are looking good to me. But, I was just
concerning that if there is better print statement or safe access method
for CSTS.PP bit in the code.
But, the print message is not that critical so that I can make my review
on this. I need to ask Keith about accessing CSTS.PP without seeing
CC.EN can be valid in some cases, by the way :).
For this series:
Reviewed-by: Minwoo Im <minwoo.im.dev at gmail.com>
prev parent reply other threads:[~2019-06-01 2:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 20:20 [PATCH 0/3] nvme: Improve processing paused support Keith Busch
2019-05-24 20:20 ` [PATCH 1/3] nvme-pci: reset timeout when processing is paused Keith Busch
2019-05-25 13:22 ` Minwoo Im
2019-06-01 9:07 ` Christoph Hellwig
2019-05-24 20:20 ` [PATCH 2/3] nvme: rearm fw notification in admin only state Keith Busch
2019-06-01 9:08 ` Christoph Hellwig
2019-05-24 20:20 ` [PATCH 3/3] nvme: quiesce admin queue for fw activation Keith Busch
2019-05-25 13:17 ` Minwoo Im
2019-05-25 14:07 ` Keith Busch
2019-05-25 15:05 ` Minwoo Im
2019-05-31 23:32 ` [PATCH 0/3] nvme: Improve processing paused support Sagi Grimberg
2019-06-01 2:45 ` Minwoo Im [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190601024525.GB3349@minwooim-desktop \
--to=minwoo.im.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox