From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 2/3] nvme: rearm fw notification in admin only state
Date: Sat, 1 Jun 2019 11:08:09 +0200 [thread overview]
Message-ID: <20190601090809.GH6453@lst.de> (raw)
In-Reply-To: <20190524202036.17265-3-keith.busch@intel.com>
On Fri, May 24, 2019@02:20:35PM -0600, Keith Busch wrote:
> + if (ctrl->state != NVME_CTRL_LIVE &&
> + ctrl->state != NVME_CTRL_ADMIN_ONLY)
I think we really
a) need a nvme_ctrl_is_live() helper encapsulating the above
b) audit all checks for NVME_CTRL_LIVE if they really need to use
this helper instead.
next prev parent reply other threads:[~2019-06-01 9:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 20:20 [PATCH 0/3] nvme: Improve processing paused support Keith Busch
2019-05-24 20:20 ` [PATCH 1/3] nvme-pci: reset timeout when processing is paused Keith Busch
2019-05-25 13:22 ` Minwoo Im
2019-06-01 9:07 ` Christoph Hellwig
2019-05-24 20:20 ` [PATCH 2/3] nvme: rearm fw notification in admin only state Keith Busch
2019-06-01 9:08 ` Christoph Hellwig [this message]
2019-05-24 20:20 ` [PATCH 3/3] nvme: quiesce admin queue for fw activation Keith Busch
2019-05-25 13:17 ` Minwoo Im
2019-05-25 14:07 ` Keith Busch
2019-05-25 15:05 ` Minwoo Im
2019-05-31 23:32 ` [PATCH 0/3] nvme: Improve processing paused support Sagi Grimberg
2019-06-01 2:45 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190601090809.GH6453@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox