Linux-NVME Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Muneendra <muneendra.kumar@broadcom.com>,
	linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
	tj@kernel.org, linux-nvme@lists.infradead.org
Cc: jsmart2021@gmail.com, kbuild-all@lists.01.org, mkumar@redhat.com,
	emilne@redhat.com, Muneendra <muneendra.kumar@broadcom.com>,
	pbonzini@redhat.com
Subject: Re: [PATCH v3 19/19] scsi: Made changes in Kconfig to select BLK_CGROUP_FC_APPID
Date: Wed, 4 Nov 2020 02:07:22 +0800	[thread overview]
Message-ID: <202011040242.VbFh1FD9-lkp@intel.com> (raw)
In-Reply-To: <1604387903-20006-20-git-send-email-muneendra.kumar@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 14060 bytes --]

Hi Muneendra,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on scsi/for-next]
[also build test WARNING on cgroup/for-next v5.10-rc2]
[cannot apply to mkp-scsi/for-next next-20201103]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Muneendra/blkcg-Support-to-track-FC-storage-blk-io-traffic/20201103-221403
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: c6x-randconfig-r013-20201103 (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/78074b9ba99b7f8c0cd4b2d0c17589441443775c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Muneendra/blkcg-Support-to-track-FC-storage-blk-io-traffic/20201103-221403
        git checkout 78074b9ba99b7f8c0cd4b2d0c17589441443775c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=c6x 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/writeback.h:14,
                    from include/linux/memcontrol.h:22,
                    from include/linux/swap.h:9,
                    from include/linux/suspend.h:5,
                    from kernel/sched/sched.h:63,
                    from kernel/sched/core.c:13:
   include/linux/blk-cgroup.h: In function 'blkcg_set_fc_appid':
   include/linux/blk-cgroup.h:686:32: error: 'io_cgrp_subsys' undeclared (first use in this function)
     686 |  css = cgroup_get_e_css(cgrp, &io_cgrp_subsys);
         |                                ^~~~~~~~~~~~~~
   include/linux/blk-cgroup.h:686:32: note: each undeclared identifier is reported only once for each function it appears in
   include/linux/blk-cgroup.h:691:10: error: implicit declaration of function 'css_to_blkcg'; did you mean 'pd_to_blkg'? [-Werror=implicit-function-declaration]
     691 |  blkcg = css_to_blkcg(css);
         |          ^~~~~~~~~~~~
         |          pd_to_blkg
>> include/linux/blk-cgroup.h:691:8: warning: assignment to 'struct blkcg *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     691 |  blkcg = css_to_blkcg(css);
         |        ^
   include/linux/blk-cgroup.h:700:15: error: 'struct blkcg' has no member named 'fc_app_id'
     700 |  strlcpy(blkcg->fc_app_id, buf, len);
         |               ^~
   include/linux/blk-cgroup.h: In function 'blkcg_get_fc_appid':
   include/linux/blk-cgroup.h:719:16: error: 'struct bio' has no member named 'bi_blkg'
     719 |  if (bio && bio->bi_blkg &&
         |                ^~
   include/linux/blk-cgroup.h:720:14: error: 'struct bio' has no member named 'bi_blkg'
     720 |    strlen(bio->bi_blkg->blkcg->fc_app_id))
         |              ^~
   include/linux/blk-cgroup.h:721:13: error: 'struct bio' has no member named 'bi_blkg'
     721 |   return bio->bi_blkg->blkcg->fc_app_id;
         |             ^~
   kernel/sched/core.c: In function 'ttwu_stat':
   kernel/sched/core.c:2419:13: warning: variable 'rq' set but not used [-Wunused-but-set-variable]
    2419 |  struct rq *rq;
         |             ^~
   cc1: some warnings being treated as errors
--
   In file included from include/linux/writeback.h:14,
                    from include/linux/memcontrol.h:22,
                    from include/linux/swap.h:9,
                    from include/linux/suspend.h:5,
                    from kernel/sched/sched.h:63,
                    from kernel/sched/loadavg.c:9:
   include/linux/blk-cgroup.h: In function 'blkcg_set_fc_appid':
   include/linux/blk-cgroup.h:686:32: error: 'io_cgrp_subsys' undeclared (first use in this function)
     686 |  css = cgroup_get_e_css(cgrp, &io_cgrp_subsys);
         |                                ^~~~~~~~~~~~~~
   include/linux/blk-cgroup.h:686:32: note: each undeclared identifier is reported only once for each function it appears in
   include/linux/blk-cgroup.h:691:10: error: implicit declaration of function 'css_to_blkcg'; did you mean 'pd_to_blkg'? [-Werror=implicit-function-declaration]
     691 |  blkcg = css_to_blkcg(css);
         |          ^~~~~~~~~~~~
         |          pd_to_blkg
>> include/linux/blk-cgroup.h:691:8: warning: assignment to 'struct blkcg *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     691 |  blkcg = css_to_blkcg(css);
         |        ^
   include/linux/blk-cgroup.h:700:15: error: 'struct blkcg' has no member named 'fc_app_id'
     700 |  strlcpy(blkcg->fc_app_id, buf, len);
         |               ^~
   include/linux/blk-cgroup.h: In function 'blkcg_get_fc_appid':
   include/linux/blk-cgroup.h:719:16: error: 'struct bio' has no member named 'bi_blkg'
     719 |  if (bio && bio->bi_blkg &&
         |                ^~
   include/linux/blk-cgroup.h:720:14: error: 'struct bio' has no member named 'bi_blkg'
     720 |    strlen(bio->bi_blkg->blkcg->fc_app_id))
         |              ^~
   include/linux/blk-cgroup.h:721:13: error: 'struct bio' has no member named 'bi_blkg'
     721 |   return bio->bi_blkg->blkcg->fc_app_id;
         |             ^~
   cc1: some warnings being treated as errors
--
   In file included from include/linux/writeback.h:14,
                    from include/linux/memcontrol.h:22,
                    from include/linux/swap.h:9,
                    from include/linux/suspend.h:5,
                    from kernel/sched/sched.h:63,
                    from kernel/sched/fair.c:23:
   include/linux/blk-cgroup.h: In function 'blkcg_set_fc_appid':
   include/linux/blk-cgroup.h:686:32: error: 'io_cgrp_subsys' undeclared (first use in this function)
     686 |  css = cgroup_get_e_css(cgrp, &io_cgrp_subsys);
         |                                ^~~~~~~~~~~~~~
   include/linux/blk-cgroup.h:686:32: note: each undeclared identifier is reported only once for each function it appears in
   include/linux/blk-cgroup.h:691:10: error: implicit declaration of function 'css_to_blkcg'; did you mean 'pd_to_blkg'? [-Werror=implicit-function-declaration]
     691 |  blkcg = css_to_blkcg(css);
         |          ^~~~~~~~~~~~
         |          pd_to_blkg
>> include/linux/blk-cgroup.h:691:8: warning: assignment to 'struct blkcg *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     691 |  blkcg = css_to_blkcg(css);
         |        ^
   include/linux/blk-cgroup.h:700:15: error: 'struct blkcg' has no member named 'fc_app_id'
     700 |  strlcpy(blkcg->fc_app_id, buf, len);
         |               ^~
   include/linux/blk-cgroup.h: In function 'blkcg_get_fc_appid':
   include/linux/blk-cgroup.h:719:16: error: 'struct bio' has no member named 'bi_blkg'
     719 |  if (bio && bio->bi_blkg &&
         |                ^~
   include/linux/blk-cgroup.h:720:14: error: 'struct bio' has no member named 'bi_blkg'
     720 |    strlen(bio->bi_blkg->blkcg->fc_app_id))
         |              ^~
   include/linux/blk-cgroup.h:721:13: error: 'struct bio' has no member named 'bi_blkg'
     721 |   return bio->bi_blkg->blkcg->fc_app_id;
         |             ^~
   kernel/sched/fair.c: At top level:
   kernel/sched/fair.c:5368:6: warning: no previous prototype for 'init_cfs_bandwidth' [-Wmissing-prototypes]
    5368 | void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
         |      ^~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c:11129:6: warning: no previous prototype for 'free_fair_sched_group' [-Wmissing-prototypes]
   11129 | void free_fair_sched_group(struct task_group *tg) { }
         |      ^~~~~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c:11131:5: warning: no previous prototype for 'alloc_fair_sched_group' [-Wmissing-prototypes]
   11131 | int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
         |     ^~~~~~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c:11136:6: warning: no previous prototype for 'online_fair_sched_group' [-Wmissing-prototypes]
   11136 | void online_fair_sched_group(struct task_group *tg) { }
         |      ^~~~~~~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c:11138:6: warning: no previous prototype for 'unregister_fair_sched_group' [-Wmissing-prototypes]
   11138 | void unregister_fair_sched_group(struct task_group *tg) { }
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from include/linux/writeback.h:14,
                    from include/linux/memcontrol.h:22,
                    from include/linux/swap.h:9,
                    from include/linux/suspend.h:5,
                    from kernel/sched/sched.h:63,
                    from kernel/sched/rt.c:6:
   include/linux/blk-cgroup.h: In function 'blkcg_set_fc_appid':
   include/linux/blk-cgroup.h:686:32: error: 'io_cgrp_subsys' undeclared (first use in this function)
     686 |  css = cgroup_get_e_css(cgrp, &io_cgrp_subsys);
         |                                ^~~~~~~~~~~~~~
   include/linux/blk-cgroup.h:686:32: note: each undeclared identifier is reported only once for each function it appears in
   include/linux/blk-cgroup.h:691:10: error: implicit declaration of function 'css_to_blkcg'; did you mean 'pd_to_blkg'? [-Werror=implicit-function-declaration]
     691 |  blkcg = css_to_blkcg(css);
         |          ^~~~~~~~~~~~
         |          pd_to_blkg
>> include/linux/blk-cgroup.h:691:8: warning: assignment to 'struct blkcg *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     691 |  blkcg = css_to_blkcg(css);
         |        ^
   include/linux/blk-cgroup.h:700:15: error: 'struct blkcg' has no member named 'fc_app_id'
     700 |  strlcpy(blkcg->fc_app_id, buf, len);
         |               ^~
   include/linux/blk-cgroup.h: In function 'blkcg_get_fc_appid':
   include/linux/blk-cgroup.h:719:16: error: 'struct bio' has no member named 'bi_blkg'
     719 |  if (bio && bio->bi_blkg &&
         |                ^~
   include/linux/blk-cgroup.h:720:14: error: 'struct bio' has no member named 'bi_blkg'
     720 |    strlen(bio->bi_blkg->blkcg->fc_app_id))
         |              ^~
   include/linux/blk-cgroup.h:721:13: error: 'struct bio' has no member named 'bi_blkg'
     721 |   return bio->bi_blkg->blkcg->fc_app_id;
         |             ^~
   kernel/sched/rt.c: At top level:
   kernel/sched/rt.c:253:6: warning: no previous prototype for 'free_rt_sched_group' [-Wmissing-prototypes]
     253 | void free_rt_sched_group(struct task_group *tg) { }
         |      ^~~~~~~~~~~~~~~~~~~
   kernel/sched/rt.c:255:5: warning: no previous prototype for 'alloc_rt_sched_group' [-Wmissing-prototypes]
     255 | int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent)
         |     ^~~~~~~~~~~~~~~~~~~~
   kernel/sched/rt.c:668:6: warning: no previous prototype for 'sched_rt_bandwidth_account' [-Wmissing-prototypes]
     668 | bool sched_rt_bandwidth_account(struct rt_rq *rt_rq)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +691 include/linux/blk-cgroup.h

835f4599c6dcff2 Muneendra 2020-11-03  668  
835f4599c6dcff2 Muneendra 2020-11-03  669  #ifdef CONFIG_BLK_CGROUP_FC_APPID
835f4599c6dcff2 Muneendra 2020-11-03  670  /*
835f4599c6dcff2 Muneendra 2020-11-03  671   * Sets the fc_app_id field associted to blkcg
835f4599c6dcff2 Muneendra 2020-11-03  672   * @buf: application identifier
835f4599c6dcff2 Muneendra 2020-11-03  673   * @id: cgrp id
835f4599c6dcff2 Muneendra 2020-11-03  674   * @len: size of appid
835f4599c6dcff2 Muneendra 2020-11-03  675   */
835f4599c6dcff2 Muneendra 2020-11-03  676  static inline int blkcg_set_fc_appid(char *buf, u64 id, size_t len)
835f4599c6dcff2 Muneendra 2020-11-03  677  {
835f4599c6dcff2 Muneendra 2020-11-03  678  	struct cgroup *cgrp = NULL;
835f4599c6dcff2 Muneendra 2020-11-03  679  	struct cgroup_subsys_state *css = NULL;
835f4599c6dcff2 Muneendra 2020-11-03  680  	struct blkcg *blkcg = NULL;
835f4599c6dcff2 Muneendra 2020-11-03  681  	int ret  = 0;
835f4599c6dcff2 Muneendra 2020-11-03  682  
835f4599c6dcff2 Muneendra 2020-11-03  683  	cgrp = cgroup_get_from_kernfs_id(id);
835f4599c6dcff2 Muneendra 2020-11-03  684  	if (!cgrp)
835f4599c6dcff2 Muneendra 2020-11-03  685  		return -ENOENT;
835f4599c6dcff2 Muneendra 2020-11-03  686  	css = cgroup_get_e_css(cgrp, &io_cgrp_subsys);
835f4599c6dcff2 Muneendra 2020-11-03  687  	if (!css) {
835f4599c6dcff2 Muneendra 2020-11-03  688  		ret = -ENOENT;
835f4599c6dcff2 Muneendra 2020-11-03  689  		goto out_cgrp_put;
835f4599c6dcff2 Muneendra 2020-11-03  690  	}
835f4599c6dcff2 Muneendra 2020-11-03 @691  	blkcg = css_to_blkcg(css);
835f4599c6dcff2 Muneendra 2020-11-03  692  	if (!blkcg) {
835f4599c6dcff2 Muneendra 2020-11-03  693  		ret = -ENOENT;
835f4599c6dcff2 Muneendra 2020-11-03  694  		goto out_put;
835f4599c6dcff2 Muneendra 2020-11-03  695  	}
835f4599c6dcff2 Muneendra 2020-11-03  696  	if (len > APPID_LEN) {
835f4599c6dcff2 Muneendra 2020-11-03  697  		ret = -EINVAL;
835f4599c6dcff2 Muneendra 2020-11-03  698  		goto out_put;
835f4599c6dcff2 Muneendra 2020-11-03  699  	}
835f4599c6dcff2 Muneendra 2020-11-03  700  	strlcpy(blkcg->fc_app_id, buf, len);
835f4599c6dcff2 Muneendra 2020-11-03  701  out_put:
835f4599c6dcff2 Muneendra 2020-11-03  702  	css_put(css);
835f4599c6dcff2 Muneendra 2020-11-03  703  out_cgrp_put:
835f4599c6dcff2 Muneendra 2020-11-03  704  	cgroup_put(cgrp);
835f4599c6dcff2 Muneendra 2020-11-03  705  	return ret;
835f4599c6dcff2 Muneendra 2020-11-03  706  }
835f4599c6dcff2 Muneendra 2020-11-03  707  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26511 bytes --]

[-- Attachment #3: Type: text/plain, Size: 158 bytes --]

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-11-03 18:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03  7:18 [PATCH v3 00/19] blkcg:Support to track FC storage blk io traffic Muneendra
2020-11-03  7:18 ` [PATCH v3 01/19] cgroup: Added cgroup_get_from_kernfs_id Muneendra
2020-11-09 13:49   ` Tejun Heo
2020-11-03  7:18 ` [PATCH v3 02/19] blkcg: Added a app identifier support for blkcg Muneendra
2020-11-03  7:18 ` [PATCH v3 03/19] nvme: Added a newsysfs attribute appid_store Muneendra
2020-11-03  7:18 ` [PATCH v3 04/19] lpfc: vmid: Add the datastructure for supporting VMID in lpfc Muneendra
2020-11-03  7:18 ` [PATCH v3 05/19] lpfc: vmid: API to check if VMID is enabled Muneendra
2020-11-03  7:18 ` [PATCH v3 06/19] lpfc: vmid: Supplementary data structures for vmid Muneendra
2020-11-03  7:18 ` [PATCH v3 07/19] lpfc: vmid: Forward declarations for APIs Muneendra
2020-11-03  7:18 ` [PATCH v3 08/19] lpfc: vmid: Add support for vmid in mailbox command Muneendra
2020-11-03  7:18 ` [PATCH v3 09/19] lpfc: vmid: VMID params initialization Muneendra
2020-11-03  7:18 ` [PATCH v3 10/19] lpfc: vmid: vmid resource allocation Muneendra
2020-11-03  7:18 ` [PATCH v3 11/19] lpfc: vmid: cleanup vmid resources Muneendra
2020-11-03  7:18 ` [PATCH v3 12/19] lpfc: vmid: Implements ELS commands for appid patch Muneendra
2020-11-03  7:18 ` [PATCH v3 13/19] lpfc: vmid: Functions to manage vmids Muneendra
2020-11-03  7:18 ` [PATCH v3 14/19] lpfc: vmid: Implements CT commands for appid Muneendra
2020-11-03  7:18 ` [PATCH v3 15/19] lpfc: vmid: Appends the vmid in the wqe before sending request Muneendra
2020-11-03  7:18 ` [PATCH v3 16/19] lpfc: vmid: Timeout implementation for vmid Muneendra
2020-11-03  7:18 ` [PATCH v3 17/19] lpfc: vmid: Adding qfpa and vmid timeout check in worker thread Muneendra
2020-11-03  7:18 ` [PATCH v3 18/19] lpfc: vmid: Introducing vmid in io path Muneendra
2020-11-03  7:18 ` [PATCH v3 19/19] scsi: Made changes in Kconfig to select BLK_CGROUP_FC_APPID Muneendra
2020-11-03 18:07   ` kernel test robot [this message]
2020-11-03 21:19   ` kernel test robot
2020-11-04  0:55   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202011040242.VbFh1FD9-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=emilne@redhat.com \
    --cc=jsmart2021@gmail.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mkumar@redhat.com \
    --cc=muneendra.kumar@broadcom.com \
    --cc=pbonzini@redhat.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox