From: kernel test robot <lkp@intel.com>
To: Muneendra <muneendra.kumar@broadcom.com>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
tj@kernel.org, linux-nvme@lists.infradead.org
Cc: jsmart2021@gmail.com, kbuild-all@lists.01.org, mkumar@redhat.com,
emilne@redhat.com, Muneendra <muneendra.kumar@broadcom.com>,
pbonzini@redhat.com
Subject: Re: [PATCH v3 19/19] scsi: Made changes in Kconfig to select BLK_CGROUP_FC_APPID
Date: Wed, 4 Nov 2020 08:55:32 +0800 [thread overview]
Message-ID: <202011040846.2AS0qfae-lkp@intel.com> (raw)
In-Reply-To: <1604387903-20006-20-git-send-email-muneendra.kumar@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 8271 bytes --]
Hi Muneendra,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on scsi/for-next]
[also build test ERROR on cgroup/for-next v5.10-rc2]
[cannot apply to mkp-scsi/for-next next-20201103]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Muneendra/blkcg-Support-to-track-FC-storage-blk-io-traffic/20201103-221403
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: mips-rm200_defconfig (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/78074b9ba99b7f8c0cd4b2d0c17589441443775c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Muneendra/blkcg-Support-to-track-FC-storage-blk-io-traffic/20201103-221403
git checkout 78074b9ba99b7f8c0cd4b2d0c17589441443775c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
WARNING: unmet direct dependencies detected for BLK_CGROUP_FC_APPID
Depends on BLOCK && BLK_CGROUP
Selected by
- SCSI_FC_ATTRS && SCSI && NET
In file included from include/linux/writeback.h:14,
from include/linux/memcontrol.h:22,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from arch/mips/kernel/asm-offsets.c:17:
include/linux/blk-cgroup.h: In function 'blkcg_set_fc_appid':
>> include/linux/blk-cgroup.h:686:8: error: implicit declaration of function 'cgroup_get_e_css'; did you mean
686 | css = cgroup_get_e_css(cgrp, &io_cgrp_subsys);
| ^~~~~~~~~~~~~~~~
| cgroup_release
include/linux/blk-cgroup.h:686:32: error: 'io_cgrp_subsys' undeclared (first use in this function)
686 | css = cgroup_get_e_css(cgrp, &io_cgrp_subsys);
| ^~~~~~~~~~~~~~
include/linux/blk-cgroup.h:686:32: note: each undeclared identifier is reported only once for each function it appears in
include/linux/blk-cgroup.h:691:10: error: implicit declaration of function 'css_to_blkcg'; did you mean
691 | blkcg = css_to_blkcg(css);
| ^~~~~~~~~~~~
| pd_to_blkg
include/linux/blk-cgroup.h:691:8: warning: assignment to 'struct blkcg from 'int' makes pointer from integer without a cast
691 | blkcg = css_to_blkcg(css);
| ^
include/linux/blk-cgroup.h:700:15: error: 'struct blkcg' has no member named 'fc_app_id'
700 | strlcpy(blkcg->fc_app_id, buf, len);
| ^~
>> include/linux/blk-cgroup.h:704:2: error: implicit declaration of function 'cgroup_put'; did you mean
704 | cgroup_put(cgrp);
| ^~~~~~~~~~
| cgroup_psi
include/linux/blk-cgroup.h: In function 'blkcg_get_fc_appid':
include/linux/blk-cgroup.h:719:16: error: 'struct bio' has no member named 'bi_blkg'
719 | if (bio && bio->bi_blkg &&
| ^~
include/linux/blk-cgroup.h:720:14: error: 'struct bio' has no member named 'bi_blkg'
720 | strlen(bio->bi_blkg->blkcg->fc_app_id))
| ^~
include/linux/blk-cgroup.h:721:13: error: 'struct bio' has no member named 'bi_blkg'
721 | return bio->bi_blkg->blkcg->fc_app_id;
| ^~
arch/mips/kernel/asm-offsets.c: At top level:
arch/mips/kernel/asm-offsets.c:26:6: warning: no previous prototype for 'output_ptreg_defines'
26 | void output_ptreg_defines(void)
| ^~~~~~~~~~~~~~~~~~~~
arch/mips/kernel/asm-offsets.c:78:6: warning: no previous prototype for 'output_task_defines'
78 | void output_task_defines(void)
| ^~~~~~~~~~~~~~~~~~~
arch/mips/kernel/asm-offsets.c:93:6: warning: no previous prototype for 'output_thread_info_defines'
93 | void output_thread_info_defines(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
arch/mips/kernel/asm-offsets.c:110:6: warning: no previous prototype for 'output_thread_defines'
110 | void output_thread_defines(void)
| ^~~~~~~~~~~~~~~~~~~~~
arch/mips/kernel/asm-offsets.c:138:6: warning: no previous prototype for 'output_thread_fpu_defines'
138 | void output_thread_fpu_defines(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
arch/mips/kernel/asm-offsets.c:181:6: warning: no previous prototype for 'output_mm_defines'
181 | void output_mm_defines(void)
| ^~~~~~~~~~~~~~~~~
arch/mips/kernel/asm-offsets.c:220:6: warning: no previous prototype for 'output_sc_defines'
220 | void output_sc_defines(void)
| ^~~~~~~~~~~~~~~~~
arch/mips/kernel/asm-offsets.c:255:6: warning: no previous prototype for 'output_signal_defined'
255 | void output_signal_defined(void)
| ^~~~~~~~~~~~~~~~~~~~~
arch/mips/kernel/asm-offsets.c:348:6: warning: no previous prototype for 'output_kvm_defines'
348 | void output_kvm_defines(void)
| ^~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
Makefile arch include kernel scripts source usr [scripts/Makefile.build:117: arch/mips/kernel/asm-offsets.s] Error 1
Target '__build' not remade because of errors.
Makefile arch include kernel scripts source usr [Makefile:1200: prepare0] Error 2
Target 'prepare' not remade because of errors.
make: Makefile arch include kernel scripts source usr [Makefile:185: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +/cgroup_get_e_css +686 include/linux/blk-cgroup.h
835f4599c6dcff2 Muneendra 2020-11-03 668
835f4599c6dcff2 Muneendra 2020-11-03 669 #ifdef CONFIG_BLK_CGROUP_FC_APPID
835f4599c6dcff2 Muneendra 2020-11-03 670 /*
835f4599c6dcff2 Muneendra 2020-11-03 671 * Sets the fc_app_id field associted to blkcg
835f4599c6dcff2 Muneendra 2020-11-03 672 * @buf: application identifier
835f4599c6dcff2 Muneendra 2020-11-03 673 * @id: cgrp id
835f4599c6dcff2 Muneendra 2020-11-03 674 * @len: size of appid
835f4599c6dcff2 Muneendra 2020-11-03 675 */
835f4599c6dcff2 Muneendra 2020-11-03 676 static inline int blkcg_set_fc_appid(char *buf, u64 id, size_t len)
835f4599c6dcff2 Muneendra 2020-11-03 677 {
835f4599c6dcff2 Muneendra 2020-11-03 678 struct cgroup *cgrp = NULL;
835f4599c6dcff2 Muneendra 2020-11-03 679 struct cgroup_subsys_state *css = NULL;
835f4599c6dcff2 Muneendra 2020-11-03 680 struct blkcg *blkcg = NULL;
835f4599c6dcff2 Muneendra 2020-11-03 681 int ret = 0;
835f4599c6dcff2 Muneendra 2020-11-03 682
835f4599c6dcff2 Muneendra 2020-11-03 683 cgrp = cgroup_get_from_kernfs_id(id);
835f4599c6dcff2 Muneendra 2020-11-03 684 if (!cgrp)
835f4599c6dcff2 Muneendra 2020-11-03 685 return -ENOENT;
835f4599c6dcff2 Muneendra 2020-11-03 @686 css = cgroup_get_e_css(cgrp, &io_cgrp_subsys);
835f4599c6dcff2 Muneendra 2020-11-03 687 if (!css) {
835f4599c6dcff2 Muneendra 2020-11-03 688 ret = -ENOENT;
835f4599c6dcff2 Muneendra 2020-11-03 689 goto out_cgrp_put;
835f4599c6dcff2 Muneendra 2020-11-03 690 }
835f4599c6dcff2 Muneendra 2020-11-03 691 blkcg = css_to_blkcg(css);
835f4599c6dcff2 Muneendra 2020-11-03 692 if (!blkcg) {
835f4599c6dcff2 Muneendra 2020-11-03 693 ret = -ENOENT;
835f4599c6dcff2 Muneendra 2020-11-03 694 goto out_put;
835f4599c6dcff2 Muneendra 2020-11-03 695 }
835f4599c6dcff2 Muneendra 2020-11-03 696 if (len > APPID_LEN) {
835f4599c6dcff2 Muneendra 2020-11-03 697 ret = -EINVAL;
835f4599c6dcff2 Muneendra 2020-11-03 698 goto out_put;
835f4599c6dcff2 Muneendra 2020-11-03 699 }
835f4599c6dcff2 Muneendra 2020-11-03 700 strlcpy(blkcg->fc_app_id, buf, len);
835f4599c6dcff2 Muneendra 2020-11-03 701 out_put:
835f4599c6dcff2 Muneendra 2020-11-03 702 css_put(css);
835f4599c6dcff2 Muneendra 2020-11-03 703 out_cgrp_put:
835f4599c6dcff2 Muneendra 2020-11-03 @704 cgroup_put(cgrp);
835f4599c6dcff2 Muneendra 2020-11-03 705 return ret;
835f4599c6dcff2 Muneendra 2020-11-03 706 }
835f4599c6dcff2 Muneendra 2020-11-03 707
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 18917 bytes --]
[-- Attachment #3: Type: text/plain, Size: 158 bytes --]
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2020-11-04 0:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 7:18 [PATCH v3 00/19] blkcg:Support to track FC storage blk io traffic Muneendra
2020-11-03 7:18 ` [PATCH v3 01/19] cgroup: Added cgroup_get_from_kernfs_id Muneendra
2020-11-09 13:49 ` Tejun Heo
2020-11-03 7:18 ` [PATCH v3 02/19] blkcg: Added a app identifier support for blkcg Muneendra
2020-11-03 7:18 ` [PATCH v3 03/19] nvme: Added a newsysfs attribute appid_store Muneendra
2020-11-03 7:18 ` [PATCH v3 04/19] lpfc: vmid: Add the datastructure for supporting VMID in lpfc Muneendra
2020-11-03 7:18 ` [PATCH v3 05/19] lpfc: vmid: API to check if VMID is enabled Muneendra
2020-11-03 7:18 ` [PATCH v3 06/19] lpfc: vmid: Supplementary data structures for vmid Muneendra
2020-11-03 7:18 ` [PATCH v3 07/19] lpfc: vmid: Forward declarations for APIs Muneendra
2020-11-03 7:18 ` [PATCH v3 08/19] lpfc: vmid: Add support for vmid in mailbox command Muneendra
2020-11-03 7:18 ` [PATCH v3 09/19] lpfc: vmid: VMID params initialization Muneendra
2020-11-03 7:18 ` [PATCH v3 10/19] lpfc: vmid: vmid resource allocation Muneendra
2020-11-03 7:18 ` [PATCH v3 11/19] lpfc: vmid: cleanup vmid resources Muneendra
2020-11-03 7:18 ` [PATCH v3 12/19] lpfc: vmid: Implements ELS commands for appid patch Muneendra
2020-11-03 7:18 ` [PATCH v3 13/19] lpfc: vmid: Functions to manage vmids Muneendra
2020-11-03 7:18 ` [PATCH v3 14/19] lpfc: vmid: Implements CT commands for appid Muneendra
2020-11-03 7:18 ` [PATCH v3 15/19] lpfc: vmid: Appends the vmid in the wqe before sending request Muneendra
2020-11-03 7:18 ` [PATCH v3 16/19] lpfc: vmid: Timeout implementation for vmid Muneendra
2020-11-03 7:18 ` [PATCH v3 17/19] lpfc: vmid: Adding qfpa and vmid timeout check in worker thread Muneendra
2020-11-03 7:18 ` [PATCH v3 18/19] lpfc: vmid: Introducing vmid in io path Muneendra
2020-11-03 7:18 ` [PATCH v3 19/19] scsi: Made changes in Kconfig to select BLK_CGROUP_FC_APPID Muneendra
2020-11-03 18:07 ` kernel test robot
2020-11-03 21:19 ` kernel test robot
2020-11-04 0:55 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202011040846.2AS0qfae-lkp@intel.com \
--to=lkp@intel.com \
--cc=emilne@redhat.com \
--cc=jsmart2021@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkumar@redhat.com \
--cc=muneendra.kumar@broadcom.com \
--cc=pbonzini@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox