From: Tejun Heo <tj@kernel.org>
To: Muneendra <muneendra.kumar@broadcom.com>
Cc: jsmart2021@gmail.com, mkumar@redhat.com,
linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, emilne@redhat.com,
pbonzini@redhat.com
Subject: Re: [PATCH v3 01/19] cgroup: Added cgroup_get_from_kernfs_id
Date: Mon, 9 Nov 2020 08:49:33 -0500 [thread overview]
Message-ID: <20201109134933.GC7496@mtj.duckdns.org> (raw)
In-Reply-To: <1604387903-20006-2-git-send-email-muneendra.kumar@broadcom.com>
Hello,
Generally looks good to me. A few nits.
On Tue, Nov 03, 2020 at 12:48:05PM +0530, Muneendra wrote:
> Added a new function cgroup_get_from_kernfs_id to retrieve the cgroup
> associated with cgroup id.
> It takes cgroupid as an argument and returns cgrp and on failure
> it returns NULL.
> Exported the same as this can be used by blk-cgorup.c
Can you please reflow the above paragraph?
> +struct cgroup *cgroup_get_from_kernfs_id(u64 id);
Let's just name it cgroup_get_from_id(). There's no other id. We can rename
cgroup_path_from_kernfs_id() later.
> +/*
/** starts a function comment.
> + * cgroup_get_from_kernfs_id : get the cgroup associated with cgroup id
> + * @id: cgroup id
> + * On success it returns the cgrp on failure it returns NULL
> + */
With the above nits updated, please feel free to add
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-11-09 13:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 7:18 [PATCH v3 00/19] blkcg:Support to track FC storage blk io traffic Muneendra
2020-11-03 7:18 ` [PATCH v3 01/19] cgroup: Added cgroup_get_from_kernfs_id Muneendra
2020-11-09 13:49 ` Tejun Heo [this message]
2020-11-03 7:18 ` [PATCH v3 02/19] blkcg: Added a app identifier support for blkcg Muneendra
2020-11-03 7:18 ` [PATCH v3 03/19] nvme: Added a newsysfs attribute appid_store Muneendra
2020-11-03 7:18 ` [PATCH v3 04/19] lpfc: vmid: Add the datastructure for supporting VMID in lpfc Muneendra
2020-11-03 7:18 ` [PATCH v3 05/19] lpfc: vmid: API to check if VMID is enabled Muneendra
2020-11-03 7:18 ` [PATCH v3 06/19] lpfc: vmid: Supplementary data structures for vmid Muneendra
2020-11-03 7:18 ` [PATCH v3 07/19] lpfc: vmid: Forward declarations for APIs Muneendra
2020-11-03 7:18 ` [PATCH v3 08/19] lpfc: vmid: Add support for vmid in mailbox command Muneendra
2020-11-03 7:18 ` [PATCH v3 09/19] lpfc: vmid: VMID params initialization Muneendra
2020-11-03 7:18 ` [PATCH v3 10/19] lpfc: vmid: vmid resource allocation Muneendra
2020-11-03 7:18 ` [PATCH v3 11/19] lpfc: vmid: cleanup vmid resources Muneendra
2020-11-03 7:18 ` [PATCH v3 12/19] lpfc: vmid: Implements ELS commands for appid patch Muneendra
2020-11-03 7:18 ` [PATCH v3 13/19] lpfc: vmid: Functions to manage vmids Muneendra
2020-11-03 7:18 ` [PATCH v3 14/19] lpfc: vmid: Implements CT commands for appid Muneendra
2020-11-03 7:18 ` [PATCH v3 15/19] lpfc: vmid: Appends the vmid in the wqe before sending request Muneendra
2020-11-03 7:18 ` [PATCH v3 16/19] lpfc: vmid: Timeout implementation for vmid Muneendra
2020-11-03 7:18 ` [PATCH v3 17/19] lpfc: vmid: Adding qfpa and vmid timeout check in worker thread Muneendra
2020-11-03 7:18 ` [PATCH v3 18/19] lpfc: vmid: Introducing vmid in io path Muneendra
2020-11-03 7:18 ` [PATCH v3 19/19] scsi: Made changes in Kconfig to select BLK_CGROUP_FC_APPID Muneendra
2020-11-03 18:07 ` kernel test robot
2020-11-03 21:19 ` kernel test robot
2020-11-04 0:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109134933.GC7496@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=emilne@redhat.com \
--cc=jsmart2021@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkumar@redhat.com \
--cc=muneendra.kumar@broadcom.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox