From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Michal Krakowiak <michal.krakowiak@intel.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
Michal Krakowiak <michal.krakowiak@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: trace: parse format nvm command in detail
Date: Wed, 6 Jan 2021 10:00:53 +0100 [thread overview]
Message-ID: <20210106090053.GA32643@lst.de> (raw)
In-Reply-To: <20210104160220.GB1024941@dhcp-10-100-145-180.wdc.com>
On Mon, Jan 04, 2021 at 08:02:20AM -0800, Keith Busch wrote:
> Perhaps it's too late since we've already gone done this path in the
> driver, but IMO, we should have only traced raw dwords without any
> additional decoding. This would have allowed consistent output for all
> kernel versions and resilient to future spec changes. Then that could
> have made possible for a user space utility to do the decoding to a
> human friendly format, kind of like what blkparse does for block layer
> trace events.
the block tracepoints actually contain pretty detailed decoding as well.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-06 9:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 15:53 [PATCH] nvme: trace: parse format nvm command in detail Michal Krakowiak
2021-01-04 16:02 ` Keith Busch
2021-01-06 9:00 ` Christoph Hellwig [this message]
2021-01-08 22:34 ` Keith Busch
2021-01-09 0:12 ` Dan Williams
2021-01-11 17:01 ` Keith Busch
2021-01-11 17:10 ` Dan Williams
2021-01-11 17:50 ` Keith Busch
2021-01-11 20:15 ` Michal Krakowiak
2021-01-12 8:33 ` Christoph Hellwig
2021-01-05 19:31 ` Minwoo Im
2021-01-27 17:46 ` Christoph Hellwig
2021-01-28 12:25 ` Michal Krakowiak
2021-01-28 12:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106090053.GA32643@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=dan.j.williams@intel.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=michal.krakowiak@intel.com \
--cc=michal.krakowiak@linux.intel.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox