From: Minwoo Im <minwoo.im.dev@gmail.com>
To: linux-nvme@lists.infradead.org
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Minwoo Im <minwoo.im.dev@gmail.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: [PATCH V3 1/3] nvme: check all retry delay times in Identify Controller
Date: Thu, 14 Jan 2021 22:31:08 +0900 [thread overview]
Message-ID: <20210114133110.20779-2-minwoo.im.dev@gmail.com> (raw)
In-Reply-To: <20210114133110.20779-1-minwoo.im.dev@gmail.com>
If none of Command Retry Delay Time(CRDT)s are set, then we can simply
skip to configure Advanced Command Retry Enable(ACRE).
CRDT selection will be made in Completion Queue Entry that controller
has responsibility to decide.
This patch checks all CRDT[0, 1, and 2] in Identify Controller data
structrure instead of checking the first one: CRDT[0] for cases that:
- CRDT[0] == 0, but CRDT[1 or 2] != 0
Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index fff49e544fdf..a8cee380b3c0 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2499,7 +2499,7 @@ static int nvme_configure_acre(struct nvme_ctrl *ctrl)
int ret;
/* Don't bother enabling the feature if retry delay is not reported */
- if (!ctrl->crdt[0])
+ if (!ctrl->crdt[0] && !ctrl->crdt[1] && !ctrl->crdt[2])
return 0;
host = kzalloc(sizeof(*host), GFP_KERNEL);
--
2.17.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-14 13:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 13:31 [PATCH V3 0/3] nvme: fixes for command retry Minwoo Im
2021-01-14 13:31 ` Minwoo Im [this message]
2021-01-19 3:43 ` [PATCH V3 1/3] nvme: check all retry delay times in Identify Controller Minwoo Im
2021-01-14 13:31 ` [PATCH V3 2/3] nvme: introduce acre flag in nvme_ctrl Minwoo Im
2021-01-15 2:16 ` Chao Leng
2021-01-14 13:31 ` [PATCH V3 3/3] nvme: retry commands based on ACRE flag Minwoo Im
2021-01-15 2:17 ` Chao Leng
2021-01-15 17:04 ` Keith Busch
2021-01-15 18:26 ` Minwoo Im
2021-01-18 17:40 ` Christoph Hellwig
2021-01-19 3:30 ` Minwoo Im
2021-01-19 18:28 ` Keith Busch
2021-01-20 0:52 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114133110.20779-2-minwoo.im.dev@gmail.com \
--to=minwoo.im.dev@gmail.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox