From: Minwoo Im <minwoo.im.dev@gmail.com>
To: linux-nvme@lists.infradead.org
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Minwoo Im <minwoo.im.dev@gmail.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: [PATCH V3 2/3] nvme: introduce acre flag in nvme_ctrl
Date: Thu, 14 Jan 2021 22:31:09 +0900 [thread overview]
Message-ID: <20210114133110.20779-3-minwoo.im.dev@gmail.com> (raw)
In-Reply-To: <20210114133110.20779-1-minwoo.im.dev@gmail.com>
Advanced Command Retry Enable (ACRE) flag is added in nvme_ctrl
instance to indicate that Set Features for Host Behavior Support with
ACRE enabled is whether successfully done or not during reset_work.
This flag will be used to decide to retry commands that fail or not in
the followed patch.
Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
---
drivers/nvme/host/core.c | 6 ++++++
drivers/nvme/host/nvme.h | 1 +
2 files changed, 7 insertions(+)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index a8cee380b3c0..a286e3422c61 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2498,6 +2498,8 @@ static int nvme_configure_acre(struct nvme_ctrl *ctrl)
struct nvme_feat_host_behavior *host;
int ret;
+ ctrl->acre = false;
+
/* Don't bother enabling the feature if retry delay is not reported */
if (!ctrl->crdt[0] && !ctrl->crdt[1] && !ctrl->crdt[2])
return 0;
@@ -2509,6 +2511,10 @@ static int nvme_configure_acre(struct nvme_ctrl *ctrl)
host->acre = NVME_ENABLE_ACRE;
ret = nvme_set_features(ctrl, NVME_FEAT_HOST_BEHAVIOR, 0,
host, sizeof(*host), NULL);
+
+ if (!ret)
+ ctrl->acre = true;
+
kfree(host);
return ret;
}
diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index 88a6b97247f5..db8b45e8ffde 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -270,6 +270,7 @@ struct nvme_ctrl {
#ifdef CONFIG_BLK_DEV_ZONED
u32 max_zone_append;
#endif
+ bool acre;
u16 crdt[3];
u16 oncs;
u16 oacs;
--
2.17.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-14 13:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 13:31 [PATCH V3 0/3] nvme: fixes for command retry Minwoo Im
2021-01-14 13:31 ` [PATCH V3 1/3] nvme: check all retry delay times in Identify Controller Minwoo Im
2021-01-19 3:43 ` Minwoo Im
2021-01-14 13:31 ` Minwoo Im [this message]
2021-01-15 2:16 ` [PATCH V3 2/3] nvme: introduce acre flag in nvme_ctrl Chao Leng
2021-01-14 13:31 ` [PATCH V3 3/3] nvme: retry commands based on ACRE flag Minwoo Im
2021-01-15 2:17 ` Chao Leng
2021-01-15 17:04 ` Keith Busch
2021-01-15 18:26 ` Minwoo Im
2021-01-18 17:40 ` Christoph Hellwig
2021-01-19 3:30 ` Minwoo Im
2021-01-19 18:28 ` Keith Busch
2021-01-20 0:52 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114133110.20779-3-minwoo.im.dev@gmail.com \
--to=minwoo.im.dev@gmail.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox