From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
Daniel Wagner <daniel.wagner@suse.de>
Subject: Re: [PATCHv3] nvme-mpath: delete disk after last connection
Date: Thu, 6 May 2021 09:43:41 +0200 [thread overview]
Message-ID: <20210506074341.GC14615@lst.de> (raw)
In-Reply-To: <d1ca6eab-1ec9-d6c7-ed8a-00d9110bf023@grimberg.me>
On Tue, May 04, 2021 at 12:54:14PM -0700, Sagi Grimberg wrote:
> Yes, I'm not sure I understand your comment Christoph. This addresses an
> issue with mdraid where hot unplug+replug does not restore the device to
> the raid group (pci and fabrics alike), where before multipath this used
> to work.
>
> queue_if_no_path is a dm-multipath feature so I'm not entirely clear
> what is the concern? mdraid on nvme (pci/fabrics) used to work a certain
> way, with the introduction of nvme-mpath the behavior was broken (as far
> as I understand from Hannes).
AFAIK that specific mdraid behavior is also fixed by the uevent patch
he sent.
> My thinking is that if we want queue_if_no_path functionality in nvme
> mpath we should have it explicitly stated properly such that people
> that actually need it will use it and have mdraid function correctly
> again. Also, queue_if_no_path applies really if all the paths are
> gone in the sense they are completely removed, and doesn't apply
> to controller reset/reconnect.
>
> I agree we should probably have queue_if_no_path attribute on the
> mpath device, but it doesn't sound right to default it to true given
> that it breaks mdraid stacking on top of it..
I really do not think we should change the mpath behaviors years after
first adding it.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-05-06 7:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 12:04 [PATCHv3] nvme-mpath: delete disk after last connection Hannes Reinecke
2021-05-04 8:54 ` Christoph Hellwig
2021-05-04 13:40 ` Hannes Reinecke
2021-05-04 19:54 ` Sagi Grimberg
2021-05-05 15:26 ` Keith Busch
2021-05-05 16:15 ` Hannes Reinecke
2021-05-05 20:40 ` Sagi Grimberg
2021-05-06 2:50 ` Keith Busch
2021-05-06 6:13 ` Hannes Reinecke
2021-05-06 7:43 ` Christoph Hellwig [this message]
2021-05-06 8:42 ` Hannes Reinecke
2021-05-06 9:47 ` Sagi Grimberg
2021-05-06 12:08 ` Christoph Hellwig
2021-05-06 15:54 ` Hannes Reinecke
2021-05-07 6:46 ` Christoph Hellwig
2021-05-07 17:02 ` Hannes Reinecke
2021-05-07 17:20 ` Sagi Grimberg
2021-05-10 6:23 ` Christoph Hellwig
2021-05-10 13:01 ` Hannes Reinecke
2021-05-10 13:57 ` Hannes Reinecke
2021-05-10 14:48 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506074341.GC14615@lst.de \
--to=hch@lst.de \
--cc=daniel.wagner@suse.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox