From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
Daniel Wagner <daniel.wagner@suse.de>
Subject: Re: [PATCHv3] nvme-mpath: delete disk after last connection
Date: Thu, 6 May 2021 17:54:29 +0200 [thread overview]
Message-ID: <7cd891d9-6aa0-fd98-cbc5-1df2eabbe31d@suse.de> (raw)
In-Reply-To: <20210506120855.GA1546@lst.de>
On 5/6/21 2:08 PM, Christoph Hellwig wrote:
> On Thu, May 06, 2021 at 02:47:00AM -0700, Sagi Grimberg wrote:
>> That is my assumption as well, and its a problem that by default
>> a pci device unplugs or a fabrics controller is lost and removed
>> the stacked mdraid on top stops functioning.
>>
>> I still think we can fix that by changing the semantics of implicit
>> queue_if_no_path and restore it as an explicit opt-in.
>
> So at very least we need to make sure we have the opt-in available before
> changing the defaults.
>
But what _is_ the default?
PCI and fabrics have different defaults; for PCI the device goes away if
the last path (ie the controller) goes away, for fabrics it doesn't if
the device is mounted.
Do we want to keep the difference in behaviour?
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-05-06 16:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 12:04 [PATCHv3] nvme-mpath: delete disk after last connection Hannes Reinecke
2021-05-04 8:54 ` Christoph Hellwig
2021-05-04 13:40 ` Hannes Reinecke
2021-05-04 19:54 ` Sagi Grimberg
2021-05-05 15:26 ` Keith Busch
2021-05-05 16:15 ` Hannes Reinecke
2021-05-05 20:40 ` Sagi Grimberg
2021-05-06 2:50 ` Keith Busch
2021-05-06 6:13 ` Hannes Reinecke
2021-05-06 7:43 ` Christoph Hellwig
2021-05-06 8:42 ` Hannes Reinecke
2021-05-06 9:47 ` Sagi Grimberg
2021-05-06 12:08 ` Christoph Hellwig
2021-05-06 15:54 ` Hannes Reinecke [this message]
2021-05-07 6:46 ` Christoph Hellwig
2021-05-07 17:02 ` Hannes Reinecke
2021-05-07 17:20 ` Sagi Grimberg
2021-05-10 6:23 ` Christoph Hellwig
2021-05-10 13:01 ` Hannes Reinecke
2021-05-10 13:57 ` Hannes Reinecke
2021-05-10 14:48 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cd891d9-6aa0-fd98-cbc5-1df2eabbe31d@suse.de \
--to=hare@suse.de \
--cc=daniel.wagner@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox