From: Sagi Grimberg <sagi@grimberg.me>
To: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
Daniel Wagner <daniel.wagner@suse.de>
Subject: Re: [PATCHv3] nvme-mpath: delete disk after last connection
Date: Fri, 7 May 2021 10:20:17 -0700 [thread overview]
Message-ID: <da9afc01-756b-2e09-b669-2f41cb85a177@grimberg.me> (raw)
In-Reply-To: <4fd33328-9060-6e95-dd26-ab013e44c07a@suse.de>
>>> PCI and fabrics have different defaults; for PCI the device goes away if
>>> the last path (ie the controller) goes away, for fabrics it doesn't
>>> if the
>>> device is mounted.
>>
>> Err, no. For fabrics we reconnect a while, but otherwise the behavior
>> is the same right now.
>>
> No, that is not the case.
>
> When a PCI nvme device with CMIC=0 is removed (via pci hotplug, say),
> the nvme device is completely removed, irrespective on whether it's
> mounted or not.
> When the _same_ PCI device with CMIC=1 is removed, the nvme device (ie
> the nsnhead) will _stay_ when mounted (as the refcount is not zero).
>
> This can be easily demonstrated on qemu; just set the 'subsys' parameter
> for the nvme device.
Perhaps we need to fix the issue and allow the existing behavior by
having an explicit queue_if_no_path argument.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-05-07 17:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 12:04 [PATCHv3] nvme-mpath: delete disk after last connection Hannes Reinecke
2021-05-04 8:54 ` Christoph Hellwig
2021-05-04 13:40 ` Hannes Reinecke
2021-05-04 19:54 ` Sagi Grimberg
2021-05-05 15:26 ` Keith Busch
2021-05-05 16:15 ` Hannes Reinecke
2021-05-05 20:40 ` Sagi Grimberg
2021-05-06 2:50 ` Keith Busch
2021-05-06 6:13 ` Hannes Reinecke
2021-05-06 7:43 ` Christoph Hellwig
2021-05-06 8:42 ` Hannes Reinecke
2021-05-06 9:47 ` Sagi Grimberg
2021-05-06 12:08 ` Christoph Hellwig
2021-05-06 15:54 ` Hannes Reinecke
2021-05-07 6:46 ` Christoph Hellwig
2021-05-07 17:02 ` Hannes Reinecke
2021-05-07 17:20 ` Sagi Grimberg [this message]
2021-05-10 6:23 ` Christoph Hellwig
2021-05-10 13:01 ` Hannes Reinecke
2021-05-10 13:57 ` Hannes Reinecke
2021-05-10 14:48 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da9afc01-756b-2e09-b669-2f41cb85a177@grimberg.me \
--to=sagi@grimberg.me \
--cc=daniel.wagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox