public inbox for linux-nvme@lists.infradead.org
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: James Smart <james.smart@broadcom.com>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
	Hannes Reinecke <hare@suse.de>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	Daniel Wagner <dwagner@suse.de>
Subject: [PATCH v5 09/12] nvmet-fc: abort command when there is no binding
Date: Wed, 31 Jan 2024 09:51:09 +0100	[thread overview]
Message-ID: <20240131085112.21668-10-dwagner@suse.de> (raw)
In-Reply-To: <20240131085112.21668-1-dwagner@suse.de>

When the target port has not active port binding, there is no point in
trying to process the command as it has to fail anyway. Instead adding
checks to all commands abort the command early.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
 drivers/nvme/target/fc.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index fe3246024836..c80b8a066fd1 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -1099,6 +1099,9 @@ nvmet_fc_alloc_target_assoc(struct nvmet_fc_tgtport *tgtport, void *hosthandle)
 	int idx;
 	bool needrandom = true;
 
+	if (!tgtport->pe)
+		return NULL;
+
 	assoc = kzalloc(sizeof(*assoc), GFP_KERNEL);
 	if (!assoc)
 		return NULL;
@@ -2514,8 +2517,9 @@ nvmet_fc_handle_fcp_rqst(struct nvmet_fc_tgtport *tgtport,
 
 	fod->req.cmd = &fod->cmdiubuf.sqe;
 	fod->req.cqe = &fod->rspiubuf.cqe;
-	if (tgtport->pe)
-		fod->req.port = tgtport->pe->port;
+	if (!tgtport->pe)
+		goto transport_error;
+	fod->req.port = tgtport->pe->port;
 
 	/* clear any response payload */
 	memset(&fod->rspiubuf, 0, sizeof(fod->rspiubuf));
-- 
2.43.0



  parent reply	other threads:[~2024-01-31 11:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31  8:51 [PATCH v5 00/12] enable nvmet-fc for blktests Daniel Wagner
2024-01-31  8:51 ` [PATCH v5 01/12] nvme-fc: do not wait in vain when unloading module Daniel Wagner
2024-02-01 12:41   ` Hannes Reinecke
2024-01-31  8:51 ` [PATCH v5 02/12] nvmet-fcloop: swap the list_add_tail arguments Daniel Wagner
2024-02-01 12:42   ` Hannes Reinecke
2024-01-31  8:51 ` [PATCH v5 03/12] nvmet-fc: release reference on target port Daniel Wagner
2024-01-31  8:51 ` [PATCH v5 04/12] nvmet-fc: defer cleanup using RCU properly Daniel Wagner
2024-02-01 12:43   ` Hannes Reinecke
2024-01-31  8:51 ` [PATCH v5 05/12] nvmet-fc: free queue and assoc directly Daniel Wagner
2024-01-31  8:51 ` [PATCH v5 06/12] nvmet-fc: hold reference on hostport match Daniel Wagner
2024-01-31  8:51 ` [PATCH v5 07/12] nvmet-fc: remove null hostport pointer check Daniel Wagner
2024-01-31  8:51 ` [PATCH v5 08/12] nvmet-fc: do not tack refs on tgtports from assoc Daniel Wagner
2024-01-31  8:51 ` Daniel Wagner [this message]
2024-01-31  8:51 ` [PATCH v5 10/12] nvmet-fc: avoid deadlock on delete association path Daniel Wagner
2024-02-06  3:03   ` Hannes Reinecke
2024-01-31  8:51 ` [PATCH v5 11/12] nvmet-fc: take ref count on tgtport before delete assoc Daniel Wagner
2024-02-06  5:47   ` Hannes Reinecke
2024-01-31  8:51 ` [PATCH v5 12/12] nvmet-fc: use RCU list iterator for assoc_list Daniel Wagner
2024-01-31 17:31   ` Christoph Hellwig
2024-02-06  5:51   ` Hannes Reinecke
2024-02-06 19:22     ` Keith Busch
2024-02-12 10:31       ` Daniel Wagner
2024-02-01  0:28 ` [PATCH v5 00/12] enable nvmet-fc for blktests Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240131085112.21668-10-dwagner@suse.de \
    --to=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.smart@broadcom.com \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox