From: Daniel Wagner <dwagner@suse.de>
To: James Smart <james.smart@broadcom.com>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Daniel Wagner <dwagner@suse.de>
Subject: [PATCH v5 05/12] nvmet-fc: free queue and assoc directly
Date: Wed, 31 Jan 2024 09:51:05 +0100 [thread overview]
Message-ID: <20240131085112.21668-6-dwagner@suse.de> (raw)
In-Reply-To: <20240131085112.21668-1-dwagner@suse.de>
Neither struct nvmet_fc_tgt_queue nor struct nvmet_fc_tgt_assoc are data
structure which are used in a RCU context. So there is no reason to
delay the free operation.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
drivers/nvme/target/fc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index 11ecfef41bd1..b44b99525c44 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -145,7 +145,6 @@ struct nvmet_fc_tgt_queue {
struct list_head avail_defer_list;
struct workqueue_struct *work_q;
struct kref ref;
- struct rcu_head rcu;
/* array of fcp_iods */
struct nvmet_fc_fcp_iod fod[] __counted_by(sqsize);
} __aligned(sizeof(unsigned long long));
@@ -169,7 +168,6 @@ struct nvmet_fc_tgt_assoc {
struct nvmet_fc_tgt_queue *queues[NVMET_NR_QUEUES + 1];
struct kref ref;
struct work_struct del_work;
- struct rcu_head rcu;
};
@@ -852,7 +850,7 @@ nvmet_fc_tgt_queue_free(struct kref *ref)
destroy_workqueue(queue->work_q);
- kfree_rcu(queue, rcu);
+ kfree(queue);
}
static void
@@ -1185,8 +1183,8 @@ nvmet_fc_target_assoc_free(struct kref *ref)
dev_info(tgtport->dev,
"{%d:%d} Association freed\n",
tgtport->fc_target_port.port_num, assoc->a_id);
- kfree_rcu(assoc, rcu);
nvmet_fc_tgtport_put(tgtport);
+ kfree(assoc);
}
static void
--
2.43.0
next prev parent reply other threads:[~2024-01-31 11:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 8:51 [PATCH v5 00/12] enable nvmet-fc for blktests Daniel Wagner
2024-01-31 8:51 ` [PATCH v5 01/12] nvme-fc: do not wait in vain when unloading module Daniel Wagner
2024-02-01 12:41 ` Hannes Reinecke
2024-01-31 8:51 ` [PATCH v5 02/12] nvmet-fcloop: swap the list_add_tail arguments Daniel Wagner
2024-02-01 12:42 ` Hannes Reinecke
2024-01-31 8:51 ` [PATCH v5 03/12] nvmet-fc: release reference on target port Daniel Wagner
2024-01-31 8:51 ` [PATCH v5 04/12] nvmet-fc: defer cleanup using RCU properly Daniel Wagner
2024-02-01 12:43 ` Hannes Reinecke
2024-01-31 8:51 ` Daniel Wagner [this message]
2024-01-31 8:51 ` [PATCH v5 06/12] nvmet-fc: hold reference on hostport match Daniel Wagner
2024-01-31 8:51 ` [PATCH v5 07/12] nvmet-fc: remove null hostport pointer check Daniel Wagner
2024-01-31 8:51 ` [PATCH v5 08/12] nvmet-fc: do not tack refs on tgtports from assoc Daniel Wagner
2024-01-31 8:51 ` [PATCH v5 09/12] nvmet-fc: abort command when there is no binding Daniel Wagner
2024-01-31 8:51 ` [PATCH v5 10/12] nvmet-fc: avoid deadlock on delete association path Daniel Wagner
2024-02-06 3:03 ` Hannes Reinecke
2024-01-31 8:51 ` [PATCH v5 11/12] nvmet-fc: take ref count on tgtport before delete assoc Daniel Wagner
2024-02-06 5:47 ` Hannes Reinecke
2024-01-31 8:51 ` [PATCH v5 12/12] nvmet-fc: use RCU list iterator for assoc_list Daniel Wagner
2024-01-31 17:31 ` Christoph Hellwig
2024-02-06 5:51 ` Hannes Reinecke
2024-02-06 19:22 ` Keith Busch
2024-02-12 10:31 ` Daniel Wagner
2024-02-01 0:28 ` [PATCH v5 00/12] enable nvmet-fc for blktests Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131085112.21668-6-dwagner@suse.de \
--to=dwagner@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox