From: Hannes Reinecke <hare@suse.de>
To: Daniel Wagner <dwagner@suse.de>, James Smart <james.smart@broadcom.com>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 10/12] nvmet-fc: avoid deadlock on delete association path
Date: Tue, 6 Feb 2024 12:03:59 +0900 [thread overview]
Message-ID: <68049531-3114-4afc-b6ba-e226b14b7806@suse.de> (raw)
In-Reply-To: <20240131085112.21668-11-dwagner@suse.de>
On 1/31/24 16:51, Daniel Wagner wrote:
> When deleting an association the shutdown path is deadlocking because we
> try to flush the nvmet_wq nested. Avoid this by deadlock by deferring
> the put work into its own work item.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> drivers/nvme/target/fc.c | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich
next prev parent reply other threads:[~2024-02-06 3:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 8:51 [PATCH v5 00/12] enable nvmet-fc for blktests Daniel Wagner
2024-01-31 8:51 ` [PATCH v5 01/12] nvme-fc: do not wait in vain when unloading module Daniel Wagner
2024-02-01 12:41 ` Hannes Reinecke
2024-01-31 8:51 ` [PATCH v5 02/12] nvmet-fcloop: swap the list_add_tail arguments Daniel Wagner
2024-02-01 12:42 ` Hannes Reinecke
2024-01-31 8:51 ` [PATCH v5 03/12] nvmet-fc: release reference on target port Daniel Wagner
2024-01-31 8:51 ` [PATCH v5 04/12] nvmet-fc: defer cleanup using RCU properly Daniel Wagner
2024-02-01 12:43 ` Hannes Reinecke
2024-01-31 8:51 ` [PATCH v5 05/12] nvmet-fc: free queue and assoc directly Daniel Wagner
2024-01-31 8:51 ` [PATCH v5 06/12] nvmet-fc: hold reference on hostport match Daniel Wagner
2024-01-31 8:51 ` [PATCH v5 07/12] nvmet-fc: remove null hostport pointer check Daniel Wagner
2024-01-31 8:51 ` [PATCH v5 08/12] nvmet-fc: do not tack refs on tgtports from assoc Daniel Wagner
2024-01-31 8:51 ` [PATCH v5 09/12] nvmet-fc: abort command when there is no binding Daniel Wagner
2024-01-31 8:51 ` [PATCH v5 10/12] nvmet-fc: avoid deadlock on delete association path Daniel Wagner
2024-02-06 3:03 ` Hannes Reinecke [this message]
2024-01-31 8:51 ` [PATCH v5 11/12] nvmet-fc: take ref count on tgtport before delete assoc Daniel Wagner
2024-02-06 5:47 ` Hannes Reinecke
2024-01-31 8:51 ` [PATCH v5 12/12] nvmet-fc: use RCU list iterator for assoc_list Daniel Wagner
2024-01-31 17:31 ` Christoph Hellwig
2024-02-06 5:51 ` Hannes Reinecke
2024-02-06 19:22 ` Keith Busch
2024-02-12 10:31 ` Daniel Wagner
2024-02-01 0:28 ` [PATCH v5 00/12] enable nvmet-fc for blktests Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68049531-3114-4afc-b6ba-e226b14b7806@suse.de \
--to=hare@suse.de \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox