* [PATCH] nvme-core: fix comment to reflect right functions
@ 2024-02-06 0:30 Chaitanya Kulkarni
2024-02-06 0:37 ` alan.adamson
2024-02-07 18:40 ` Keith Busch
0 siblings, 2 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2024-02-06 0:30 UTC (permalink / raw)
To: alan.adamson; +Cc: kbusch, hch, sagi, linux-nvme, Chaitanya Kulkarni
The functions and the attribute listed in the comment doesn't exists in
the code, (ns->logging_enabled, nvme_passthru_err_log_enabled_store()
and nvme_passthru_err_log_enabled_show())
Update the comment with right function names and a comment
ns->passthru_err_log_enabled, nvme_io_passthru_err_log_enabled_store()
and nvme_io_passthru_err_log_enabled_show().
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
drivers/nvme/host/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 975245527c1f..7db700b2ed00 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3762,8 +3762,8 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, struct nvme_ns_info *info)
/*
* Set ns->disk->device->driver_data to ns so we can access
- * ns->logging_enabled in nvme_passthru_err_log_enabled_store() and
- * nvme_passthru_err_log_enabled_show().
+ * ns->passthru_err_log_enabled in
+ * nvme_io_passthru_err_log_enabled_[store | show]().
*/
dev_set_drvdata(disk_to_dev(ns->disk), ns);
--
2.40.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-core: fix comment to reflect right functions
2024-02-06 0:30 [PATCH] nvme-core: fix comment to reflect right functions Chaitanya Kulkarni
@ 2024-02-06 0:37 ` alan.adamson
2024-02-07 18:40 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: alan.adamson @ 2024-02-06 0:37 UTC (permalink / raw)
To: Chaitanya Kulkarni; +Cc: kbusch, hch, sagi, linux-nvme
Reviewed-by: Alan Adamson <alan.adamson@oracle.com>
On 2/5/24 4:30 PM, Chaitanya Kulkarni wrote:
> The functions and the attribute listed in the comment doesn't exists in
> the code, (ns->logging_enabled, nvme_passthru_err_log_enabled_store()
> and nvme_passthru_err_log_enabled_show())
>
> Update the comment with right function names and a comment
> ns->passthru_err_log_enabled, nvme_io_passthru_err_log_enabled_store()
> and nvme_io_passthru_err_log_enabled_show().
>
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
> ---
> drivers/nvme/host/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 975245527c1f..7db700b2ed00 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -3762,8 +3762,8 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, struct nvme_ns_info *info)
>
> /*
> * Set ns->disk->device->driver_data to ns so we can access
> - * ns->logging_enabled in nvme_passthru_err_log_enabled_store() and
> - * nvme_passthru_err_log_enabled_show().
> + * ns->passthru_err_log_enabled in
> + * nvme_io_passthru_err_log_enabled_[store | show]().
> */
> dev_set_drvdata(disk_to_dev(ns->disk), ns);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-core: fix comment to reflect right functions
2024-02-06 0:30 [PATCH] nvme-core: fix comment to reflect right functions Chaitanya Kulkarni
2024-02-06 0:37 ` alan.adamson
@ 2024-02-07 18:40 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2024-02-07 18:40 UTC (permalink / raw)
To: Chaitanya Kulkarni; +Cc: alan.adamson, hch, sagi, linux-nvme
On Mon, Feb 05, 2024 at 04:30:21PM -0800, Chaitanya Kulkarni wrote:
> /*
> * Set ns->disk->device->driver_data to ns so we can access
> - * ns->logging_enabled in nvme_passthru_err_log_enabled_store() and
> - * nvme_passthru_err_log_enabled_show().
> + * ns->passthru_err_log_enabled in
Thanks, applied to nvme-6.8 with updated comment "ns->head->..."
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-07 18:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-06 0:30 [PATCH] nvme-core: fix comment to reflect right functions Chaitanya Kulkarni
2024-02-06 0:37 ` alan.adamson
2024-02-07 18:40 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox