* [PATCH] nvme-rdma, nvme-tcp: include max reconnects for failed reconnect logging
@ 2024-05-05 12:03 Tokunori Ikegami
2024-05-05 13:46 ` Sagi Grimberg
0 siblings, 1 reply; 3+ messages in thread
From: Tokunori Ikegami @ 2024-05-05 12:03 UTC (permalink / raw)
To: linux-nvme; +Cc: Tokunori Ikegami
Makes clear max reconnects translated by ctrl loss tmo and reconnect delay.
Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
---
drivers/nvme/host/rdma.c | 4 ++--
drivers/nvme/host/tcp.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 366f0bb4ebfc..fc33f16f9f0e 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -1118,8 +1118,8 @@ static void nvme_rdma_reconnect_ctrl_work(struct work_struct *work)
return;
requeue:
- dev_info(ctrl->ctrl.device, "Failed reconnect attempt %d\n",
- ctrl->ctrl.nr_reconnects);
+ dev_info(ctrl->ctrl.device, "Failed reconnect attempt %d of %d\n",
+ ctrl->ctrl.nr_reconnects, ctrl->ctrl.opts->max_reconnects);
nvme_rdma_reconnect_or_remove(ctrl);
}
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index 28bc2f373cfa..4c4c363d2025 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -2272,8 +2272,8 @@ static void nvme_tcp_reconnect_ctrl_work(struct work_struct *work)
return;
requeue:
- dev_info(ctrl->device, "Failed reconnect attempt %d\n",
- ctrl->nr_reconnects);
+ dev_info(ctrl->device, "Failed reconnect attempt %d of %d\n",
+ ctrl->nr_reconnects, ctrl->opts->max_reconnects);
nvme_tcp_reconnect_or_remove(ctrl);
}
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-rdma, nvme-tcp: include max reconnects for failed reconnect logging
2024-05-05 12:03 [PATCH] nvme-rdma, nvme-tcp: include max reconnects for failed reconnect logging Tokunori Ikegami
@ 2024-05-05 13:46 ` Sagi Grimberg
2024-05-05 15:27 ` Tokunori Ikegami
0 siblings, 1 reply; 3+ messages in thread
From: Sagi Grimberg @ 2024-05-05 13:46 UTC (permalink / raw)
To: Tokunori Ikegami, linux-nvme
> requeue:
> - dev_info(ctrl->ctrl.device, "Failed reconnect attempt %d\n",
> - ctrl->ctrl.nr_reconnects);
> + dev_info(ctrl->ctrl.device, "Failed reconnect attempt %d of %d\n",
> + ctrl->ctrl.nr_reconnects, ctrl->ctrl.opts->max_reconnects);
How about we do:
"Failed reconnect attempt %d/%d\n"
And the same for the successful reconnect:
"Successfully reconnected (attempt %d/%d)\n"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme-rdma, nvme-tcp: include max reconnects for failed reconnect logging
2024-05-05 13:46 ` Sagi Grimberg
@ 2024-05-05 15:27 ` Tokunori Ikegami
0 siblings, 0 replies; 3+ messages in thread
From: Tokunori Ikegami @ 2024-05-05 15:27 UTC (permalink / raw)
To: Sagi Grimberg, linux-nvme
On 2024/05/05 22:46, Sagi Grimberg wrote:
>> requeue:
>> - dev_info(ctrl->ctrl.device, "Failed reconnect attempt %d\n",
>> - ctrl->ctrl.nr_reconnects);
>> + dev_info(ctrl->ctrl.device, "Failed reconnect attempt %d of %d\n",
>> + ctrl->ctrl.nr_reconnects, ctrl->ctrl.opts->max_reconnects);
>
> How about we do:
> "Failed reconnect attempt %d/%d\n"
>
> And the same for the successful reconnect:
> "Successfully reconnected (attempt %d/%d)\n"
Thanks for your suggestion. Looks good so just sent the version 2 patch
as mentioned.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-05 15:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-05 12:03 [PATCH] nvme-rdma, nvme-tcp: include max reconnects for failed reconnect logging Tokunori Ikegami
2024-05-05 13:46 ` Sagi Grimberg
2024-05-05 15:27 ` Tokunori Ikegami
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox