[PATCH 0/1] nvme-pci: add IGNORE_DEV_SUBNQN quirk for device 1987:5012

[PATCH 0/1] nvme-pci: add IGNORE_DEV_SUBNQN quirk for device 1987:5012

[Jason Nader]

Hi,

The existing quirk for this device was missing IGNORE_DEV_SUBNQN,
however on my system it looks like the quirk should be applied.

Kernel logs before this patch:

nvme nvme0: pci function 0000:02:00.0
nvme nvme0: missing or invalid SUBNQN field.
nvme nvme0: D3 entry latency set to 10 seconds
nvme nvme0: 8/0/0 default/read/poll queues
nvme nvme0: Ignoring bogus Namespace Identifiers

Kernel logs after this patch:

nvme nvme0: pci function 0000:02:00.0
nvme nvme0: D3 entry latency set to 10 seconds
nvme nvme0: 8/0/0 default/read/poll queues
nvme nvme0: Ignoring bogus Namespace Identifiers

Jason Nader (1):
  nvme-pci: add IGNORE_DEV_SUBNQN quirk for device 1987:5012

 drivers/nvme/host/pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.45.1

[PATCH 1/1] nvme-pci: add IGNORE_DEV_SUBNQN quirk for device 1987:5012

[Jason Nader]

The NVME drive 'Corsair Force MP510' which shows in `lspci -nn` as
Phison Electronics Corporation E12 NVMe Controller [1987:5012] (rev 01),
shows the following warning in dmesg:

nvme nvme0: missing or invalid SUBNQN field.

To fix this, add NVME_QUIRK_IGNORE_DEV_SUBNQN for this device.

Signed-off-by: Jason Nader <dev@kayoway.com>
---
 drivers/nvme/host/pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 710043086dff..fd9982a7e3c6 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3399,7 +3399,8 @@ static const struct pci_device_id nvme_id_table[] = {
 	{ PCI_DEVICE(0x15b7, 0x5008),   /* Sandisk SN530 */
 		.driver_data = NVME_QUIRK_BROKEN_MSI },
 	{ PCI_DEVICE(0x1987, 0x5012),	/* Phison E12 */
-		.driver_data = NVME_QUIRK_BOGUS_NID, },
+		.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
+				NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x1987, 0x5016),	/* Phison E16 */
 		.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
 				NVME_QUIRK_BOGUS_NID, },
-- 
2.45.1