[PATCH 0/1] nvme-pci: add quirks for Lexar NM790

[PATCH 0/1] nvme-pci: add quirks for Lexar NM790

[Jason Nader]

Hi,

This adds Lexar NM790 to the quirks list.
Other drives in the model line-up already exist in the list.

Kernel logs before:

nvme nvme1: pci function 0000:03:00.0
nvme nvme1: missing or invalid SUBNQN field.
nvme nvme1: allocated 32 MiB host memory buffer.
nvme nvme1: 8/0/0 default/read/poll queues
block nvme1n1: No UUID available providing old NGUID

Kernel logs after:

nvme nvme1: pci function 0000:03:00.0
nvme nvme1: allocated 32 MiB host memory buffer.
nvme nvme1: 8/0/0 default/read/poll queues
nvme nvme1: Ignoring bogus Namespace Identifiers

Other info:

>sudo nvme ns-descs /dev/nvme1n1    
NVME Namespace Identification Descriptors NS 1:
eui64   : 6479a74b40200c00
nguid   : 00000000000000000000000000000000

Jason Nader (1):
  nvme-pci: add quirks for Lexar NM790

 drivers/nvme/host/pci.c | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.45.1

[PATCH 1/1] nvme-pci: add quirks for Lexar NM790

[Jason Nader]

NVME device 'Lexar SSD NM790 2TB', which shows in `lspci -nn` as
Shenzhen Longsys Electronics Co., Ltd. Lexar NM790 NVME SSD (DRAM-less) [1d97:1602] (rev 01),
shows the following warnings in dmesg:

nvme nvme1: missing or invalid SUBNQN field.
block nvme1n1: No UUID available providing old NGUID

To fix this, add IGNORE_DEV_SUBNQN and BOGUS_NID quirks for this device.

Signed-off-by: Jason Nader <dev@kayoway.com>
---
 drivers/nvme/host/pci.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 710043086dff..8ca831cb2f79 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3490,6 +3490,9 @@ static const struct pci_device_id nvme_id_table[] = {
 	{ PCI_DEVICE(0x1d97, 0x2269), /* Lexar NM760 */
 		.driver_data = NVME_QUIRK_BOGUS_NID |
 				NVME_QUIRK_IGNORE_DEV_SUBNQN, },
+	{ PCI_DEVICE(0x1d97, 0x1602), /* Lexar NM790 */
+		.driver_data = NVME_QUIRK_BOGUS_NID |
+				NVME_QUIRK_IGNORE_DEV_SUBNQN, },
 	{ PCI_DEVICE(0x10ec, 0x5763), /* TEAMGROUP T-FORCE CARDEA ZERO Z330 SSD */
 		.driver_data = NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x1e4b, 0x1602), /* HS-SSD-FUTURE 2048G  */
-- 
2.45.1

Re: [PATCH 0/1] nvme-pci: add quirks for Lexar NM790

[Keith Busch]

On Thu, May 23, 2024 at 12:56:13AM +0900, Jason Nader wrote:
> Hi,
> 
> This adds Lexar NM790 to the quirks list.
> Other drives in the model line-up already exist in the list.
> 
> Kernel logs before:
> 
> nvme nvme1: pci function 0000:03:00.0
> nvme nvme1: missing or invalid SUBNQN field.
> nvme nvme1: allocated 32 MiB host memory buffer.
> nvme nvme1: 8/0/0 default/read/poll queues
> block nvme1n1: No UUID available providing old NGUID
> 
> Kernel logs after:
> 
> nvme nvme1: pci function 0000:03:00.0
> nvme nvme1: allocated 32 MiB host memory buffer.
> nvme nvme1: 8/0/0 default/read/poll queues
> nvme nvme1: Ignoring bogus Namespace Identifiers
> 
> Other info:
> 
> >sudo nvme ns-descs /dev/nvme1n1    
> NVME Namespace Identification Descriptors NS 1:
> eui64   : 6479a74b40200c00
> nguid   : 00000000000000000000000000000000

This quirk is actually for the nvme subsystem. It has nothing to do with
namespace descriptors.

  nvme id-ctrl /dev/nvme1 | grep subnqn

I'm not even sure why we have this quirk; it just suppresses a harmless
print message; everything works the same with or without the quirk.

Re: [PATCH 0/1] nvme-pci: add quirks for Lexar NM790

[Jason Nader]

On Thu, 23 May 2024 at 02:42, Keith Busch <kbusch@kernel.org> wrote:
>
> On Thu, May 23, 2024 at 12:56:13AM +0900, Jason Nader wrote:
> namespace descriptors.
>
>   nvme id-ctrl /dev/nvme1 | grep subnqn

Output below:
```
subnqn    :
```