* [PATCH] nvme: use better description for async reset reason
@ 2024-08-22 15:22 Keith Busch
2024-08-23 6:27 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Keith Busch @ 2024-08-22 15:22 UTC (permalink / raw)
To: linux-nvme, hch, sagi; +Cc: Keith Busch
From: Keith Busch <kbusch@kernel.org>
The NVMe AER notification of a persistent internal error triggers a
reset. The existing warning message just says "due to AER", which can be
confused with the unlreated PCIe AER condition. Just say what the event
was instead of the generic overloaded acronym.
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
drivers/nvme/host/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 33fa01c599add..8ef64cb2c26a9 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -4437,7 +4437,8 @@ static bool nvme_handle_aen_notice(struct nvme_ctrl *ctrl, u32 result)
static void nvme_handle_aer_persistent_error(struct nvme_ctrl *ctrl)
{
- dev_warn(ctrl->device, "resetting controller due to AER\n");
+ dev_warn(ctrl->device,
+ "resetting controller due to persistent internal error\n");
nvme_reset_ctrl(ctrl);
}
--
2.43.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] nvme: use better description for async reset reason
2024-08-22 15:22 [PATCH] nvme: use better description for async reset reason Keith Busch
@ 2024-08-23 6:27 ` Christoph Hellwig
2024-08-23 6:38 ` Chaitanya Kulkarni
2024-08-25 9:04 ` Sagi Grimberg
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2024-08-23 6:27 UTC (permalink / raw)
To: Keith Busch; +Cc: linux-nvme, hch, sagi, Keith Busch
On Thu, Aug 22, 2024 at 08:22:59AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> The NVMe AER notification of a persistent internal error triggers a
> reset. The existing warning message just says "due to AER", which can be
> confused with the unlreated PCIe AER condition. Just say what the event
> was instead of the generic overloaded acronym.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: use better description for async reset reason
2024-08-22 15:22 [PATCH] nvme: use better description for async reset reason Keith Busch
2024-08-23 6:27 ` Christoph Hellwig
@ 2024-08-23 6:38 ` Chaitanya Kulkarni
2024-08-25 9:04 ` Sagi Grimberg
2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2024-08-23 6:38 UTC (permalink / raw)
To: Keith Busch, linux-nvme@lists.infradead.org, hch@lst.de,
sagi@grimberg.me
Cc: Keith Busch
On 8/22/24 08:22, Keith Busch wrote:
> From: Keith Busch<kbusch@kernel.org>
>
> The NVMe AER notification of a persistent internal error triggers a
> reset. The existing warning message just says "due to AER", which can be
> confused with the unlreated PCIe AER condition. Just say what the event
> was instead of the generic overloaded acronym.
>
> Signed-off-by: Keith Busch<kbusch@kernel.org>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme: use better description for async reset reason
2024-08-22 15:22 [PATCH] nvme: use better description for async reset reason Keith Busch
2024-08-23 6:27 ` Christoph Hellwig
2024-08-23 6:38 ` Chaitanya Kulkarni
@ 2024-08-25 9:04 ` Sagi Grimberg
2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2024-08-25 9:04 UTC (permalink / raw)
To: Keith Busch, linux-nvme, hch; +Cc: Keith Busch
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-25 9:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-22 15:22 [PATCH] nvme: use better description for async reset reason Keith Busch
2024-08-23 6:27 ` Christoph Hellwig
2024-08-23 6:38 ` Chaitanya Kulkarni
2024-08-25 9:04 ` Sagi Grimberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox