[PATCH] nvme: use better description for async reset reason

[PATCH] nvme: use better description for async reset reason

[Keith Busch]

From: Keith Busch <kbusch@kernel.org>

The NVMe AER notification of a persistent internal error triggers a
reset. The existing warning message just says "due to AER", which can be
confused with the unlreated PCIe AER condition. Just say what the event
was instead of the generic overloaded acronym.

Signed-off-by: Keith Busch <kbusch@kernel.org>
---
 drivers/nvme/host/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 33fa01c599add..8ef64cb2c26a9 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -4437,7 +4437,8 @@ static bool nvme_handle_aen_notice(struct nvme_ctrl *ctrl, u32 result)
 
 static void nvme_handle_aer_persistent_error(struct nvme_ctrl *ctrl)
 {
-	dev_warn(ctrl->device, "resetting controller due to AER\n");
+	dev_warn(ctrl->device,
+		"resetting controller due to persistent internal error\n");
 	nvme_reset_ctrl(ctrl);
 }
 
-- 
2.43.5

Re: [PATCH] nvme: use better description for async reset reason

[Christoph Hellwig]

On Thu, Aug 22, 2024 at 08:22:59AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
> 
> The NVMe AER notification of a persistent internal error triggers a
> reset. The existing warning message just says "due to AER", which can be
> confused with the unlreated PCIe AER condition. Just say what the event
> was instead of the generic overloaded acronym.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [PATCH] nvme: use better description for async reset reason

[Chaitanya Kulkarni]

On 8/22/24 08:22, Keith Busch wrote:
> From: Keith Busch<kbusch@kernel.org>
>
> The NVMe AER notification of a persistent internal error triggers a
> reset. The existing warning message just says "due to AER", which can be
> confused with the unlreated PCIe AER condition. Just say what the event
> was instead of the generic overloaded acronym.
>
> Signed-off-by: Keith Busch<kbusch@kernel.org>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck

Re: [PATCH] nvme: use better description for async reset reason

[Sagi Grimberg]

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>