From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH] nvme-loop: set blocking flag
Date: Fri, 18 Oct 2024 07:10:56 +0200 [thread overview]
Message-ID: <20241018051056.GC19831@lst.de> (raw)
In-Reply-To: <ZxFRpdU-GI76uetA@kbusch-mbp.dhcp.thefacebook.com>
On Thu, Oct 17, 2024 at 12:04:21PM -0600, Keith Busch wrote:
> > Looks fine to me, but might be worth looking at doing that a bit
> > differently so that the target loop driver can remain non-blocking
> > as it should be considerably more efficient.
>
> That's what I first looked at, but it's too hard. Maybe if we can make a
> lookup that doesn't rely on searching the configfs group, but it's
> definitely not this nice one-liner patch. :)
Searching configfs in the I/O path sounds like a train wreck no matter
what. I feel a bit bad for not noticing that earlier.
Let me see what I can do.
next prev parent reply other threads:[~2024-10-18 5:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 17:20 [PATCH] nvme-loop: set blocking flag Keith Busch
2024-10-17 17:36 ` Bart Van Assche
2024-10-17 17:39 ` Jens Axboe
2024-10-17 18:04 ` Keith Busch
2024-10-18 5:10 ` Christoph Hellwig [this message]
2024-10-20 21:35 ` Sagi Grimberg
2024-10-22 6:28 ` Christoph Hellwig
2024-10-22 7:02 ` Christoph Hellwig
2024-10-22 8:08 ` Shinichiro Kawasaki
2024-10-23 5:20 ` hch
2024-10-22 9:26 ` Sagi Grimberg
2024-10-22 9:25 ` Sagi Grimberg
2024-10-18 5:10 ` Christoph Hellwig
2024-10-18 4:19 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241018051056.GC19831@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox