From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@kernel.dk>, Keith Busch <kbusch@meta.com>,
linux-nvme@lists.infradead.org,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH] nvme-loop: set blocking flag
Date: Tue, 22 Oct 2024 09:02:52 +0200 [thread overview]
Message-ID: <20241022070252.GA11389@lst.de> (raw)
In-Reply-To: <20241022062810.GC10573@lst.de>
On Tue, Oct 22, 2024 at 08:28:10AM +0200, Christoph Hellwig wrote:
> On Mon, Oct 21, 2024 at 12:35:17AM +0300, Sagi Grimberg wrote:
> >> Let me see what I can do.
> >
> > Note, the search is ONLY in the error case, i.e. when nsid is not found in
> > subsys->namespaces.
>
> Which kinda makes it worse as we use an unusual context just from
> that rare error path.
I just took a very quick look, and inserting the namespace into the
xarray when created and only removing it when it is deleted, and
instead checking an enabled flag during lookup should do the work.
Do we have a good test case for commit 505363957fad ?
>
---end quoted text---
next prev parent reply other threads:[~2024-10-22 7:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 17:20 [PATCH] nvme-loop: set blocking flag Keith Busch
2024-10-17 17:36 ` Bart Van Assche
2024-10-17 17:39 ` Jens Axboe
2024-10-17 18:04 ` Keith Busch
2024-10-18 5:10 ` Christoph Hellwig
2024-10-20 21:35 ` Sagi Grimberg
2024-10-22 6:28 ` Christoph Hellwig
2024-10-22 7:02 ` Christoph Hellwig [this message]
2024-10-22 8:08 ` Shinichiro Kawasaki
2024-10-23 5:20 ` hch
2024-10-22 9:26 ` Sagi Grimberg
2024-10-22 9:25 ` Sagi Grimberg
2024-10-18 5:10 ` Christoph Hellwig
2024-10-18 4:19 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022070252.GA11389@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox