From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@meta.com>, linux-nvme@lists.infradead.org
Cc: sagi@grimberg.me, hch@lst.de, Keith Busch <kbusch@kernel.org>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH] nvme-loop: set blocking flag
Date: Thu, 17 Oct 2024 11:39:24 -0600 [thread overview]
Message-ID: <7846e57b-fb03-42ed-af8e-0df88cc566a4@kernel.dk> (raw)
In-Reply-To: <20241017172052.2603389-1-kbusch@meta.com>
On 10/17/24 11:20 AM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Commit 505363957fad ("nvmet: fix nvme status code when namespace is
> disabled") introduced a mutex lock in the io path for target. The loop
> target connects this to the blk-mq submission side, so it requires the
> blocking flag set so that queue_rq doesn't happen inside an rcu context.
Looks fine to me, but might be worth looking at doing that a bit
differently so that the target loop driver can remain non-blocking
as it should be considerably more efficient.
--
Jens Axboe
next prev parent reply other threads:[~2024-10-17 17:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 17:20 [PATCH] nvme-loop: set blocking flag Keith Busch
2024-10-17 17:36 ` Bart Van Assche
2024-10-17 17:39 ` Jens Axboe [this message]
2024-10-17 18:04 ` Keith Busch
2024-10-18 5:10 ` Christoph Hellwig
2024-10-20 21:35 ` Sagi Grimberg
2024-10-22 6:28 ` Christoph Hellwig
2024-10-22 7:02 ` Christoph Hellwig
2024-10-22 8:08 ` Shinichiro Kawasaki
2024-10-23 5:20 ` hch
2024-10-22 9:26 ` Sagi Grimberg
2024-10-22 9:25 ` Sagi Grimberg
2024-10-18 5:10 ` Christoph Hellwig
2024-10-18 4:19 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7846e57b-fb03-42ed-af8e-0df88cc566a4@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox