* [PATCHv3 1/9] libnvme: annotate libnvme_path::ana_state with !accessors:none
2026-04-21 14:50 [PATCHv3 0/9] libnvme: add support for retrieving additional NVMe stat Nilay Shroff
@ 2026-04-21 14:50 ` Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 2/9] libnvme: annotate libnvme_path::numa_nodes " Nilay Shroff
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Nilay Shroff @ 2026-04-21 14:50 UTC (permalink / raw)
To: linux-nvme; +Cc: dwagner, hare, kbusch, hch, gjoyce, wenxiong, Nilay Shroff
The default accessor generation creates getters that return cached
attribute values. However, for libnvme_path::ana_state, a real-time
(non-cached) value is required.
This is particularly useful for tools such as nvme-top, which rely on
up-to-date information for displaying a real-time dashboard.
Annotate libnvme_path::ana_state with "!accessors:none" to disable the
auto-generated accessor, and provide a custom implementation of
libnvme_path_get_ana_state() that returns the current value.
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
---
libnvme/src/accessors.ld | 2 --
libnvme/src/libnvme.ld | 1 +
libnvme/src/nvme/accessors.c | 13 -------------
libnvme/src/nvme/accessors.h | 15 ---------------
libnvme/src/nvme/private.h | 2 +-
libnvme/src/nvme/tree.c | 15 +++++++++++++++
libnvme/src/nvme/tree.h | 8 ++++++++
7 files changed, 25 insertions(+), 31 deletions(-)
diff --git a/libnvme/src/accessors.ld b/libnvme/src/accessors.ld
index 7d0057218..73b238ee9 100644
--- a/libnvme/src/accessors.ld
+++ b/libnvme/src/accessors.ld
@@ -166,12 +166,10 @@ LIBNVME_ACCESSORS_3 {
libnvme_ns_set_name;
libnvme_ns_set_nsid;
libnvme_ns_set_sysfs_dir;
- libnvme_path_get_ana_state;
libnvme_path_get_grpid;
libnvme_path_get_name;
libnvme_path_get_numa_nodes;
libnvme_path_get_sysfs_dir;
- libnvme_path_set_ana_state;
libnvme_path_set_grpid;
libnvme_path_set_name;
libnvme_path_set_numa_nodes;
diff --git a/libnvme/src/libnvme.ld b/libnvme/src/libnvme.ld
index 961ca78d3..19a7910cb 100644
--- a/libnvme/src/libnvme.ld
+++ b/libnvme/src/libnvme.ld
@@ -139,6 +139,7 @@ LIBNVME_3 {
libnvme_path_get_ctrl;
libnvme_path_get_ns;
libnvme_path_get_queue_depth;
+ libnvme_path_get_ana_state;
libnvme_random_uuid;
libnvme_read_config;
libnvme_read_hostid;
diff --git a/libnvme/src/nvme/accessors.c b/libnvme/src/nvme/accessors.c
index 026358379..675bb7d02 100644
--- a/libnvme/src/nvme/accessors.c
+++ b/libnvme/src/nvme/accessors.c
@@ -291,19 +291,6 @@ __public const char *libnvme_path_get_sysfs_dir(const struct libnvme_path *p)
return p->sysfs_dir;
}
-__public void libnvme_path_set_ana_state(
- struct libnvme_path *p,
- const char *ana_state)
-{
- free(p->ana_state);
- p->ana_state = ana_state ? strdup(ana_state) : NULL;
-}
-
-__public const char *libnvme_path_get_ana_state(const struct libnvme_path *p)
-{
- return p->ana_state;
-}
-
__public void libnvme_path_set_numa_nodes(
struct libnvme_path *p,
const char *numa_nodes)
diff --git a/libnvme/src/nvme/accessors.h b/libnvme/src/nvme/accessors.h
index ee89f8188..7ff0a274f 100644
--- a/libnvme/src/nvme/accessors.h
+++ b/libnvme/src/nvme/accessors.h
@@ -391,21 +391,6 @@ void libnvme_path_set_sysfs_dir(struct libnvme_path *p, const char *sysfs_dir);
*/
const char *libnvme_path_get_sysfs_dir(const struct libnvme_path *p);
-/**
- * libnvme_path_set_ana_state() - Set ana_state.
- * @p: The &struct libnvme_path instance to update.
- * @ana_state: New string; a copy is stored. Pass NULL to clear.
- */
-void libnvme_path_set_ana_state(struct libnvme_path *p, const char *ana_state);
-
-/**
- * libnvme_path_get_ana_state() - Get ana_state.
- * @p: The &struct libnvme_path instance to query.
- *
- * Return: The value of the ana_state field, or NULL if not set.
- */
-const char *libnvme_path_get_ana_state(const struct libnvme_path *p);
-
/**
* libnvme_path_set_numa_nodes() - Set numa_nodes.
* @p: The &struct libnvme_path instance to update.
diff --git a/libnvme/src/nvme/private.h b/libnvme/src/nvme/private.h
index 8f9e72382..9d25373ed 100644
--- a/libnvme/src/nvme/private.h
+++ b/libnvme/src/nvme/private.h
@@ -176,8 +176,8 @@ struct libnvme_path { // !generate-accessors
char *name;
char *sysfs_dir;
- char *ana_state;
char *numa_nodes;
+ char *ana_state; //!accessors:none
int grpid;
int queue_depth; // !accessors:none
};
diff --git a/libnvme/src/nvme/tree.c b/libnvme/src/nvme/tree.c
index b9d8cf39b..46e72ebc4 100644
--- a/libnvme/src/nvme/tree.c
+++ b/libnvme/src/nvme/tree.c
@@ -839,6 +839,21 @@ __public int libnvme_path_get_queue_depth(libnvme_path_t p)
return p->queue_depth;
}
+__public char *libnvme_path_get_ana_state(libnvme_path_t p)
+{
+ __cleanup_free char *ana_state = NULL;
+
+ ana_state = libnvme_get_path_attr(p, "ana_state");
+ if (ana_state) {
+ if (!p->ana_state || strcmp(ana_state, p->ana_state)) {
+ free(p->ana_state);
+ p->ana_state = strdup(ana_state);
+ }
+ }
+
+ return p->ana_state;
+}
+
void nvme_free_path(struct libnvme_path *p)
{
if (!p)
diff --git a/libnvme/src/nvme/tree.h b/libnvme/src/nvme/tree.h
index 403ad43d5..aa983b862 100644
--- a/libnvme/src/nvme/tree.h
+++ b/libnvme/src/nvme/tree.h
@@ -660,6 +660,14 @@ int libnvme_ns_identify_descs(libnvme_ns_t n, struct nvme_ns_id_desc *descs);
*/
int libnvme_path_get_queue_depth(libnvme_path_t p);
+/**
+ * libnvme_path_get_ana_state() - ANA state of an nvme_path_t object
+ * @p: &libnvme_path_t object
+ *
+ * Return: ANA state of @p
+ */
+char *libnvme_path_get_ana_state(libnvme_path_t p);
+
/**
* libnvme_path_get_ctrl() - Parent controller of an libnvme_path_t object
* @p: &libnvme_path_t object
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCHv3 2/9] libnvme: annotate libnvme_path::numa_nodes with !accessors:none
2026-04-21 14:50 [PATCHv3 0/9] libnvme: add support for retrieving additional NVMe stat Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 1/9] libnvme: annotate libnvme_path::ana_state with !accessors:none Nilay Shroff
@ 2026-04-21 14:50 ` Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 3/9] libnvme: annotate libnvme_subsystem::iopolicy " Nilay Shroff
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Nilay Shroff @ 2026-04-21 14:50 UTC (permalink / raw)
To: linux-nvme; +Cc: dwagner, hare, kbusch, hch, gjoyce, wenxiong, Nilay Shroff
The default accessor generation creates getters that return cached
attribute values. However, for libnvme_path::numa_nodes, a real-time
(non-cached) value is required.
This is particularly useful for tools such as nvme-top, which rely on
up-to-date information for displaying a real-time dashboard.
Annotate libnvme_path::numa_nodes with "!accessors:none" to disable the
auto-generated accessor, and provide a custom implementation of
libnvme_path_get_numa_nodes() that returns the current value.
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
---
libnvme/src/accessors.ld | 2 --
libnvme/src/libnvme.ld | 1 +
libnvme/src/nvme/accessors.c | 13 -------------
libnvme/src/nvme/accessors.h | 17 -----------------
libnvme/src/nvme/private.h | 2 +-
libnvme/src/nvme/tree.c | 15 +++++++++++++++
libnvme/src/nvme/tree.h | 8 ++++++++
7 files changed, 25 insertions(+), 33 deletions(-)
diff --git a/libnvme/src/accessors.ld b/libnvme/src/accessors.ld
index 73b238ee9..4ccba1a6e 100644
--- a/libnvme/src/accessors.ld
+++ b/libnvme/src/accessors.ld
@@ -168,11 +168,9 @@ LIBNVME_ACCESSORS_3 {
libnvme_ns_set_sysfs_dir;
libnvme_path_get_grpid;
libnvme_path_get_name;
- libnvme_path_get_numa_nodes;
libnvme_path_get_sysfs_dir;
libnvme_path_set_grpid;
libnvme_path_set_name;
- libnvme_path_set_numa_nodes;
libnvme_path_set_sysfs_dir;
libnvme_subsystem_get_application;
libnvme_subsystem_get_firmware;
diff --git a/libnvme/src/libnvme.ld b/libnvme/src/libnvme.ld
index 19a7910cb..9b26de5cd 100644
--- a/libnvme/src/libnvme.ld
+++ b/libnvme/src/libnvme.ld
@@ -140,6 +140,7 @@ LIBNVME_3 {
libnvme_path_get_ns;
libnvme_path_get_queue_depth;
libnvme_path_get_ana_state;
+ libnvme_path_get_numa_nodes;
libnvme_random_uuid;
libnvme_read_config;
libnvme_read_hostid;
diff --git a/libnvme/src/nvme/accessors.c b/libnvme/src/nvme/accessors.c
index 675bb7d02..bcae8d578 100644
--- a/libnvme/src/nvme/accessors.c
+++ b/libnvme/src/nvme/accessors.c
@@ -291,19 +291,6 @@ __public const char *libnvme_path_get_sysfs_dir(const struct libnvme_path *p)
return p->sysfs_dir;
}
-__public void libnvme_path_set_numa_nodes(
- struct libnvme_path *p,
- const char *numa_nodes)
-{
- free(p->numa_nodes);
- p->numa_nodes = numa_nodes ? strdup(numa_nodes) : NULL;
-}
-
-__public const char *libnvme_path_get_numa_nodes(const struct libnvme_path *p)
-{
- return p->numa_nodes;
-}
-
__public void libnvme_path_set_grpid(struct libnvme_path *p, int grpid)
{
p->grpid = grpid;
diff --git a/libnvme/src/nvme/accessors.h b/libnvme/src/nvme/accessors.h
index 7ff0a274f..7ade91794 100644
--- a/libnvme/src/nvme/accessors.h
+++ b/libnvme/src/nvme/accessors.h
@@ -391,23 +391,6 @@ void libnvme_path_set_sysfs_dir(struct libnvme_path *p, const char *sysfs_dir);
*/
const char *libnvme_path_get_sysfs_dir(const struct libnvme_path *p);
-/**
- * libnvme_path_set_numa_nodes() - Set numa_nodes.
- * @p: The &struct libnvme_path instance to update.
- * @numa_nodes: New string; a copy is stored. Pass NULL to clear.
- */
-void libnvme_path_set_numa_nodes(
- struct libnvme_path *p,
- const char *numa_nodes);
-
-/**
- * libnvme_path_get_numa_nodes() - Get numa_nodes.
- * @p: The &struct libnvme_path instance to query.
- *
- * Return: The value of the numa_nodes field, or NULL if not set.
- */
-const char *libnvme_path_get_numa_nodes(const struct libnvme_path *p);
-
/**
* libnvme_path_set_grpid() - Set grpid.
* @p: The &struct libnvme_path instance to update.
diff --git a/libnvme/src/nvme/private.h b/libnvme/src/nvme/private.h
index 9d25373ed..2471495ad 100644
--- a/libnvme/src/nvme/private.h
+++ b/libnvme/src/nvme/private.h
@@ -176,8 +176,8 @@ struct libnvme_path { // !generate-accessors
char *name;
char *sysfs_dir;
- char *numa_nodes;
char *ana_state; //!accessors:none
+ char *numa_nodes; //!accessors:none
int grpid;
int queue_depth; // !accessors:none
};
diff --git a/libnvme/src/nvme/tree.c b/libnvme/src/nvme/tree.c
index 46e72ebc4..c2c959871 100644
--- a/libnvme/src/nvme/tree.c
+++ b/libnvme/src/nvme/tree.c
@@ -854,6 +854,21 @@ __public char *libnvme_path_get_ana_state(libnvme_path_t p)
return p->ana_state;
}
+__public char *libnvme_path_get_numa_nodes(libnvme_path_t p)
+{
+ __cleanup_free char *numa_nodes = NULL;
+
+ numa_nodes = libnvme_get_path_attr(p, "numa_nodes");
+ if (numa_nodes) {
+ if (!p->numa_nodes || strcmp(numa_nodes, p->numa_nodes)) {
+ free(p->numa_nodes);
+ p->numa_nodes = strdup(numa_nodes);
+ }
+ }
+
+ return p->numa_nodes;
+}
+
void nvme_free_path(struct libnvme_path *p)
{
if (!p)
diff --git a/libnvme/src/nvme/tree.h b/libnvme/src/nvme/tree.h
index aa983b862..7cd90c620 100644
--- a/libnvme/src/nvme/tree.h
+++ b/libnvme/src/nvme/tree.h
@@ -668,6 +668,14 @@ int libnvme_path_get_queue_depth(libnvme_path_t p);
*/
char *libnvme_path_get_ana_state(libnvme_path_t p);
+/**
+ * libnvme_path_get_numa_nodes() - Numa nodes of an nvme_path_t object
+ * @p: &libnvme_path_t object
+ *
+ * Return: Numa nodes of @p
+ */
+char *libnvme_path_get_numa_nodes(libnvme_path_t p);
+
/**
* libnvme_path_get_ctrl() - Parent controller of an libnvme_path_t object
* @p: &libnvme_path_t object
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCHv3 3/9] libnvme: annotate libnvme_subsystem::iopolicy with !accessors:none
2026-04-21 14:50 [PATCHv3 0/9] libnvme: add support for retrieving additional NVMe stat Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 1/9] libnvme: annotate libnvme_path::ana_state with !accessors:none Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 2/9] libnvme: annotate libnvme_path::numa_nodes " Nilay Shroff
@ 2026-04-21 14:50 ` Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 4/9] libnvme: add support for retrieving per-path gendisk I/O statistics Nilay Shroff
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Nilay Shroff @ 2026-04-21 14:50 UTC (permalink / raw)
To: linux-nvme; +Cc: dwagner, hare, kbusch, hch, gjoyce, wenxiong, Nilay Shroff
The default accessor generation creates getters that return cached
attribute values. However, for libnvme_subsystem::iopolicy, a real-time
(non-cached) value is required.
This is particularly useful for tools such as nvme-top, which rely on
up-to-date information for displaying a real-time dashboard.
Annotate libnvme_subsystem::iopolicy with "!accessors:none" to disable the
auto-generated accessor, and provide a custom implementation of
libnvme_subsystem_get_iopolicy() that returns the current value.
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
---
libnvme/src/accessors.ld | 2 --
libnvme/src/libnvme.ld | 1 +
libnvme/src/nvme/accessors.c | 14 --------------
libnvme/src/nvme/accessors.h | 17 -----------------
libnvme/src/nvme/private.h | 2 +-
libnvme/src/nvme/tree.c | 15 +++++++++++++++
libnvme/src/nvme/tree.h | 8 ++++++++
7 files changed, 25 insertions(+), 34 deletions(-)
diff --git a/libnvme/src/accessors.ld b/libnvme/src/accessors.ld
index 4ccba1a6e..e23d9d7a2 100644
--- a/libnvme/src/accessors.ld
+++ b/libnvme/src/accessors.ld
@@ -174,7 +174,6 @@ LIBNVME_ACCESSORS_3 {
libnvme_path_set_sysfs_dir;
libnvme_subsystem_get_application;
libnvme_subsystem_get_firmware;
- libnvme_subsystem_get_iopolicy;
libnvme_subsystem_get_model;
libnvme_subsystem_get_name;
libnvme_subsystem_get_serial;
@@ -182,5 +181,4 @@ LIBNVME_ACCESSORS_3 {
libnvme_subsystem_get_subsystype;
libnvme_subsystem_get_sysfs_dir;
libnvme_subsystem_set_application;
- libnvme_subsystem_set_iopolicy;
};
diff --git a/libnvme/src/libnvme.ld b/libnvme/src/libnvme.ld
index 9b26de5cd..1ad02034a 100644
--- a/libnvme/src/libnvme.ld
+++ b/libnvme/src/libnvme.ld
@@ -177,6 +177,7 @@ LIBNVME_3 {
libnvme_subsystem_first_ctrl;
libnvme_subsystem_first_ns;
libnvme_subsystem_get_host;
+ libnvme_subsystem_get_iopolicy;
libnvme_subsystem_lookup_namespace;
libnvme_subsystem_next_ctrl;
libnvme_subsystem_next_ns;
diff --git a/libnvme/src/nvme/accessors.c b/libnvme/src/nvme/accessors.c
index bcae8d578..a2729014d 100644
--- a/libnvme/src/nvme/accessors.c
+++ b/libnvme/src/nvme/accessors.c
@@ -661,20 +661,6 @@ __public const char *libnvme_subsystem_get_application(
return p->application;
}
-__public void libnvme_subsystem_set_iopolicy(
- struct libnvme_subsystem *p,
- const char *iopolicy)
-{
- free(p->iopolicy);
- p->iopolicy = iopolicy ? strdup(iopolicy) : NULL;
-}
-
-__public const char *libnvme_subsystem_get_iopolicy(
- const struct libnvme_subsystem *p)
-{
- return p->iopolicy;
-}
-
/****************************************************************************
* Accessors for: struct libnvme_host
****************************************************************************/
diff --git a/libnvme/src/nvme/accessors.h b/libnvme/src/nvme/accessors.h
index 7ade91794..33484c723 100644
--- a/libnvme/src/nvme/accessors.h
+++ b/libnvme/src/nvme/accessors.h
@@ -901,23 +901,6 @@ void libnvme_subsystem_set_application(
const char *libnvme_subsystem_get_application(
const struct libnvme_subsystem *p);
-/**
- * libnvme_subsystem_set_iopolicy() - Set iopolicy.
- * @p: The &struct libnvme_subsystem instance to update.
- * @iopolicy: New string; a copy is stored. Pass NULL to clear.
- */
-void libnvme_subsystem_set_iopolicy(
- struct libnvme_subsystem *p,
- const char *iopolicy);
-
-/**
- * libnvme_subsystem_get_iopolicy() - Get iopolicy.
- * @p: The &struct libnvme_subsystem instance to query.
- *
- * Return: The value of the iopolicy field, or NULL if not set.
- */
-const char *libnvme_subsystem_get_iopolicy(const struct libnvme_subsystem *p);
-
/****************************************************************************
* Accessors for: struct libnvme_host
****************************************************************************/
diff --git a/libnvme/src/nvme/private.h b/libnvme/src/nvme/private.h
index 2471495ad..037cde7e2 100644
--- a/libnvme/src/nvme/private.h
+++ b/libnvme/src/nvme/private.h
@@ -269,7 +269,7 @@ struct libnvme_subsystem { // !generate-accessors
char *firmware; // !accessors:readonly
char *subsystype; // !accessors:readonly
char *application;
- char *iopolicy;
+ char *iopolicy; //!accessors:none
};
struct libnvme_host { // !generate-accessors
diff --git a/libnvme/src/nvme/tree.c b/libnvme/src/nvme/tree.c
index c2c959871..9e8c18da4 100644
--- a/libnvme/src/nvme/tree.c
+++ b/libnvme/src/nvme/tree.c
@@ -464,6 +464,21 @@ __public libnvme_host_t libnvme_subsystem_get_host(libnvme_subsystem_t s)
return s->h;
}
+__public char *libnvme_subsystem_get_iopolicy(libnvme_subsystem_t s)
+{
+ __cleanup_free char *iopolicy = NULL;
+
+ iopolicy = libnvme_get_subsys_attr(s, "iopolicy");
+ if (iopolicy) {
+ if (!s->iopolicy || strcmp(iopolicy, s->iopolicy)) {
+ free(s->iopolicy);
+ s->iopolicy = strdup(iopolicy);
+ }
+ }
+
+ return s->iopolicy;
+}
+
__public libnvme_ns_t libnvme_subsystem_first_ns(libnvme_subsystem_t s)
{
return list_top(&s->namespaces, struct libnvme_ns, entry);
diff --git a/libnvme/src/nvme/tree.h b/libnvme/src/nvme/tree.h
index 7cd90c620..93140fcb0 100644
--- a/libnvme/src/nvme/tree.h
+++ b/libnvme/src/nvme/tree.h
@@ -214,6 +214,14 @@ void libnvme_free_subsystem(struct libnvme_subsystem *s);
*/
libnvme_host_t libnvme_subsystem_get_host(libnvme_subsystem_t s);
+/**
+ * libnvme_subsystem_get_iopolicy() - Get subsystem iopolicy name
+ * @s: subsystem
+ *
+ * Return: The iopolicy configured in subsystem @s
+ */
+char *libnvme_subsystem_get_iopolicy(libnvme_subsystem_t s);
+
/**
* libnvme_ctrl_first_ns() - Start namespace iterator
* @c: Controller instance
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCHv3 4/9] libnvme: add support for retrieving per-path gendisk I/O statistics
2026-04-21 14:50 [PATCHv3 0/9] libnvme: add support for retrieving additional NVMe stat Nilay Shroff
` (2 preceding siblings ...)
2026-04-21 14:50 ` [PATCHv3 3/9] libnvme: annotate libnvme_subsystem::iopolicy " Nilay Shroff
@ 2026-04-21 14:50 ` Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 5/9] libnvme: add support for retrieving namespace " Nilay Shroff
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Nilay Shroff @ 2026-04-21 14:50 UTC (permalink / raw)
To: linux-nvme; +Cc: dwagner, hare, kbusch, hch, gjoyce, wenxiong, Nilay Shroff
Gendisk I/O statistics provide useful insight into disk activity,
including read/write/discard/flush operations, as well as information
about in-flight I/Os and I/O timing.
Parsing these statistics allows users to determine the number of I/Os
processed, time spent servicing I/O, number of sectors accessed, and
the count of in-flight requests.
Add support for retrieving per-path gendisk I/O statistics. Also add
support for computing deltas of these statistics between samples, such
as I/O ticks, number of sectors, and number of serviced I/Os.
These metrics can be used by tools such as nvme-top to display
real-time disk activity. Per-path metrics are particularly useful when
NVMe native multipath is enabled.
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
---
libnvme/src/libnvme.ld | 11 ++
libnvme/src/nvme/private.h | 30 ++++
libnvme/src/nvme/tree.c | 271 +++++++++++++++++++++++++++++++++++++
libnvme/src/nvme/tree.h | 93 +++++++++++++
4 files changed, 405 insertions(+)
diff --git a/libnvme/src/libnvme.ld b/libnvme/src/libnvme.ld
index 1ad02034a..6b7a08cb5 100644
--- a/libnvme/src/libnvme.ld
+++ b/libnvme/src/libnvme.ld
@@ -141,6 +141,17 @@ LIBNVME_3 {
libnvme_path_get_queue_depth;
libnvme_path_get_ana_state;
libnvme_path_get_numa_nodes;
+ libnvme_path_get_read_ios;
+ libnvme_path_get_write_ios;
+ libnvme_path_get_inflights;
+ libnvme_path_get_stat_interval;
+ libnvme_path_get_io_ticks;
+ libnvme_path_get_read_ticks;
+ libnvme_path_get_write_ticks;
+ libnvme_path_get_read_sectors;
+ libnvme_path_get_write_sectors;
+ libnvme_path_reset_stat;
+ libnvme_path_update_stat;
libnvme_random_uuid;
libnvme_read_config;
libnvme_read_hostid;
diff --git a/libnvme/src/nvme/private.h b/libnvme/src/nvme/private.h
index 037cde7e2..818303d85 100644
--- a/libnvme/src/nvme/private.h
+++ b/libnvme/src/nvme/private.h
@@ -15,6 +15,8 @@
#include "nvme/nvme-types.h"
#include "nvme/lib-types.h"
+#include <nvme/tree.h>
+
const char *libnvme_subsys_sysfs_dir(void);
const char *libnvme_ctrl_sysfs_dir(void);
const char *libnvme_ns_sysfs_dir(void);
@@ -167,10 +169,38 @@ struct libnvme_transport_handle {
struct libnvme_log *log;
};
+enum libnvme_stat_group {
+ READ = 0,
+ WRITE,
+ DISCARD,
+ FLUSH,
+
+ NR_STAT_GROUPS
+};
+
+struct libnvme_stat {
+ struct {
+ unsigned long ios;
+ unsigned long merges;
+ unsigned long long sectors;
+ unsigned int ticks; /* in milliseconds */
+ } group[NR_STAT_GROUPS];
+
+ unsigned int inflights;
+ unsigned int io_ticks; /* in milliseconds */
+ unsigned int tot_ticks; /* in milliseconds */
+
+ double ts_ms; /* timestamp when the stat is updated */
+};
+
struct libnvme_path { // !generate-accessors
struct list_node entry;
struct list_node nentry;
+ struct libnvme_stat stat[2]; /* gendisk I/O stat */
+ unsigned int curr_idx; /* current index into the stat[] */
+ bool diffstat; //!accessors:none
+
struct libnvme_ctrl *c;
struct libnvme_ns *n;
diff --git a/libnvme/src/nvme/tree.c b/libnvme/src/nvme/tree.c
index 9e8c18da4..6a05ae994 100644
--- a/libnvme/src/nvme/tree.c
+++ b/libnvme/src/nvme/tree.c
@@ -15,6 +15,7 @@
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
+#include <time.h>
#include <sys/stat.h>
#include <sys/types.h>
@@ -884,6 +885,276 @@ __public char *libnvme_path_get_numa_nodes(libnvme_path_t p)
return p->numa_nodes;
}
+static libnvme_stat_t libnvme_path_get_stat(libnvme_path_t p, unsigned int idx)
+{
+ if (idx > 1)
+ return NULL;
+
+ return &p->stat[idx];
+}
+
+__public void libnvme_path_reset_stat(libnvme_path_t p)
+{
+ libnvme_stat_t stat = &p->stat[0];
+
+ memset(stat, 0, 2 * sizeof(struct libnvme_stat));
+}
+
+static int libnvme_update_stat(const char *sysfs_stat_path, libnvme_stat_t stat)
+{
+ int n;
+ struct timespec ts;
+ unsigned long rd_ios, rd_merges, wr_ios, wr_merges;
+ unsigned long dc_ios, dc_merges, fl_ios;
+ unsigned long long rd_sectors, wr_sectors, dc_sectors;
+ unsigned int rd_ticks, wr_ticks, dc_ticks, fl_ticks;
+ unsigned int io_ticks, tot_ticks, inflights;
+
+ memset(stat, 0, sizeof(struct libnvme_stat));
+
+ n = sscanf(sysfs_stat_path,
+ "%lu %lu %llu %u %lu %lu %llu %u %u %u %u %lu %lu %llu %u %lu %u",
+ &rd_ios, &rd_merges, &rd_sectors, &rd_ticks,
+ &wr_ios, &wr_merges, &wr_sectors, &wr_ticks,
+ &inflights, &io_ticks, &tot_ticks,
+ &dc_ios, &dc_merges, &dc_sectors, &dc_ticks,
+ &fl_ios, &fl_ticks);
+
+ if (n < 17)
+ return -EINVAL;
+
+ /* update read stat */
+ stat->group[READ].ios = rd_ios;
+ stat->group[READ].merges = rd_merges;
+ stat->group[READ].sectors = rd_sectors;
+ stat->group[READ].ticks = rd_ticks;
+
+ /* update write stat */
+ stat->group[WRITE].ios = wr_ios;
+ stat->group[WRITE].merges = wr_merges;
+ stat->group[WRITE].sectors = wr_sectors;
+ stat->group[WRITE].ticks = wr_ticks;
+
+ /* update inflight counters and ticks */
+ stat->inflights = inflights;
+ stat->io_ticks = io_ticks;
+ stat->tot_ticks = tot_ticks;
+
+ /* update discard stat */
+ stat->group[DISCARD].ios = dc_ios;
+ stat->group[DISCARD].merges = dc_merges;
+ stat->group[DISCARD].sectors = dc_sectors;
+ stat->group[DISCARD].ticks = dc_ticks;
+
+ /* update flush stat */
+ stat->group[FLUSH].ios = fl_ios;
+ stat->group[FLUSH].ticks = fl_ticks;
+
+ clock_gettime(CLOCK_MONOTONIC, &ts);
+ stat->ts_ms = ts.tv_sec * 1000 + (double)ts.tv_nsec / 1e6;
+
+ return 0;
+}
+
+__public int libnvme_path_update_stat(libnvme_path_t p, bool diffstat)
+{
+ __cleanup_free char *sysfs_stat_path = NULL;
+ libnvme_stat_t stat;
+
+ p->diffstat = diffstat;
+ p->curr_idx ^= 1;
+ stat = libnvme_path_get_stat(p, p->curr_idx);
+ if (!stat)
+ return -EINVAL;
+
+ sysfs_stat_path = libnvme_get_path_attr(p, "stat");
+ if (!sysfs_stat_path)
+ return -EINVAL;
+
+ return libnvme_update_stat(sysfs_stat_path, stat);
+}
+
+static int libnvme_stat_get_inflights(libnvme_stat_t stat)
+{
+ return stat->inflights;
+}
+
+__public unsigned int libnvme_path_get_inflights(libnvme_path_t p)
+{
+ libnvme_stat_t curr;
+
+ curr = libnvme_path_get_stat(p, p->curr_idx);
+ if (!curr)
+ return 0;
+
+ return libnvme_stat_get_inflights(curr);
+}
+
+static int libnvme_stat_get_io_ticks(libnvme_stat_t curr, libnvme_stat_t prev,
+ bool diffstat)
+{
+ unsigned int delta = 0;
+
+ if (!diffstat)
+ return curr->io_ticks;
+
+ if (curr->io_ticks > prev->io_ticks)
+ delta = curr->io_ticks - prev->io_ticks;
+
+ return delta;
+}
+
+__public unsigned int libnvme_path_get_io_ticks(libnvme_path_t p)
+{
+ libnvme_stat_t curr, prev;
+
+ curr = libnvme_path_get_stat(p, p->curr_idx);
+ prev = libnvme_path_get_stat(p, !p->curr_idx);
+
+ if (!curr || !prev)
+ return 0;
+
+ return libnvme_stat_get_io_ticks(curr, prev, p->diffstat);
+}
+
+static unsigned int libnvme_stat_get_ticks(libnvme_stat_t curr,
+ libnvme_stat_t prev, enum libnvme_stat_group grp, bool diffstat)
+{
+ unsigned int delta = 0;
+
+ if (!diffstat)
+ return curr->group[grp].ticks;
+
+ if (curr->group[grp].ticks > prev->group[grp].ticks)
+ delta = curr->group[grp].ticks - prev->group[grp].ticks;
+
+ return delta;
+}
+
+static unsigned int __libnvme_path_get_ticks(libnvme_path_t p,
+ enum libnvme_stat_group grp)
+{
+ libnvme_stat_t curr, prev;
+
+ curr = libnvme_path_get_stat(p, p->curr_idx);
+ prev = libnvme_path_get_stat(p, !p->curr_idx);
+
+ if (!curr || !prev)
+ return 0;
+
+ return libnvme_stat_get_ticks(curr, prev, grp, p->diffstat);
+}
+
+__public unsigned int libnvme_path_get_read_ticks(libnvme_path_t p)
+{
+ return __libnvme_path_get_ticks(p, READ);
+}
+
+__public unsigned int libnvme_path_get_write_ticks(libnvme_path_t p)
+{
+ return __libnvme_path_get_ticks(p, WRITE);
+}
+
+static double libnvme_stat_get_interval(libnvme_stat_t curr,
+ libnvme_stat_t prev)
+{
+ double delta = 0.0;
+
+ if (prev->ts_ms && curr->ts_ms > prev->ts_ms)
+ delta = curr->ts_ms - prev->ts_ms;
+
+ return delta;
+}
+
+__public double libnvme_path_get_stat_interval(libnvme_path_t p)
+{
+ libnvme_stat_t curr, prev;
+
+ curr = libnvme_path_get_stat(p, p->curr_idx);
+ prev = libnvme_path_get_stat(p, !p->curr_idx);
+
+ if (!curr || !prev)
+ return 0;
+
+ return libnvme_stat_get_interval(curr, prev);
+}
+
+static unsigned long libnvme_stat_get_ios(libnvme_stat_t curr,
+ libnvme_stat_t prev, enum libnvme_stat_group grp, bool diffstat)
+{
+ unsigned long ios = 0;
+
+ if (!diffstat)
+ return curr->group[grp].ios;
+
+ if (curr->group[grp].ios > prev->group[grp].ios)
+ ios = curr->group[grp].ios - prev->group[grp].ios;
+
+ return ios;
+}
+
+static unsigned long __libnvme_path_get_ios(libnvme_path_t p,
+ enum libnvme_stat_group grp)
+{
+ libnvme_stat_t curr, prev;
+
+ curr = libnvme_path_get_stat(p, p->curr_idx);
+ prev = libnvme_path_get_stat(p, !p->curr_idx);
+
+ if (!curr || !prev)
+ return 0;
+
+ return libnvme_stat_get_ios(curr, prev, grp, p->diffstat);
+}
+
+__public unsigned long libnvme_path_get_read_ios(libnvme_path_t p)
+{
+ return __libnvme_path_get_ios(p, READ);
+}
+
+__public unsigned long libnvme_path_get_write_ios(libnvme_path_t p)
+{
+ return __libnvme_path_get_ios(p, WRITE);
+}
+
+static unsigned long long libnvme_stat_get_sectors(libnvme_stat_t curr,
+ libnvme_stat_t prev, enum libnvme_stat_group grp, bool diffstat)
+{
+ unsigned long long sec = 0;
+
+ if (!diffstat)
+ return curr->group[grp].sectors;
+
+ if (curr->group[grp].sectors > prev->group[grp].sectors)
+ sec = curr->group[grp].sectors - prev->group[grp].sectors;
+
+ return sec;
+}
+
+static unsigned long long __libnvme_path_get_sectors(libnvme_path_t p,
+ enum libnvme_stat_group grp)
+{
+ libnvme_stat_t curr, prev;
+
+ curr = libnvme_path_get_stat(p, p->curr_idx);
+ prev = libnvme_path_get_stat(p, !p->curr_idx);
+
+ if (!curr || !prev)
+ return 0;
+
+ return libnvme_stat_get_sectors(curr, prev, grp, p->diffstat);
+}
+
+__public unsigned long long libnvme_path_get_read_sectors(libnvme_path_t p)
+{
+ return __libnvme_path_get_sectors(p, READ);
+}
+
+__public unsigned long long libnvme_path_get_write_sectors(libnvme_path_t p)
+{
+ return __libnvme_path_get_sectors(p, WRITE);
+}
+
void nvme_free_path(struct libnvme_path *p)
{
if (!p)
diff --git a/libnvme/src/nvme/tree.h b/libnvme/src/nvme/tree.h
index 93140fcb0..b46c3c4c2 100644
--- a/libnvme/src/nvme/tree.h
+++ b/libnvme/src/nvme/tree.h
@@ -23,6 +23,7 @@
typedef struct libnvme_ns *libnvme_ns_t;
typedef struct libnvme_ns_head *libnvme_ns_head_t;
typedef struct libnvme_path *libnvme_path_t;
+typedef struct libnvme_stat *libnvme_stat_t;
typedef struct libnvme_ctrl *libnvme_ctrl_t;
typedef struct libnvme_subsystem *libnvme_subsystem_t;
typedef struct libnvme_host *libnvme_host_t;
@@ -700,6 +701,98 @@ libnvme_ctrl_t libnvme_path_get_ctrl(libnvme_path_t p);
*/
libnvme_ns_t libnvme_path_get_ns(libnvme_path_t p);
+/**
+ * libnvme_path_reset_stat() - Resets namespace path nvme stat
+ * @p: &libnvme_path_t object
+ */
+void libnvme_path_reset_stat(libnvme_path_t p);
+
+/**
+ * libnvme_path_update_stat() - Update stat of an nvme_path_t object
+ * @p: &libnvme_path_t object
+ * @diffstat: If set to true then getters return the diff stat otherwise
+ * return the current absolute stat
+ *
+ * Return: 0 on success, -1 on error
+ */
+int libnvme_path_update_stat(libnvme_path_t p, bool diffstat);
+
+/**
+ * libnvme_path_get_read_ios() - Calculate and return read IOs
+ * @p: &libnvme_path_t object
+ *
+ * Return: Num of read IOs processed between two stat samples
+ */
+unsigned long libnvme_path_get_read_ios(libnvme_path_t p);
+
+/**
+ * libnvme_path_get_write_ios() - Get write I/Os
+ * @p: &libnvme_path_t object
+ *
+ * Return: Num of write I/Os processed between two stat samples
+ */
+unsigned long libnvme_path_get_write_ios(libnvme_path_t p);
+
+/**
+ * libnvme_path_get_read_ticks() - Get read I/O ticks
+ * @p: &libnvme_path_t object
+ *
+ * Return: Time, in milliseconds, sepnt processing read I/O requests
+ * between two stat samples
+ */
+unsigned int libnvme_path_get_read_ticks(libnvme_path_t p);
+
+/**
+ * libnvme_path_get_read_sectors() - Get read I/O sectors
+ * @p: &libnvme_path_t object
+ *
+ * Return: Number of sectors read from the device between two stat samples
+ */
+unsigned long long libnvme_path_get_read_sectors(libnvme_path_t p);
+
+/**
+ * libnvme_path_get_write_sectors() - Get write I/O sectors
+ * @p: &libnvme_path_t object
+ *
+ * Return: Num of sectors written to the device between two stat samples
+ */
+unsigned long long libnvme_path_get_write_sectors(libnvme_path_t p);
+
+/**
+ * libnvme_path_get_write_ticks() - Get write I/O ticks
+ * @p: &libnvme_path_t object
+ *
+ * Return: Time, in milliseconds, sepnt processing write I/O requests
+ * between two stat samples
+ */
+unsigned int libnvme_path_get_write_ticks(libnvme_path_t p);
+
+/**
+ * libnvme_path_get_stat_interval() - Get interval between two stat samples
+ * @p: &libnvme_path_t object
+ *
+ * Return: Interval, in milliseconds between collection of two consecutive
+ * stat samples
+ */
+double libnvme_path_get_stat_interval(libnvme_path_t p);
+
+/**
+ * libnvme_path_get_io_ticks() - Get I/O ticks
+ * @p: &libnvme_path_t object
+ *
+ * Return: Time consumed, in milliseconds, processing I/O requests between
+ * two stat samples
+ */
+unsigned int libnvme_path_get_io_ticks(libnvme_path_t p);
+
+/**
+ * libnvme_path_get_inflights() - Inflight IOs for nvme_path_t object
+ * @p: &libnvme_path_t object
+ *
+ * Return: Inflight number of IOs
+ */
+unsigned int libnvme_path_get_inflights(libnvme_path_t p);
+
/**
* libnvme_ctrl_get_transport_handle() - Get associated transport handle
* @c: Controller instance
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCHv3 5/9] libnvme: add support for retrieving namespace gendisk I/O statistics
2026-04-21 14:50 [PATCHv3 0/9] libnvme: add support for retrieving additional NVMe stat Nilay Shroff
` (3 preceding siblings ...)
2026-04-21 14:50 ` [PATCHv3 4/9] libnvme: add support for retrieving per-path gendisk I/O statistics Nilay Shroff
@ 2026-04-21 14:50 ` Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 6/9] libnvme: add support for per-path diagnostic counters Nilay Shroff
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Nilay Shroff @ 2026-04-21 14:50 UTC (permalink / raw)
To: linux-nvme; +Cc: dwagner, hare, kbusch, hch, gjoyce, wenxiong, Nilay Shroff
Gendisk I/O statistics provide useful insight into disk activity,
including read/write/discard/flush operations, as well as information
about in-flight I/Os and I/O timing.
Parsing these statistics allows users to determine the number of I/Os
processed, time spent servicing I/O, number of sectors accessed, and
the count of in-flight requests.
Add support for retrieving namespace gendisk I/O statistics. Also add
support for computing deltas of these statistics between samples, such
as I/O ticks, number of sectors, and number of serviced I/Os.
These metrics can be used by tools such as nvme-top to display real-time
disk activity.
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
---
libnvme/src/libnvme.ld | 11 +++
libnvme/src/nvme/private.h | 5 ++
libnvme/src/nvme/tree.c | 142 +++++++++++++++++++++++++++++++++++++
libnvme/src/nvme/tree.h | 93 ++++++++++++++++++++++++
4 files changed, 251 insertions(+)
diff --git a/libnvme/src/libnvme.ld b/libnvme/src/libnvme.ld
index 6b7a08cb5..ce85c960e 100644
--- a/libnvme/src/libnvme.ld
+++ b/libnvme/src/libnvme.ld
@@ -129,6 +129,17 @@ LIBNVME_3 {
libnvme_ns_get_serial;
libnvme_ns_get_subsystem;
libnvme_ns_get_uuid;
+ libnvme_ns_reset_stat;
+ libnvme_ns_update_stat;
+ libnvme_ns_get_stat_interval;
+ libnvme_ns_get_read_ios;
+ libnvme_ns_get_write_ios;
+ libnvme_ns_get_read_ticks;
+ libnvme_ns_get_write_ticks;
+ libnvme_ns_get_read_sectors;
+ libnvme_ns_get_write_sectors;
+ libnvme_ns_get_inflights;
+ libnvme_ns_get_io_ticks;
libnvme_ns_identify;
libnvme_ns_read;
libnvme_ns_verify;
diff --git a/libnvme/src/nvme/private.h b/libnvme/src/nvme/private.h
index 818303d85..08b35e002 100644
--- a/libnvme/src/nvme/private.h
+++ b/libnvme/src/nvme/private.h
@@ -227,6 +227,11 @@ struct libnvme_ns { // !generate-accessors
struct libnvme_ns_head *head;
struct libnvme_global_ctx *ctx;
+
+ struct libnvme_stat stat[2]; /* gendisk I/O stat */
+ unsigned int curr_idx; /* current index into the stat[] */
+ bool diffstat; //!accessors:none
+
struct libnvme_transport_handle *hdl;
__u32 nsid;
char *name;
diff --git a/libnvme/src/nvme/tree.c b/libnvme/src/nvme/tree.c
index 6a05ae994..ca716bde7 100644
--- a/libnvme/src/nvme/tree.c
+++ b/libnvme/src/nvme/tree.c
@@ -900,6 +900,21 @@ __public void libnvme_path_reset_stat(libnvme_path_t p)
memset(stat, 0, 2 * sizeof(struct libnvme_stat));
}
+static libnvme_stat_t libnvme_ns_get_stat(libnvme_ns_t n, unsigned int idx)
+{
+ if (idx > 1)
+ return NULL;
+
+ return &n->stat[idx];
+}
+
+__public void libnvme_ns_reset_stat(libnvme_ns_t n)
+{
+ libnvme_stat_t stat = &n->stat[0];
+
+ memset(stat, 0, 2 * sizeof(struct libnvme_stat));
+}
+
static int libnvme_update_stat(const char *sysfs_stat_path, libnvme_stat_t stat)
{
int n;
@@ -974,6 +989,24 @@ __public int libnvme_path_update_stat(libnvme_path_t p, bool diffstat)
return libnvme_update_stat(sysfs_stat_path, stat);
}
+__public int libnvme_ns_update_stat(libnvme_ns_t n, bool diffstat)
+{
+ __cleanup_free char *sysfs_stat_path = NULL;
+ libnvme_stat_t stat;
+
+ n->diffstat = diffstat;
+ n->curr_idx ^= 1;
+ stat = libnvme_ns_get_stat(n, n->curr_idx);
+ if (!stat)
+ return -EINVAL;
+
+ sysfs_stat_path = libnvme_get_ns_attr(n, "stat");
+ if (!sysfs_stat_path)
+ return -EINVAL;
+
+ return libnvme_update_stat(sysfs_stat_path, stat);
+}
+
static int libnvme_stat_get_inflights(libnvme_stat_t stat)
{
return stat->inflights;
@@ -990,6 +1023,17 @@ __public unsigned int libnvme_path_get_inflights(libnvme_path_t p)
return libnvme_stat_get_inflights(curr);
}
+__public unsigned int libnvme_ns_get_inflights(libnvme_ns_t n)
+{
+ libnvme_stat_t curr;
+
+ curr = libnvme_ns_get_stat(n, n->curr_idx);
+ if (!curr)
+ return 0;
+
+ return libnvme_stat_get_inflights(curr);
+}
+
static int libnvme_stat_get_io_ticks(libnvme_stat_t curr, libnvme_stat_t prev,
bool diffstat)
{
@@ -1017,6 +1061,19 @@ __public unsigned int libnvme_path_get_io_ticks(libnvme_path_t p)
return libnvme_stat_get_io_ticks(curr, prev, p->diffstat);
}
+__public unsigned int libnvme_ns_get_io_ticks(libnvme_ns_t n)
+{
+ libnvme_stat_t curr, prev;
+
+ curr = libnvme_ns_get_stat(n, n->curr_idx);
+ prev = libnvme_ns_get_stat(n, !n->curr_idx);
+
+ if (!curr || !prev)
+ return 0;
+
+ return libnvme_stat_get_io_ticks(curr, prev, n->diffstat);
+}
+
static unsigned int libnvme_stat_get_ticks(libnvme_stat_t curr,
libnvme_stat_t prev, enum libnvme_stat_group grp, bool diffstat)
{
@@ -1055,6 +1112,30 @@ __public unsigned int libnvme_path_get_write_ticks(libnvme_path_t p)
return __libnvme_path_get_ticks(p, WRITE);
}
+static unsigned int __libnvme_ns_get_ticks(libnvme_ns_t n,
+ enum libnvme_stat_group grp)
+{
+ libnvme_stat_t curr, prev;
+
+ curr = libnvme_ns_get_stat(n, n->curr_idx);
+ prev = libnvme_ns_get_stat(n, !n->curr_idx);
+
+ if (!curr || !prev)
+ return 0;
+
+ return libnvme_stat_get_ticks(curr, prev, grp, n->diffstat);
+}
+
+__public unsigned int libnvme_ns_get_read_ticks(libnvme_ns_t n)
+{
+ return __libnvme_ns_get_ticks(n, READ);
+}
+
+__public unsigned int libnvme_ns_get_write_ticks(libnvme_ns_t n)
+{
+ return __libnvme_ns_get_ticks(n, WRITE);
+}
+
static double libnvme_stat_get_interval(libnvme_stat_t curr,
libnvme_stat_t prev)
{
@@ -1079,6 +1160,19 @@ __public double libnvme_path_get_stat_interval(libnvme_path_t p)
return libnvme_stat_get_interval(curr, prev);
}
+__public double libnvme_ns_get_stat_interval(libnvme_ns_t n)
+{
+ libnvme_stat_t curr, prev;
+
+ curr = libnvme_ns_get_stat(n, n->curr_idx);
+ prev = libnvme_ns_get_stat(n, !n->curr_idx);
+
+ if (!curr || !prev)
+ return 0;
+
+ return libnvme_stat_get_interval(curr, prev);
+}
+
static unsigned long libnvme_stat_get_ios(libnvme_stat_t curr,
libnvme_stat_t prev, enum libnvme_stat_group grp, bool diffstat)
{
@@ -1117,6 +1211,30 @@ __public unsigned long libnvme_path_get_write_ios(libnvme_path_t p)
return __libnvme_path_get_ios(p, WRITE);
}
+static unsigned long __libnvme_ns_get_ios(libnvme_ns_t n,
+ enum libnvme_stat_group grp)
+{
+ libnvme_stat_t curr, prev;
+
+ curr = libnvme_ns_get_stat(n, n->curr_idx);
+ prev = libnvme_ns_get_stat(n, !n->curr_idx);
+
+ if (!curr || !prev)
+ return 0;
+
+ return libnvme_stat_get_ios(curr, prev, grp, n->diffstat);
+}
+
+__public unsigned long libnvme_ns_get_read_ios(libnvme_ns_t n)
+{
+ return __libnvme_ns_get_ios(n, READ);
+}
+
+__public unsigned long libnvme_ns_get_write_ios(libnvme_ns_t n)
+{
+ return __libnvme_ns_get_ios(n, WRITE);
+}
+
static unsigned long long libnvme_stat_get_sectors(libnvme_stat_t curr,
libnvme_stat_t prev, enum libnvme_stat_group grp, bool diffstat)
{
@@ -1155,6 +1273,30 @@ __public unsigned long long libnvme_path_get_write_sectors(libnvme_path_t p)
return __libnvme_path_get_sectors(p, WRITE);
}
+static unsigned long long __libnvme_ns_get_sectors(libnvme_ns_t n,
+ enum libnvme_stat_group grp)
+{
+ libnvme_stat_t curr, prev;
+
+ curr = libnvme_ns_get_stat(n, n->curr_idx);
+ prev = libnvme_ns_get_stat(n, !n->curr_idx);
+
+ if (!curr || !prev)
+ return 0;
+
+ return libnvme_stat_get_sectors(curr, prev, grp, n->diffstat);
+}
+
+__public unsigned long long libnvme_ns_get_read_sectors(libnvme_ns_t n)
+{
+ return __libnvme_ns_get_sectors(n, READ);
+}
+
+__public unsigned long long libnvme_ns_get_write_sectors(libnvme_ns_t n)
+{
+ return __libnvme_ns_get_sectors(n, WRITE);
+}
+
void nvme_free_path(struct libnvme_path *p)
{
if (!p)
diff --git a/libnvme/src/nvme/tree.h b/libnvme/src/nvme/tree.h
index b46c3c4c2..a166d9df6 100644
--- a/libnvme/src/nvme/tree.h
+++ b/libnvme/src/nvme/tree.h
@@ -853,6 +853,99 @@ libnvme_subsystem_t libnvme_ctrl_get_subsystem(libnvme_ctrl_t c);
*/
const char *libnvme_ns_head_get_sysfs_dir(libnvme_ns_head_t head);
+/**
+ * libnvme_ns_update_stat() - update the nvme namespace stat
+ * @n: &libnvme_ns_t object
+ * @diffstat: If set to true then getters return the diff stat otherwise
+ * return the current absolute stat
+ *
+ * Returns: 0 on success, -1 on error
+ */
+int libnvme_ns_update_stat(libnvme_ns_t n, bool diffstat);
+
+/**
+ * libnvme_ns_reset_stat() - Resets nvme namespace stat
+ * @n: &libnvme_ns_t object
+ *
+ */
+void libnvme_ns_reset_stat(libnvme_ns_t n);
+
+/**
+ * libnvme_ns_get_inflights() - Inflight IOs for nvme_ns_t object
+ * @n: &libnvme_ns_t object
+ *
+ * Return: Inflight number of IOs
+ */
+unsigned int libnvme_ns_get_inflights(libnvme_ns_t n);
+
+/**
+ * libnvme_ns_get_io_ticks() - Get IO ticks
+ * @n: &libnvme_ns_t object
+ *
+ * Return: Time consumed, in milliseconds, processing I/O requests between
+ * two stat samples
+ */
+unsigned int libnvme_ns_get_io_ticks(libnvme_ns_t n);
+
+/**
+ * libnvme_ns_get_read_ticks() - Get read I/O ticks
+ * @n: &libnvme_ns_t object
+ *
+ * Return: Time, in milliseconds, sepnt processing read I/O requests
+ * between two stat samples
+ */
+unsigned int libnvme_ns_get_read_ticks(libnvme_ns_t n);
+
+/**
+ * libnvme_ns_get_write_ticks() - Get write I/O ticks
+ * @n: &libnvme_ns_t object
+ *
+ * Return: Time, in milliseconds, sepnt processing write I/O requests
+ * between two stat samples
+ */
+unsigned int libnvme_ns_get_write_ticks(libnvme_ns_t n);
+
+/**
+ * libnvme_ns_get_stat_interval() - Get interval between two stat samples
+ * @n: &libnvme_ns_t object
+ *
+ * Return: Interval, in milliseconds, between collection of two consecutive
+ * stat samples
+ */
+double libnvme_ns_get_stat_interval(libnvme_ns_t n);
+
+/**
+ * libnvme_ns_get_read_ios() - Get num of read I/Os
+ * @n: &libnvme_ns_t object
+ *
+ * Return: Num of read IOs processed between two stat samples
+ */
+unsigned long libnvme_ns_get_read_ios(libnvme_ns_t n);
+
+/**
+ * libnvme_ns_get_write_ios() - Get num of write I/Os
+ * @n: &libnvme_ns_t object
+ *
+ * Return: Num of write IOs processed between two consecutive stat samples
+ */
+unsigned long libnvme_ns_get_write_ios(libnvme_ns_t n);
+
+/**
+ * libnvme_ns_get_read_sectors() - Get num of read sectors
+ * @n: &libnvme_ns_t object
+ *
+ * Return: Num of sectors read from the device between two stat samples
+ */
+unsigned long long libnvme_ns_get_read_sectors(libnvme_ns_t n);
+
+/**
+ * libnvme_ns_get_write_sectors() - Get num of write sectors
+ * @n: &libnvme_ns_t object
+ *
+ * Return: Num of sectors written to the device between two stat samples
+ */
+unsigned long long libnvme_ns_get_write_sectors(libnvme_ns_t n);
+
/**
* libnvme_ctrl_identify() - Issues an 'identify controller' command
* @c: Controller instance
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCHv3 6/9] libnvme: add support for per-path diagnostic counters
2026-04-21 14:50 [PATCHv3 0/9] libnvme: add support for retrieving additional NVMe stat Nilay Shroff
` (4 preceding siblings ...)
2026-04-21 14:50 ` [PATCHv3 5/9] libnvme: add support for retrieving namespace " Nilay Shroff
@ 2026-04-21 14:50 ` Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 7/9] libnvme: add support for namespace " Nilay Shroff
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Nilay Shroff @ 2026-04-21 14:50 UTC (permalink / raw)
To: linux-nvme; +Cc: dwagner, hare, kbusch, hch, gjoyce, wenxiong, Nilay Shroff
Add support for retrieving per-path diagnostic counters such as
command_retry_count, command_error_count, and multipath_failover_count.
These counters improve visibility into NVMe native multipath behavior
and can be useful for tools such as nvme-top to display real-time
statistics.
Unlike other sysfs attributes, these counters can change dynamically.
Annotate them with "!accessors:none" and provide custom implementations
to always retrieve the latest (non-cached) values.
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
---
libnvme/src/libnvme.ld | 3 +++
libnvme/src/nvme/private.h | 5 ++++-
libnvme/src/nvme/tree.c | 33 +++++++++++++++++++++++++++++++++
libnvme/src/nvme/tree.h | 27 +++++++++++++++++++++++++++
4 files changed, 67 insertions(+), 1 deletion(-)
diff --git a/libnvme/src/libnvme.ld b/libnvme/src/libnvme.ld
index ce85c960e..85ff00e55 100644
--- a/libnvme/src/libnvme.ld
+++ b/libnvme/src/libnvme.ld
@@ -163,6 +163,9 @@ LIBNVME_3 {
libnvme_path_get_write_sectors;
libnvme_path_reset_stat;
libnvme_path_update_stat;
+ libnvme_path_get_command_retry_count;
+ libnvme_path_get_command_error_count;
+ libnvme_path_get_multipath_failover_count;
libnvme_random_uuid;
libnvme_read_config;
libnvme_read_hostid;
diff --git a/libnvme/src/nvme/private.h b/libnvme/src/nvme/private.h
index 08b35e002..7f01f8a7d 100644
--- a/libnvme/src/nvme/private.h
+++ b/libnvme/src/nvme/private.h
@@ -209,7 +209,10 @@ struct libnvme_path { // !generate-accessors
char *ana_state; //!accessors:none
char *numa_nodes; //!accessors:none
int grpid;
- int queue_depth; // !accessors:none
+ int queue_depth; //!accessors:none
+ long multipath_failover_count; //!accessors:none
+ long command_retry_count; //!accessors:none
+ long command_error_count; //!accessors:none
};
struct libnvme_ns_head {
diff --git a/libnvme/src/nvme/tree.c b/libnvme/src/nvme/tree.c
index ca716bde7..a603c2fde 100644
--- a/libnvme/src/nvme/tree.c
+++ b/libnvme/src/nvme/tree.c
@@ -885,6 +885,39 @@ __public char *libnvme_path_get_numa_nodes(libnvme_path_t p)
return p->numa_nodes;
}
+__public long libnvme_path_get_multipath_failover_count(libnvme_path_t p)
+{
+ __cleanup_free char *failover_count = NULL;
+
+ failover_count = libnvme_get_path_attr(p, "multipath_failover_count");
+ if (failover_count)
+ sscanf(failover_count, "%ld", &p->multipath_failover_count);
+
+ return p->multipath_failover_count;
+}
+
+__public long libnvme_path_get_command_retry_count(libnvme_path_t p)
+{
+ __cleanup_free char *retry_count = NULL;
+
+ retry_count = libnvme_get_path_attr(p, "command_retry_count");
+ if (retry_count)
+ sscanf(retry_count, "%ld", &p->command_retry_count);
+
+ return p->command_retry_count;
+}
+
+__public long libnvme_path_get_command_error_count(libnvme_path_t p)
+{
+ __cleanup_free char *error_count = NULL;
+
+ error_count = libnvme_get_path_attr(p, "command_error_count");
+ if (error_count)
+ sscanf(error_count, "%ld", &p->command_error_count);
+
+ return p->command_error_count;
+}
+
static libnvme_stat_t libnvme_path_get_stat(libnvme_path_t p, unsigned int idx)
{
if (idx > 1)
diff --git a/libnvme/src/nvme/tree.h b/libnvme/src/nvme/tree.h
index a166d9df6..2eb4cea0e 100644
--- a/libnvme/src/nvme/tree.h
+++ b/libnvme/src/nvme/tree.h
@@ -685,6 +685,33 @@ char *libnvme_path_get_ana_state(libnvme_path_t p);
*/
char *libnvme_path_get_numa_nodes(libnvme_path_t p);
+/**
+ * libnvme_path_get_multipath_failover_count() - Get multipath failover count
+ * @p: &libnvme_path_t object
+ *
+ * Return: Number of times I/Os have to be failed over to another active path
+ * from path @p maybe due to any transient error observed on path @p
+ */
+long libnvme_path_get_multipath_failover_count(libnvme_path_t p);
+
+/**
+ * libnvme_path_get_command_retry_count() - Get command retry count
+ * @p: &libnvme_path_t object
+ *
+ * Return: Number of times any command issued to the namespace represented by
+ * path @p has to be retried
+ */
+long libnvme_path_get_command_retry_count(libnvme_path_t p);
+
+/**
+ * libnvme_path_get_command_error_count() - Get command error count
+ * @p: &libnvme_path_t object
+ *
+ * Return: Number of times command issued to the namespace represented by path
+ * @p returns non-zero status or error
+ */
+long libnvme_path_get_command_error_count(libnvme_path_t p);
+
/**
* libnvme_path_get_ctrl() - Parent controller of an libnvme_path_t object
* @p: &libnvme_path_t object
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCHv3 7/9] libnvme: add support for namespace diagnostic counters
2026-04-21 14:50 [PATCHv3 0/9] libnvme: add support for retrieving additional NVMe stat Nilay Shroff
` (5 preceding siblings ...)
2026-04-21 14:50 ` [PATCHv3 6/9] libnvme: add support for per-path diagnostic counters Nilay Shroff
@ 2026-04-21 14:50 ` Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 8/9] libnvme: add support for nshead " Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 9/9] libnvme: add support for ctrl " Nilay Shroff
8 siblings, 0 replies; 10+ messages in thread
From: Nilay Shroff @ 2026-04-21 14:50 UTC (permalink / raw)
To: linux-nvme; +Cc: dwagner, hare, kbusch, hch, gjoyce, wenxiong, Nilay Shroff
Add support for retrieving namespace diagnostic counters such as
command_retry_count and command_error_count. These counters improve
visibility and can be useful for tools such as nvme-top to display
real-time statistics.
Unlike other sysfs attributes, these counters can change dynamically.
Annotate them with "!accessors:none" and provide custom implementations
to always retrieve the latest (non-cached) values.
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
---
libnvme/src/libnvme.ld | 2 ++
libnvme/src/nvme/private.h | 3 +++
libnvme/src/nvme/tree.c | 22 ++++++++++++++++++++++
libnvme/src/nvme/tree.h | 17 +++++++++++++++++
4 files changed, 44 insertions(+)
diff --git a/libnvme/src/libnvme.ld b/libnvme/src/libnvme.ld
index 85ff00e55..2fafd333c 100644
--- a/libnvme/src/libnvme.ld
+++ b/libnvme/src/libnvme.ld
@@ -140,6 +140,8 @@ LIBNVME_3 {
libnvme_ns_get_write_sectors;
libnvme_ns_get_inflights;
libnvme_ns_get_io_ticks;
+ libnvme_ns_get_command_retry_count;
+ libnvme_ns_get_command_error_count;
libnvme_ns_identify;
libnvme_ns_read;
libnvme_ns_verify;
diff --git a/libnvme/src/nvme/private.h b/libnvme/src/nvme/private.h
index 7f01f8a7d..ec0e1e848 100644
--- a/libnvme/src/nvme/private.h
+++ b/libnvme/src/nvme/private.h
@@ -251,6 +251,9 @@ struct libnvme_ns { // !generate-accessors
uint8_t nguid[16];
unsigned char uuid[NVME_UUID_LEN];
enum nvme_csi csi;
+
+ long command_retry_count; //!accessors:none
+ long command_error_count; //!accessors:none
};
struct libnvme_ctrl { // !generate-accessors
diff --git a/libnvme/src/nvme/tree.c b/libnvme/src/nvme/tree.c
index a603c2fde..f1a1311b7 100644
--- a/libnvme/src/nvme/tree.c
+++ b/libnvme/src/nvme/tree.c
@@ -2611,6 +2611,28 @@ __public void libnvme_ns_get_uuid(libnvme_ns_t n,
memcpy(out, n->uuid, NVME_UUID_LEN);
}
+__public long libnvme_ns_get_command_retry_count(libnvme_ns_t n)
+{
+ __cleanup_free char *retry_count = NULL;
+
+ retry_count = libnvme_get_ns_attr(n, "command_retry_count");
+ if (retry_count)
+ sscanf(retry_count, "%ld", &n->command_retry_count);
+
+ return n->command_retry_count;
+}
+
+__public long libnvme_ns_get_command_error_count(libnvme_ns_t n)
+{
+ __cleanup_free char *error_count = NULL;
+
+ error_count = libnvme_get_ns_attr(n, "command_error_count");
+ if (error_count)
+ sscanf(error_count, "%ld", &n->command_error_count);
+
+ return n->command_error_count;
+}
+
__public int libnvme_ns_identify(libnvme_ns_t n, struct nvme_id_ns *ns)
{
struct libnvme_transport_handle *hdl;
diff --git a/libnvme/src/nvme/tree.h b/libnvme/src/nvme/tree.h
index 2eb4cea0e..63cd20838 100644
--- a/libnvme/src/nvme/tree.h
+++ b/libnvme/src/nvme/tree.h
@@ -510,6 +510,23 @@ const uint8_t *libnvme_ns_get_nguid(libnvme_ns_t n);
*/
void libnvme_ns_get_uuid(libnvme_ns_t n, unsigned char out[NVME_UUID_LEN]);
+/**
+ * libnvme_ns_get_command_retry_count() - Get command retry count
+ * @n: &libnvme_ns_t object
+ *
+ * Return: Number of times any command issued to namespace @n has to be retried
+ */
+long libnvme_ns_get_command_retry_count(libnvme_ns_t n);
+
+/**
+ * libnvme_ns_get_command_error_count() - Get command error count
+ * @n: &libnvme_ns_t object
+ *
+ * Return: Number of times command issued to namespace @n returns non-zero
+ * status or error
+ */
+long libnvme_ns_get_command_error_count(libnvme_ns_t n);
+
/**
* libnvme_ns_get_generic_name() - Returns name of generic namespace chardev.
* @n: Namespace instance
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCHv3 8/9] libnvme: add support for nshead diagnostic counters
2026-04-21 14:50 [PATCHv3 0/9] libnvme: add support for retrieving additional NVMe stat Nilay Shroff
` (6 preceding siblings ...)
2026-04-21 14:50 ` [PATCHv3 7/9] libnvme: add support for namespace " Nilay Shroff
@ 2026-04-21 14:50 ` Nilay Shroff
2026-04-21 14:50 ` [PATCHv3 9/9] libnvme: add support for ctrl " Nilay Shroff
8 siblings, 0 replies; 10+ messages in thread
From: Nilay Shroff @ 2026-04-21 14:50 UTC (permalink / raw)
To: linux-nvme; +Cc: dwagner, hare, kbusch, hch, gjoyce, wenxiong, Nilay Shroff
Add support for retrieving nshead diagnostic counters such as requeue_
no_usable_path_count and fail_no_available_path_count.
The requeue_no_usable_path_count counter represents the number of I/Os
requeued to the namespace head when no usable path is available (for
example, due to transient link issues). The fail_no_available_path_count
counter represents the number of I/Os failed when no I/O path is
available (for example, when all paths are removed).
These counters improve visibility into NVMe native multipath behavior
and can be useful for tools such as nvme-top to display real-time
statistics.
Unlike other sysfs attributes, these counters can change dynamically.
Annotate them with "!accessors:none" and provide custom implementations
to always retrieve the latest (non-cached) values.
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
---
libnvme/src/libnvme.ld | 2 ++
libnvme/src/nvme/private.h | 2 ++
libnvme/src/nvme/tree.c | 22 ++++++++++++++++++++++
libnvme/src/nvme/tree.h | 17 +++++++++++++++++
4 files changed, 43 insertions(+)
diff --git a/libnvme/src/libnvme.ld b/libnvme/src/libnvme.ld
index 2fafd333c..c9841e45c 100644
--- a/libnvme/src/libnvme.ld
+++ b/libnvme/src/libnvme.ld
@@ -142,6 +142,8 @@ LIBNVME_3 {
libnvme_ns_get_io_ticks;
libnvme_ns_get_command_retry_count;
libnvme_ns_get_command_error_count;
+ libnvme_ns_get_requeue_no_usable_path_count;
+ libnvme_ns_get_fail_no_available_path_count;
libnvme_ns_identify;
libnvme_ns_read;
libnvme_ns_verify;
diff --git a/libnvme/src/nvme/private.h b/libnvme/src/nvme/private.h
index ec0e1e848..170445927 100644
--- a/libnvme/src/nvme/private.h
+++ b/libnvme/src/nvme/private.h
@@ -254,6 +254,8 @@ struct libnvme_ns { // !generate-accessors
long command_retry_count; //!accessors:none
long command_error_count; //!accessors:none
+ long requeue_no_usable_path_count; //!accessors:none
+ long fail_no_available_path_count; //!accessors:none
};
struct libnvme_ctrl { // !generate-accessors
diff --git a/libnvme/src/nvme/tree.c b/libnvme/src/nvme/tree.c
index f1a1311b7..085d79558 100644
--- a/libnvme/src/nvme/tree.c
+++ b/libnvme/src/nvme/tree.c
@@ -2633,6 +2633,28 @@ __public long libnvme_ns_get_command_error_count(libnvme_ns_t n)
return n->command_error_count;
}
+__public long libnvme_ns_get_requeue_no_usable_path_count(libnvme_ns_t n)
+{
+ __cleanup_free char *requeue_count = NULL;
+
+ requeue_count = libnvme_get_ns_attr(n, "requeue_no_usable_path_count");
+ if (requeue_count)
+ sscanf(requeue_count, "%ld", &n->requeue_no_usable_path_count);
+
+ return n->requeue_no_usable_path_count;
+}
+
+__public long libnvme_ns_get_fail_no_available_path_count(libnvme_ns_t n)
+{
+ __cleanup_free char *fail_count = NULL;
+
+ fail_count = libnvme_get_ns_attr(n, "fail_no_available_path_count");
+ if (fail_count)
+ sscanf(fail_count, "%ld", &n->fail_no_available_path_count);
+
+ return n->fail_no_available_path_count;
+}
+
__public int libnvme_ns_identify(libnvme_ns_t n, struct nvme_id_ns *ns)
{
struct libnvme_transport_handle *hdl;
diff --git a/libnvme/src/nvme/tree.h b/libnvme/src/nvme/tree.h
index 63cd20838..6bfc8cf98 100644
--- a/libnvme/src/nvme/tree.h
+++ b/libnvme/src/nvme/tree.h
@@ -527,6 +527,23 @@ long libnvme_ns_get_command_retry_count(libnvme_ns_t n);
*/
long libnvme_ns_get_command_error_count(libnvme_ns_t n);
+/**
+ * libnvme_ns_get_requeue_no_usable_path_count() - Get num of I/O requeue count
+ * @n: &libnvme_ns_t object
+ *
+ * Return: Number of I/Os which are re-queued due to the unavalibility of
+ * any usable path (maybe path is currently experiencing transinet link failure)
+ */
+long libnvme_ns_get_requeue_no_usable_path_count(libnvme_ns_t n);
+
+/**
+ * libnvme_ns_get_fail_no_available_path_count() - Get num of I/Os forced to fail
+ * @n: &libnvme_ns_t object
+ *
+ * Return: Number of I/Os which are forced to fail due to no path available
+ */
+long libnvme_ns_get_fail_no_available_path_count(libnvme_ns_t n);
+
/**
* libnvme_ns_get_generic_name() - Returns name of generic namespace chardev.
* @n: Namespace instance
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCHv3 9/9] libnvme: add support for ctrl diagnostic counters
2026-04-21 14:50 [PATCHv3 0/9] libnvme: add support for retrieving additional NVMe stat Nilay Shroff
` (7 preceding siblings ...)
2026-04-21 14:50 ` [PATCHv3 8/9] libnvme: add support for nshead " Nilay Shroff
@ 2026-04-21 14:50 ` Nilay Shroff
8 siblings, 0 replies; 10+ messages in thread
From: Nilay Shroff @ 2026-04-21 14:50 UTC (permalink / raw)
To: linux-nvme; +Cc: dwagner, hare, kbusch, hch, gjoyce, wenxiong, Nilay Shroff
Add support for retrieving ctrl diagnostic counters such as command_
error_count, reset_count and reconnect_count. These counters improve
visibility and can be useful for tools such as nvme-top to display
real-time statistics.
Unlike other sysfs attributes, these counters can change dynamically.
Annotate them with "!accessors:none" and provide custom implementations
to always retrieve the latest (non-cached) values.
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
---
libnvme/src/libnvme.ld | 3 +++
libnvme/src/nvme/private.h | 3 +++
libnvme/src/nvme/tree.c | 33 +++++++++++++++++++++++++++++++++
libnvme/src/nvme/tree.h | 25 +++++++++++++++++++++++++
4 files changed, 64 insertions(+)
diff --git a/libnvme/src/libnvme.ld b/libnvme/src/libnvme.ld
index c9841e45c..68df5e2b6 100644
--- a/libnvme/src/libnvme.ld
+++ b/libnvme/src/libnvme.ld
@@ -14,6 +14,9 @@ LIBNVME_3 {
libnvme_ctrl_get_subsysnqn;
libnvme_ctrl_get_subsystem;
libnvme_ctrl_get_transport_handle;
+ libnvme_ctrl_get_command_error_count;
+ libnvme_ctrl_get_reset_count;
+ libnvme_ctrl_get_reconnect_count;
libnvme_ctrl_identify;
libnvme_ctrl_match_config;
libnvme_ctrl_next_ns;
diff --git a/libnvme/src/nvme/private.h b/libnvme/src/nvme/private.h
index 170445927..f7612c06d 100644
--- a/libnvme/src/nvme/private.h
+++ b/libnvme/src/nvme/private.h
@@ -295,6 +295,9 @@ struct libnvme_ctrl { // !generate-accessors
bool unique_discovery_ctrl;
bool discovered;
bool persistent;
+ long command_error_count; //!accessors:none
+ long reset_count; //!accessors:none
+ long reconnect_count; //!accessors:none
struct libnvme_fabrics_config cfg;
};
diff --git a/libnvme/src/nvme/tree.c b/libnvme/src/nvme/tree.c
index 085d79558..f87a6d0c3 100644
--- a/libnvme/src/nvme/tree.c
+++ b/libnvme/src/nvme/tree.c
@@ -1458,6 +1458,39 @@ __public const char *libnvme_ctrl_get_state(libnvme_ctrl_t c)
return c->state;
}
+__public long libnvme_ctrl_get_command_error_count(libnvme_ctrl_t c)
+{
+ __cleanup_free char *error_count = NULL;
+
+ error_count = libnvme_get_ctrl_attr(c, "command_error_count");
+ if (error_count)
+ sscanf(error_count, "%ld", &c->command_error_count);
+
+ return c->command_error_count;
+}
+
+__public long libnvme_ctrl_get_reset_count(libnvme_ctrl_t c)
+{
+ __cleanup_free char *reset_count = NULL;
+
+ reset_count = libnvme_get_ctrl_attr(c, "reset_count");
+ if (reset_count)
+ sscanf(reset_count, "%ld", &c->reset_count);
+
+ return c->reset_count;
+}
+
+__public long libnvme_ctrl_get_reconnect_count(libnvme_ctrl_t c)
+{
+ __cleanup_free char *reconnect_count = NULL;
+
+ reconnect_count = libnvme_get_ctrl_attr(c, "reconnect_count");
+ if (reconnect_count)
+ sscanf(reconnect_count, "%ld", &c->reconnect_count);
+
+ return c->reconnect_count;
+}
+
__public int libnvme_ctrl_identify(libnvme_ctrl_t c, struct nvme_id_ctrl *id)
{
struct libnvme_transport_handle *hdl =
diff --git a/libnvme/src/nvme/tree.h b/libnvme/src/nvme/tree.h
index 6bfc8cf98..48f1beb49 100644
--- a/libnvme/src/nvme/tree.h
+++ b/libnvme/src/nvme/tree.h
@@ -1007,6 +1007,31 @@ unsigned long long libnvme_ns_get_read_sectors(libnvme_ns_t n);
*/
unsigned long long libnvme_ns_get_write_sectors(libnvme_ns_t n);
+/**
+ * libnvme_ctrl_get_command_error_count() - Get admin command error count
+ * @c: Controller instance
+ *
+ * Return: Number of times admin command issued to controller @c failed or
+ * returned error status
+ */
+long libnvme_ctrl_get_command_error_count(libnvme_ctrl_t c);
+
+/**
+ * libnvme_ctrl_get_reset_count() - Get controller reset count
+ * @c: Controller instance
+ *
+ * Return: Number of timer controller @c is reset
+ */
+long libnvme_ctrl_get_reset_count(libnvme_ctrl_t c);
+
+/**
+ * libnvme_ctrl_get_reconnect_count() - Get controller reconnect count
+ * @c: Controller instance
+ *
+ * Return: Number of times controller has to reconnect to the target
+ */
+long libnvme_ctrl_get_reconnect_count(libnvme_ctrl_t c);
+
/**
* libnvme_ctrl_identify() - Issues an 'identify controller' command
* @c: Controller instance
--
2.53.0
^ permalink raw reply related [flat|nested] 10+ messages in thread