* [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp
@ 2026-11-03 7:33 Guixin Liu
2026-11-03 7:40 ` Christoph Hellwig
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Guixin Liu @ 2026-11-03 7:33 UTC (permalink / raw)
To: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
Nilay Shroff, Daniel Wagner, Hannes Reinecke
Cc: linux-nvme
Commit 40f0e5dc2f3c ("nvmet-rdma: use sbitmap to replace rsp free
list") replaced the ->allocated flag with the discrete tag value
NVMET_RDMA_DISCRETE_RSP_TAG, but left the field behind. Nothing
references it anymore, so drop it.
Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
---
drivers/nvme/target/rdma.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index b9e39d1657d2..b645e103d6aa 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -71,7 +71,6 @@ struct nvmet_rdma_rsp {
struct nvmet_req req;
- bool allocated;
u8 n_rdma;
u32 flags;
u32 invalidate_rkey;
--
2.43.7
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp
2026-11-03 7:33 [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp Guixin Liu
@ 2026-11-03 7:40 ` Christoph Hellwig
2026-11-03 8:00 ` Nilay Shroff
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2026-11-03 7:40 UTC (permalink / raw)
To: Guixin Liu
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
Nilay Shroff, Daniel Wagner, Hannes Reinecke, linux-nvme
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp
2026-11-03 7:33 [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp Guixin Liu
2026-11-03 7:40 ` Christoph Hellwig
@ 2026-11-03 8:00 ` Nilay Shroff
2026-11-03 10:10 ` Daniel Wagner
2026-11-03 15:38 ` Keith Busch
3 siblings, 0 replies; 5+ messages in thread
From: Nilay Shroff @ 2026-11-03 8:00 UTC (permalink / raw)
To: Guixin Liu, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, Daniel Wagner, Hannes Reinecke
Cc: linux-nvme
On 11/3/26 1:03 PM, Guixin Liu wrote:
> Commit 40f0e5dc2f3c ("nvmet-rdma: use sbitmap to replace rsp free
> list") replaced the ->allocated flag with the discrete tag value
> NVMET_RDMA_DISCRETE_RSP_TAG, but left the field behind. Nothing
> references it anymore, so drop it.
>
> Signed-off-by: Guixin Liu<kanie@linux.alibaba.com>
Looks good to me:
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp
2026-11-03 7:33 [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp Guixin Liu
2026-11-03 7:40 ` Christoph Hellwig
2026-11-03 8:00 ` Nilay Shroff
@ 2026-11-03 10:10 ` Daniel Wagner
2026-11-03 15:38 ` Keith Busch
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Wagner @ 2026-11-03 10:10 UTC (permalink / raw)
To: Guixin Liu
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
Nilay Shroff, Hannes Reinecke, linux-nvme
On Tue, Nov 03, 2026 at 03:33:07PM +0800, Guixin Liu wrote:
> Commit 40f0e5dc2f3c ("nvmet-rdma: use sbitmap to replace rsp free
> list") replaced the ->allocated flag with the discrete tag value
> NVMET_RDMA_DISCRETE_RSP_TAG, but left the field behind. Nothing
> references it anymore, so drop it.
>
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp
2026-11-03 7:33 [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp Guixin Liu
` (2 preceding siblings ...)
2026-11-03 10:10 ` Daniel Wagner
@ 2026-11-03 15:38 ` Keith Busch
3 siblings, 0 replies; 5+ messages in thread
From: Keith Busch @ 2026-11-03 15:38 UTC (permalink / raw)
To: Guixin Liu
Cc: Jens Axboe, Christoph Hellwig, Sagi Grimberg, Nilay Shroff,
Daniel Wagner, Hannes Reinecke, linux-nvme
On Tue, Nov 03, 2026 at 03:33:07PM +0800, Guixin Liu wrote:
> Commit 40f0e5dc2f3c ("nvmet-rdma: use sbitmap to replace rsp free
> list") replaced the ->allocated flag with the discrete tag value
> NVMET_RDMA_DISCRETE_RSP_TAG, but left the field behind. Nothing
> references it anymore, so drop it.
Thanks, applied to nvme-7.4.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-11-03 15:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-03 7:33 [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp Guixin Liu
2026-11-03 7:40 ` Christoph Hellwig
2026-11-03 8:00 ` Nilay Shroff
2026-11-03 10:10 ` Daniel Wagner
2026-11-03 15:38 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox