* Re: [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp
2026-11-03 7:33 [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp Guixin Liu
@ 2026-11-03 7:40 ` Christoph Hellwig
2026-11-03 8:00 ` Nilay Shroff
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2026-11-03 7:40 UTC (permalink / raw)
To: Guixin Liu
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
Nilay Shroff, Daniel Wagner, Hannes Reinecke, linux-nvme
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp
2026-11-03 7:33 [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp Guixin Liu
2026-11-03 7:40 ` Christoph Hellwig
@ 2026-11-03 8:00 ` Nilay Shroff
2026-11-03 10:10 ` Daniel Wagner
2026-11-03 15:38 ` Keith Busch
3 siblings, 0 replies; 5+ messages in thread
From: Nilay Shroff @ 2026-11-03 8:00 UTC (permalink / raw)
To: Guixin Liu, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, Daniel Wagner, Hannes Reinecke
Cc: linux-nvme
On 11/3/26 1:03 PM, Guixin Liu wrote:
> Commit 40f0e5dc2f3c ("nvmet-rdma: use sbitmap to replace rsp free
> list") replaced the ->allocated flag with the discrete tag value
> NVMET_RDMA_DISCRETE_RSP_TAG, but left the field behind. Nothing
> references it anymore, so drop it.
>
> Signed-off-by: Guixin Liu<kanie@linux.alibaba.com>
Looks good to me:
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp
2026-11-03 7:33 [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp Guixin Liu
2026-11-03 7:40 ` Christoph Hellwig
2026-11-03 8:00 ` Nilay Shroff
@ 2026-11-03 10:10 ` Daniel Wagner
2026-11-03 15:38 ` Keith Busch
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Wagner @ 2026-11-03 10:10 UTC (permalink / raw)
To: Guixin Liu
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
Nilay Shroff, Hannes Reinecke, linux-nvme
On Tue, Nov 03, 2026 at 03:33:07PM +0800, Guixin Liu wrote:
> Commit 40f0e5dc2f3c ("nvmet-rdma: use sbitmap to replace rsp free
> list") replaced the ->allocated flag with the discrete tag value
> NVMET_RDMA_DISCRETE_RSP_TAG, but left the field behind. Nothing
> references it anymore, so drop it.
>
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp
2026-11-03 7:33 [PATCH] nvmet-rdma: remove dead allocated field in nvmet_rdma_rsp Guixin Liu
` (2 preceding siblings ...)
2026-11-03 10:10 ` Daniel Wagner
@ 2026-11-03 15:38 ` Keith Busch
3 siblings, 0 replies; 5+ messages in thread
From: Keith Busch @ 2026-11-03 15:38 UTC (permalink / raw)
To: Guixin Liu
Cc: Jens Axboe, Christoph Hellwig, Sagi Grimberg, Nilay Shroff,
Daniel Wagner, Hannes Reinecke, linux-nvme
On Tue, Nov 03, 2026 at 03:33:07PM +0800, Guixin Liu wrote:
> Commit 40f0e5dc2f3c ("nvmet-rdma: use sbitmap to replace rsp free
> list") replaced the ->allocated flag with the discrete tag value
> NVMET_RDMA_DISCRETE_RSP_TAG, but left the field behind. Nothing
> references it anymore, so drop it.
Thanks, applied to nvme-7.4.
^ permalink raw reply [flat|nested] 5+ messages in thread