From: Clay Mayers <Clay.Mayers@kioxia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Sagi Grimberg <sagi@grimberg.me>
Subject: RE: [PATCH V2 0/2] nvme: Support for fused NVME_IOCTL_SUBMIT_IO
Date: Tue, 9 Feb 2021 15:53:38 +0000 [thread overview]
Message-ID: <94d6c39917d04b88ae0099473df9f4d0@kioxia.com> (raw)
In-Reply-To: <20210209075434.GA31373@lst.de>
> From: Christoph Hellwig <hch@lst.de>
> Sent: Monday, February 8, 2021 11:55 PM
> To: Clay Mayers <Clay.Mayers@kioxia.com>
> Cc: linux-nvme@lists.infradead.org; Keith Busch <kbusch@kernel.org>; Jens
> Axboe <axboe@fb.com>; Chaitanya Kulkarni
> <Chaitanya.Kulkarni@wdc.com>; Christoph Hellwig <hch@lst.de>; Sagi
> Grimberg <sagi@grimberg.me>
> Subject: Re: [PATCH V2 0/2] nvme: Support for fused
> NVME_IOCTL_SUBMIT_IO
>
> On Tue, Feb 09, 2021 at 12:53:17AM +0000, Clay Mayers wrote:
> > > From: Clay Mayers
> > > Sent: Tuesday, January 26, 2021 1:14 PM
> > > To: linux-nvme@lists.infradead.org
> > > Cc: Keith Busch <kbusch@kernel.org>; Jens Axboe <axboe@fb.com>;
> > > 'Chaitanya Kulkarni' <Chaitanya.Kulkarni@wdc.com>; Christoph Hellwig
> > > <hch@lst.de>; Sagi Grimberg <sagi@grimberg.me>
> > > Subject: RE: [PATCH V2 0/2] nvme: Support for fused
> > > NVME_IOCTL_SUBMIT_IO
> > >
> > Is there any other feedback on V2?
>
> My feedback is that we should not add code to the kernel driver and our fast
> path for fused command unless we have a mainstream in-kernel users, that
> is not at all for the foreseeable future.
Thanks - that makes sense. I know the patch isn't enough to be very useful on
its own. I shared it at this stage because of my concern over the implementation.
Thanks to the feedback from the list, it is better than it was.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-02-09 15:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 22:49 [PATCH 0/2] nvme: Support for fused NVME_IOCTL_SUBMIT_IO klayph
2021-01-05 22:49 ` [PATCH 1/2] nvme: support fused nvme requests klayph
2021-01-05 23:52 ` Keith Busch
2021-01-06 14:55 ` Clay Mayers
2021-01-06 0:35 ` James Smart
2021-01-06 15:01 ` Clay Mayers
2021-01-06 7:59 ` Christoph Hellwig
2021-01-25 19:58 ` [PATCH V2 0/2] nvme: Support for fused NVME_IOCTL_SUBMIT_IO clay.mayers
2021-01-26 1:43 ` Chaitanya Kulkarni
2021-01-26 18:17 ` Clay Mayers
2021-01-26 19:00 ` Chaitanya Kulkarni
2021-01-26 21:14 ` Clay Mayers
2021-02-09 0:53 ` Clay Mayers
2021-02-09 3:12 ` Keith Busch
2021-02-09 15:24 ` Bart Van Assche
2021-02-09 15:38 ` Clay Mayers
2021-02-09 7:54 ` Christoph Hellwig
2021-02-09 15:53 ` Clay Mayers [this message]
2021-01-25 19:58 ` [PATCH V2 1/2] nvme: support fused pci nvme requests clay.mayers
2021-01-25 19:58 ` [PATCH V2 2/2] nvme: support fused NVME_IOCTL_SUBMIT_IO clay.mayers
2021-01-05 22:49 ` [PATCH " klayph
2021-01-05 23:04 ` [PATCH 0/2] nvme: Support for " James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94d6c39917d04b88ae0099473df9f4d0@kioxia.com \
--to=clay.mayers@kioxia.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox