From: Christoph Hellwig <hch@infradead.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: AlanCui4080 <me@alancui.cc>,
linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: make providing NGUID as UUID usage less scary
Date: Mon, 11 May 2026 01:16:37 -0700 [thread overview]
Message-ID: <agGQZU4NwAgSzHLD@infradead.org> (raw)
In-Reply-To: <73735bc1-9821-42d8-9594-1e9cdb03e15a@grimberg.me>
[the patch seem to be missing some maintainer Ccs]
On Mon, May 11, 2026 at 01:19:59AM +0300, Sagi Grimberg wrote:
> TBH, I'm not sure why should this be a warning or an info log. This looks
> like a debug print to me.
It is worse. For some reason the commit seems to imply the uuid
replaces the nguid and they can be intermixed.
We really need separate sysfs files for the different ids. I gues we
need to keep the existing one someone, but it is a mess.
next prev parent reply other threads:[~2026-05-11 8:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 16:36 [PATCH] nvme: make providing NGUID as UUID usage less scary AlanCui4080
2026-05-07 23:33 ` [PATCH V2] " AlanCui4080
2026-05-10 22:19 ` [PATCH] " Sagi Grimberg
2026-05-11 7:59 ` AlanCui4080
2026-05-11 8:16 ` Christoph Hellwig [this message]
2026-05-11 8:59 ` AlanCui4080
2026-05-11 9:16 ` AlanCui4080
2026-05-11 12:22 ` Christoph Hellwig
2026-05-11 14:48 ` Keith Busch
2026-05-12 6:02 ` Christoph Hellwig
2026-05-11 8:29 ` [PATCH RFC V2 RESEND] " AlanCui4080
2026-05-11 11:26 ` AlanCui4080
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agGQZU4NwAgSzHLD@infradead.org \
--to=hch@infradead.org \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=me@alancui.cc \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox