Re: [PATCH] nvme: make providing NGUID as UUID usage less scary

[Christoph Hellwig <hch@infradead.org>]

On Mon, May 11, 2026 at 08:48:46AM -0600, Keith Busch wrote:
> On Mon, May 11, 2026 at 01:16:37AM -0700, Christoph Hellwig wrote:
> > [the patch seem to be missing some maintainer Ccs]
> > 
> > On Mon, May 11, 2026 at 01:19:59AM +0300, Sagi Grimberg wrote:
> > > TBH, I'm not sure why should this be a warning or an info log. This looks
> > > like a debug print to me.
> > 
> > It is worse.  For some reason the commit seems to imply the uuid
> > replaces the nguid and they can be intermixed.
> > 
> > We really need separate sysfs files for the different ids.  I gues we
> > need to keep the existing one someone, but it is a mess.
> 
> Yes, sorry for the unpleasant situation this is. The attributes were
> rushed into the driver at the time.

I'm not trying to put blame.  But I think we need to sort this out
somehow - plenty of devices ship without a uuid and a system log
warning is not useful.  So I guess we need to slowly deprecate this
attribute and add proper ones for nguid/uuid.  But I can't really come
up with good names for them.