From: AlanCui4080 <me@alancui.cc>
To: Christoph Hellwig <hch@infradead.org>, Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: make providing NGUID as UUID usage less scary
Date: Mon, 11 May 2026 17:16:12 +0800 [thread overview]
Message-ID: <tIi1LbbYTSGqFm10GNZi8Q@alancui.cc> (raw)
In-Reply-To: <2MLVK7hsTb2JIM2tKTgqIg@alancui.cc>
On Monday, 11 May 2026 16:59,I wrote:
> For NVMe spec revision 1.3, there is no UUID yet.
>
> If it's mandatory for userspace, why the nvme2n1 has not, if it's not
> mandatory, why should we create the UUID sysfd attr. then put NGUID in it?
> But for a NVMe 1.3 device there is both no UUID and no NGUID, while kernel
> is not reporting warnings at all?
Sorry, I checked the 1.3 specification and found that there is
NGUID and UUID in it.
The only difference between revision 1.3 and 1.4 is Revision 1.4
states that UUIDs should be reported when neither EUI64 nor NGUID is supported.
It seems that for an NVMe 1.4 device, its UUID is mandatory when EUI64/NGUID
is not supported. However, the kernel chooses to expose both the UUID and
NGUID of a device with an NGUID but no UUID to sysfs, then warns us every
time we read the device that an NGUID is being used to impersonate a UUID.
But for an NVMe 1.3 device, its UUID is optional when EUI64/NGUID is not
present. However, the kernel chooses not to expose either the UUID or NGUID
of a device with an NGUID but no UUID to sysfs.
This is incredibly strange.
Alan.
next prev parent reply other threads:[~2026-05-11 9:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 16:36 [PATCH] nvme: make providing NGUID as UUID usage less scary AlanCui4080
2026-05-07 23:33 ` [PATCH V2] " AlanCui4080
2026-05-10 22:19 ` [PATCH] " Sagi Grimberg
2026-05-11 7:59 ` AlanCui4080
2026-05-11 8:16 ` Christoph Hellwig
2026-05-11 8:59 ` AlanCui4080
2026-05-11 9:16 ` AlanCui4080 [this message]
2026-05-11 12:22 ` Christoph Hellwig
2026-05-11 14:48 ` Keith Busch
2026-05-12 6:02 ` Christoph Hellwig
2026-05-11 8:29 ` [PATCH RFC V2 RESEND] " AlanCui4080
2026-05-11 11:26 ` AlanCui4080
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tIi1LbbYTSGqFm10GNZi8Q@alancui.cc \
--to=me@alancui.cc \
--cc=hch@infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox