From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] NVMe: Skip namespaces with interleaved meta-data
Date: Tue, 27 Jan 2015 22:09:35 +0000 (UTC) [thread overview]
Message-ID: <alpine.LNX.2.00.1501272203000.15481@localhost.lm.intel.com> (raw)
In-Reply-To: <1422395867952.40819@hgst.com>
On Tue, 27 Jan 2015, David Darrington wrote:
> What happens if a namespace includes metadata that is not interleaved (flbas
> bit 4 = 0)? Won't the reads/writes through the normal block io path cause
> metadata to be read/written to/from MPTR, which is not set in
> nvme_submit_iod() so will point to address 0.
You're absolutely right. I'm not sure what happens (I don't have a device
with separate metadata capabilities) but was hoping the device wouldn't
try to DMA to/from 0, or it would be aborted by the root complex if it
made it that far. Wishful thinking, probably not aligned with reality.
The nvme_submit_io() path enforces correct MPTR usage, though!
next prev parent reply other threads:[~2015-01-27 22:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 18:07 [PATCH] NVMe: Skip namespaces with interleaved meta-data Keith Busch
2015-01-27 21:57 ` David Darrington
2015-01-27 22:09 ` Keith Busch [this message]
2015-01-28 1:21 ` Keith Busch
2015-01-28 1:39 ` Martin K. Petersen
2015-01-28 15:11 ` Keith Busch
2015-01-28 20:50 ` Paul Grabinar
2015-01-28 21:16 ` Keith Busch
2015-01-28 21:46 ` Paul Grabinar
2015-01-28 22:08 ` Martin K. Petersen
2015-01-28 22:17 ` Keith Busch
2015-01-28 22:28 ` Martin K. Petersen
2015-01-29 0:09 ` Keith Busch
2015-01-29 0:57 ` Martin K. Petersen
2015-01-29 15:44 ` Keith Busch
2015-01-30 0:41 ` Martin K. Petersen
2015-01-30 0:57 ` Keith Busch
2015-01-28 22:17 ` Andrey Kuzmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1501272203000.15481@localhost.lm.intel.com \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox