From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] NVMe: Skip namespaces with interleaved meta-data
Date: Thu, 29 Jan 2015 15:44:41 +0000 (UTC) [thread overview]
Message-ID: <alpine.LNX.2.00.1501291542270.15481@localhost.lm.intel.com> (raw)
In-Reply-To: <yq1a912iet4.fsf@sermon.lab.mkp.net>
On Wed, 28 Jan 2015, Martin K. Petersen wrote:
>>>>>> "Keith" == Keith Busch <keith.busch at intel.com> writes:
>
> Keith> Integrity verify is broken in here. blk_mq_end_request() calls
> Keith> blk_update_request(), which moves the bio iterator to the end.
> Keith> When we get to bio_integrity_process(), there's nothing for it to
> Keith> do, so verification is skipped.
>
> Looks like 594416a72032 inadvertently broke this.
Good call, reverting that at least addresses my problem.
> Does using __bio_for_each_segment() help?
Sorry, I don't follow. That still takes an iterator, but the bio's is
advanced to the end, and I don't see how to get it to the original start.
next prev parent reply other threads:[~2015-01-29 15:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 18:07 [PATCH] NVMe: Skip namespaces with interleaved meta-data Keith Busch
2015-01-27 21:57 ` David Darrington
2015-01-27 22:09 ` Keith Busch
2015-01-28 1:21 ` Keith Busch
2015-01-28 1:39 ` Martin K. Petersen
2015-01-28 15:11 ` Keith Busch
2015-01-28 20:50 ` Paul Grabinar
2015-01-28 21:16 ` Keith Busch
2015-01-28 21:46 ` Paul Grabinar
2015-01-28 22:08 ` Martin K. Petersen
2015-01-28 22:17 ` Keith Busch
2015-01-28 22:28 ` Martin K. Petersen
2015-01-29 0:09 ` Keith Busch
2015-01-29 0:57 ` Martin K. Petersen
2015-01-29 15:44 ` Keith Busch [this message]
2015-01-30 0:41 ` Martin K. Petersen
2015-01-30 0:57 ` Keith Busch
2015-01-28 22:17 ` Andrey Kuzmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1501291542270.15481@localhost.lm.intel.com \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox