Re: [PATCH 06/16] nvme-sysfs: add 'tls_keyring' attribute

[Sagi Grimberg <sagi@grimberg.me>]

On 17/07/2024 12:10, Hannes Reinecke wrote:
> Add a 'tls_keyring' attribute to display the contents of the
> --keyring option from the connect string. Adding this attribute
> allows us to recreate the original connect string from sysfs
> settings.
>
> Signed-off-by: Hannes Reinecke <hare@kernel.org>
> ---
>   drivers/nvme/host/sysfs.c | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c
> index e5cd738660b1..462d71e2fbf8 100644
> --- a/drivers/nvme/host/sysfs.c
> +++ b/drivers/nvme/host/sysfs.c
> @@ -689,6 +689,18 @@ static ssize_t tls_configured_key_show(struct device *dev,
>   	return sysfs_emit(buf, "%08x\n", key_serial(key));
>   }
>   static DEVICE_ATTR_RO(tls_configured_key);
> +
> +static ssize_t tls_keyring_show(struct device *dev,
> +		struct device_attribute *attr, char *buf)
> +{
> +	struct nvme_ctrl *ctrl = dev_get_drvdata(dev);
> +	struct key *keyring = ctrl->opts->keyring;
> +
> +	if (!keyring)
> +		return 0;

Same comment as the last patch.