* [PATCH 1/2] nvme: add missing path related status values
@ 2022-04-28 9:19 Max Gurtovoy
2022-04-28 9:19 ` [PATCH 2/2] nvme: add missing status values to verbose logging Max Gurtovoy
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Max Gurtovoy @ 2022-04-28 9:19 UTC (permalink / raw)
To: hch, linux-nvme, sagi, kbusch, kch; +Cc: Max Gurtovoy
The following path related status code from the NVM specification were
added: Internal Path Error (00h) and Controller Pathing Error (60h).
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
include/linux/nvme.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index f626a445d1a8..bbabdc7600da 100644
--- a/include/linux/nvme.h
+++ b/include/linux/nvme.h
@@ -1679,9 +1679,11 @@ enum {
/*
* Path-related Errors:
*/
+ NVME_SC_INTERNAL_PATH_ERROR = 0x300,
NVME_SC_ANA_PERSISTENT_LOSS = 0x301,
NVME_SC_ANA_INACCESSIBLE = 0x302,
NVME_SC_ANA_TRANSITION = 0x303,
+ NVME_SC_CTRL_PATH_ERROR = 0x360,
NVME_SC_HOST_PATH_ERROR = 0x370,
NVME_SC_HOST_ABORTED_CMD = 0x371,
--
2.18.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] nvme: add missing status values to verbose logging
2022-04-28 9:19 [PATCH 1/2] nvme: add missing path related status values Max Gurtovoy
@ 2022-04-28 9:19 ` Max Gurtovoy
2022-04-29 6:08 ` Hannes Reinecke
2022-04-29 6:08 ` [PATCH 1/2] nvme: add missing path related status values Hannes Reinecke
2022-05-10 6:19 ` Christoph Hellwig
2 siblings, 1 reply; 6+ messages in thread
From: Max Gurtovoy @ 2022-04-28 9:19 UTC (permalink / raw)
To: hch, linux-nvme, sagi, kbusch, kch; +Cc: Max Gurtovoy
The following status values were added: NVME_SC_INTERNAL_PATH_ERROR,
NVME_SC_CTRL_PATH_ERROR and NVME_SC_HOST_ABORTED_CMD.
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
drivers/nvme/host/constants.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/nvme/host/constants.c b/drivers/nvme/host/constants.c
index 6c2aa8eefb55..1dd1d78de295 100644
--- a/drivers/nvme/host/constants.c
+++ b/drivers/nvme/host/constants.c
@@ -154,10 +154,13 @@ static const char * const nvme_statuses[] = {
[NVME_SC_COMPARE_FAILED] = "Compare Failure",
[NVME_SC_ACCESS_DENIED] = "Access Denied",
[NVME_SC_UNWRITTEN_BLOCK] = "Deallocated or Unwritten Logical Block",
+ [NVME_SC_INTERNAL_PATH_ERROR] = "Internal Pathing Error",
[NVME_SC_ANA_PERSISTENT_LOSS] = "Asymmetric Access Persistent Loss",
[NVME_SC_ANA_INACCESSIBLE] = "Asymmetric Access Inaccessible",
[NVME_SC_ANA_TRANSITION] = "Asymmetric Access Transition",
+ [NVME_SC_CTRL_PATH_ERROR] = "Controller Pathing Error",
[NVME_SC_HOST_PATH_ERROR] = "Host Pathing Error",
+ [NVME_SC_HOST_ABORTED_CMD] = "Host Aborted Command",
};
const unsigned char *nvme_get_error_status_str(u16 status)
--
2.18.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] nvme: add missing status values to verbose logging
2022-04-28 9:19 ` [PATCH 2/2] nvme: add missing status values to verbose logging Max Gurtovoy
@ 2022-04-29 6:08 ` Hannes Reinecke
2022-05-01 8:24 ` Max Gurtovoy
0 siblings, 1 reply; 6+ messages in thread
From: Hannes Reinecke @ 2022-04-29 6:08 UTC (permalink / raw)
To: Max Gurtovoy, hch, linux-nvme, sagi, kbusch, kch
On 4/28/22 11:19, Max Gurtovoy wrote:
> The following status values were added: NVME_SC_INTERNAL_PATH_ERROR,
> NVME_SC_CTRL_PATH_ERROR and NVME_SC_HOST_ABORTED_CMD.
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
> drivers/nvme/host/constants.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/nvme/host/constants.c b/drivers/nvme/host/constants.c
> index 6c2aa8eefb55..1dd1d78de295 100644
> --- a/drivers/nvme/host/constants.c
> +++ b/drivers/nvme/host/constants.c
> @@ -154,10 +154,13 @@ static const char * const nvme_statuses[] = {
> [NVME_SC_COMPARE_FAILED] = "Compare Failure",
> [NVME_SC_ACCESS_DENIED] = "Access Denied",
> [NVME_SC_UNWRITTEN_BLOCK] = "Deallocated or Unwritten Logical Block",
> + [NVME_SC_INTERNAL_PATH_ERROR] = "Internal Pathing Error",
> [NVME_SC_ANA_PERSISTENT_LOSS] = "Asymmetric Access Persistent Loss",
> [NVME_SC_ANA_INACCESSIBLE] = "Asymmetric Access Inaccessible",
> [NVME_SC_ANA_TRANSITION] = "Asymmetric Access Transition",
> + [NVME_SC_CTRL_PATH_ERROR] = "Controller Pathing Error",
> [NVME_SC_HOST_PATH_ERROR] = "Host Pathing Error",
> + [NVME_SC_HOST_ABORTED_CMD] = "Host Aborted Command",
> };
>
> const unsigned char *nvme_get_error_status_str(u16 status)
As mentioned, maybe merge with the first patch.
But that's merely cosmetical.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] nvme: add missing status values to verbose logging
2022-04-29 6:08 ` Hannes Reinecke
@ 2022-05-01 8:24 ` Max Gurtovoy
0 siblings, 0 replies; 6+ messages in thread
From: Max Gurtovoy @ 2022-05-01 8:24 UTC (permalink / raw)
To: Hannes Reinecke, hch, linux-nvme, sagi, kbusch, kch
On 4/29/2022 9:08 AM, Hannes Reinecke wrote:
> On 4/28/22 11:19, Max Gurtovoy wrote:
>> The following status values were added: NVME_SC_INTERNAL_PATH_ERROR,
>> NVME_SC_CTRL_PATH_ERROR and NVME_SC_HOST_ABORTED_CMD.
>>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> ---
>> drivers/nvme/host/constants.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/nvme/host/constants.c
>> b/drivers/nvme/host/constants.c
>> index 6c2aa8eefb55..1dd1d78de295 100644
>> --- a/drivers/nvme/host/constants.c
>> +++ b/drivers/nvme/host/constants.c
>> @@ -154,10 +154,13 @@ static const char * const nvme_statuses[] = {
>> [NVME_SC_COMPARE_FAILED] = "Compare Failure",
>> [NVME_SC_ACCESS_DENIED] = "Access Denied",
>> [NVME_SC_UNWRITTEN_BLOCK] = "Deallocated or Unwritten Logical
>> Block",
>> + [NVME_SC_INTERNAL_PATH_ERROR] = "Internal Pathing Error",
>> [NVME_SC_ANA_PERSISTENT_LOSS] = "Asymmetric Access Persistent
>> Loss",
>> [NVME_SC_ANA_INACCESSIBLE] = "Asymmetric Access Inaccessible",
>> [NVME_SC_ANA_TRANSITION] = "Asymmetric Access Transition",
>> + [NVME_SC_CTRL_PATH_ERROR] = "Controller Pathing Error",
>> [NVME_SC_HOST_PATH_ERROR] = "Host Pathing Error",
>> + [NVME_SC_HOST_ABORTED_CMD] = "Host Aborted Command",
>> };
>> const unsigned char *nvme_get_error_status_str(u16 status)
>
> As mentioned, maybe merge with the first patch.
> But that's merely cosmetical.
Thanks.
I'm fine with squashing it to 1 commit if needed.
Or it can be done during the merge to nvme tree.
Christoph, please comment what is preferred ?
>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
>
> Cheers,
>
> Hannes
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] nvme: add missing path related status values
2022-04-28 9:19 [PATCH 1/2] nvme: add missing path related status values Max Gurtovoy
2022-04-28 9:19 ` [PATCH 2/2] nvme: add missing status values to verbose logging Max Gurtovoy
@ 2022-04-29 6:08 ` Hannes Reinecke
2022-05-10 6:19 ` Christoph Hellwig
2 siblings, 0 replies; 6+ messages in thread
From: Hannes Reinecke @ 2022-04-29 6:08 UTC (permalink / raw)
To: Max Gurtovoy, hch, linux-nvme, sagi, kbusch, kch
On 4/28/22 11:19, Max Gurtovoy wrote:
> The following path related status code from the NVM specification were
> added: Internal Path Error (00h) and Controller Pathing Error (60h).
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
> include/linux/nvme.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index f626a445d1a8..bbabdc7600da 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -1679,9 +1679,11 @@ enum {
> /*
> * Path-related Errors:
> */
> + NVME_SC_INTERNAL_PATH_ERROR = 0x300,
> NVME_SC_ANA_PERSISTENT_LOSS = 0x301,
> NVME_SC_ANA_INACCESSIBLE = 0x302,
> NVME_SC_ANA_TRANSITION = 0x303,
> + NVME_SC_CTRL_PATH_ERROR = 0x360,
> NVME_SC_HOST_PATH_ERROR = 0x370,
> NVME_SC_HOST_ABORTED_CMD = 0x371,
>
I would merge both patches.
However:
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] nvme: add missing path related status values
2022-04-28 9:19 [PATCH 1/2] nvme: add missing path related status values Max Gurtovoy
2022-04-28 9:19 ` [PATCH 2/2] nvme: add missing status values to verbose logging Max Gurtovoy
2022-04-29 6:08 ` [PATCH 1/2] nvme: add missing path related status values Hannes Reinecke
@ 2022-05-10 6:19 ` Christoph Hellwig
2 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2022-05-10 6:19 UTC (permalink / raw)
To: Max Gurtovoy; +Cc: hch, linux-nvme, sagi, kbusch, kch
Thanks, I've applied the two patches and merged them into one.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-10 6:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-28 9:19 [PATCH 1/2] nvme: add missing path related status values Max Gurtovoy
2022-04-28 9:19 ` [PATCH 2/2] nvme: add missing status values to verbose logging Max Gurtovoy
2022-04-29 6:08 ` Hannes Reinecke
2022-05-01 8:24 ` Max Gurtovoy
2022-04-29 6:08 ` [PATCH 1/2] nvme: add missing path related status values Hannes Reinecke
2022-05-10 6:19 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox