public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Venkatraman S <svenkatr@ti.com>
To: linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org
Cc: cjb@laptop.org, balajitk@ti.com, vishp@ti.com,
	Venkatraman S <svenkatr@ti.com>
Subject: [PATCH 05/10] mmc: omap_hsmmc: remove unused vars and includes
Date: Sat, 18 Aug 2012 00:22:25 +0530	[thread overview]
Message-ID: <1345229550-8672-6-git-send-email-svenkatr@ti.com> (raw)
In-Reply-To: <1345229550-8672-1-git-send-email-svenkatr@ti.com>

Some straight forward cleanup of unnecessary #include's
and host variables. Some of the verbose and redundant
debug messages are converted to use dev_vdbg.

Signed-off-by: Venkatraman S <svenkatr@ti.com>
---
 drivers/mmc/host/omap_hsmmc.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index e180735..da4f5a7 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -35,7 +35,6 @@
 #include <linux/mmc/core.h>
 #include <linux/mmc/mmc.h>
 #include <linux/io.h>
-#include <linux/semaphore.h>
 #include <linux/gpio.h>
 #include <linux/regulator/consumer.h>
 #include <linux/pm_runtime.h>
@@ -162,8 +161,6 @@ struct omap_hsmmc_host {
 	unsigned int		dma_sg_idx;
 	unsigned char		bus_mode;
 	unsigned char		power_mode;
-	u32			*buffer;
-	u32			bytesleft;
 	int			suspended;
 	int			irq;
 	int			use_dma, dma_ch;
@@ -172,7 +169,6 @@ struct omap_hsmmc_host {
 	int			slot_id;
 	int			response_busy;
 	int			context_loss;
-	int			vdd;
 	int			protect_card;
 	int			reqs_blocked;
 	int			use_reg;
@@ -496,7 +492,7 @@ static void omap_hsmmc_set_clock(struct omap_hsmmc_host *host)
 	unsigned long regval;
 	unsigned long timeout;
 
-	dev_dbg(mmc_dev(host->mmc), "Set clock to %uHz\n", ios->clock);
+	dev_vdbg(mmc_dev(host->mmc), "Set clock to %uHz\n", ios->clock);
 
 	omap_hsmmc_stop_clock(host);
 
@@ -746,7 +742,7 @@ omap_hsmmc_start_command(struct omap_hsmmc_host *host, struct mmc_command *cmd,
 {
 	int cmdreg = 0, resptype = 0, cmdtype = 0;
 
-	dev_dbg(mmc_dev(host->mmc), "%s: CMD%d, argument 0x%08x\n",
+	dev_vdbg(mmc_dev(host->mmc), "%s: CMD%d, argument 0x%08x\n",
 		mmc_hostname(host->mmc), cmd->opcode, cmd->arg);
 	host->cmd = cmd;
 
@@ -935,7 +931,7 @@ static void omap_hsmmc_dbg_report_irq(struct omap_hsmmc_host *host, u32 status)
 			buf += len;
 		}
 
-	dev_dbg(mmc_dev(host->mmc), "%s\n", res);
+	dev_vdbg(mmc_dev(host->mmc), "%s\n", res);
 }
 #else
 static inline void omap_hsmmc_dbg_report_irq(struct omap_hsmmc_host *host,
@@ -997,7 +993,7 @@ static void omap_hsmmc_do_irq(struct omap_hsmmc_host *host, int status)
 	}
 
 	data = host->data;
-	dev_dbg(mmc_dev(host->mmc), "IRQ Status is %x\n", status);
+	dev_vdbg(mmc_dev(host->mmc), "IRQ Status is %x\n", status);
 
 	if (status & ERR) {
 		omap_hsmmc_dbg_report_irq(host, status);
@@ -1502,12 +1498,10 @@ static void omap_hsmmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 		case MMC_POWER_OFF:
 			mmc_slot(host).set_power(host->dev, host->slot_id,
 						 0, 0);
-			host->vdd = 0;
 			break;
 		case MMC_POWER_UP:
 			mmc_slot(host).set_power(host->dev, host->slot_id,
 						 1, ios->vdd);
-			host->vdd = ios->vdd;
 			break;
 		case MMC_POWER_ON:
 			do_send_init_stream = 1;
-- 
1.7.11.1.25.g0e18bef


  parent reply	other threads:[~2012-08-17 18:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-17 18:52 [PATCH 00/10] Assorted MMC / OMAP HSMMC patches Venkatraman S
2012-08-17 18:52 ` [PATCH 01/10] mmc: core: Add TRANsfer state to non-HPI state Venkatraman S
2012-08-17 18:52 ` [PATCH 02/10] mmc: debugfs: Print ext_csd in ascending order Venkatraman S
2012-08-17 18:52 ` [PATCH 03/10] mmc: omap: remove unused variables and includes Venkatraman S
2012-08-17 18:52 ` [PATCH 04/10] mmc: omap: fix mmc_omap_report_irq to use dev_dbg macros Venkatraman S
2012-08-17 18:52 ` Venkatraman S [this message]
2012-08-17 18:52 ` [PATCH 06/10] mmc: omap_hsmmc: remove access to SYSCONFIG register Venkatraman S
2012-08-21 15:38   ` Shubhrajyoti Datta
2012-08-27 11:04     ` S, Venkatraman
2012-08-17 18:52 ` [PATCH 07/10] mmc: omap_hsmmc: consolidate flush posted writes for HSMMC IRQs Venkatraman S
2012-08-21 15:21   ` T Krishnamoorthy, Balaji
2012-08-27 11:02     ` S, Venkatraman
2012-08-17 18:52 ` [PATCH 08/10] mmc: omap_hsmmc: consolidate error report handling of HSMMC IRQ Venkatraman S
2012-08-17 18:52 ` [PATCH 09/10] mmc: omap_hsmmc: convert from IP timer to hrtimer Venkatraman S
2012-08-21 10:42   ` Felipe Balbi
2012-08-22 10:38     ` S, Venkatraman
2012-08-22 11:28       ` Felipe Balbi
2012-08-17 18:52 ` [PATCH 10/10] mmc: omap_hsmmc: Move to Maintained state in MAINTAINERS Venkatraman S
2012-08-21 10:43 ` [PATCH 00/10] Assorted MMC / OMAP HSMMC patches Felipe Balbi
2012-08-27 23:02   ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345229550-8672-6-git-send-email-svenkatr@ti.com \
    --to=svenkatr@ti.com \
    --cc=balajitk@ti.com \
    --cc=cjb@laptop.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=vishp@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox