From: Felipe Balbi <balbi@ti.com>
To: "S, Venkatraman" <svenkatr@ti.com>
Cc: balbi@ti.com, linux-mmc@vger.kernel.org,
linux-omap@vger.kernel.org, cjb@laptop.org, balajitk@ti.com,
vishp@ti.com
Subject: Re: [PATCH 09/10] mmc: omap_hsmmc: convert from IP timer to hrtimer
Date: Wed, 22 Aug 2012 14:28:32 +0300 [thread overview]
Message-ID: <20120822112830.GB27029@arwen.pp.htv.fi> (raw)
In-Reply-To: <CANfBPZ-VbkDRADNgecyXSqj3YH-mAZcihEm2YRrMW8_RWpORyQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 759 bytes --]
Hi,
On Wed, Aug 22, 2012 at 04:08:17PM +0530, S, Venkatraman wrote:
> >> @@ -992,7 +996,7 @@ static void omap_hsmmc_do_irq(struct omap_hsmmc_host *host, int status)
> >> hsmmc_command_incomplete(host, -EILSEQ);
> >>
> >> end_cmd = 1;
> >> - if (host->data || host->response_busy) {
> >> + if (data || host->response_busy) {
> >
> > This doesn't seem like it belongs to $SUBJECT...
> >
> I thought is was a small fix which didn't warrant a separate patch though.
sure, that's fair. But it does deserve a mention on commit log too.
Something along the lines of "while at that, also use a 'data' variable
which was already defined instead of dereferencing host again".
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-22 11:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 18:52 [PATCH 00/10] Assorted MMC / OMAP HSMMC patches Venkatraman S
2012-08-17 18:52 ` [PATCH 01/10] mmc: core: Add TRANsfer state to non-HPI state Venkatraman S
2012-08-17 18:52 ` [PATCH 02/10] mmc: debugfs: Print ext_csd in ascending order Venkatraman S
2012-08-17 18:52 ` [PATCH 03/10] mmc: omap: remove unused variables and includes Venkatraman S
2012-08-17 18:52 ` [PATCH 04/10] mmc: omap: fix mmc_omap_report_irq to use dev_dbg macros Venkatraman S
2012-08-17 18:52 ` [PATCH 05/10] mmc: omap_hsmmc: remove unused vars and includes Venkatraman S
2012-08-17 18:52 ` [PATCH 06/10] mmc: omap_hsmmc: remove access to SYSCONFIG register Venkatraman S
2012-08-21 15:38 ` Shubhrajyoti Datta
2012-08-27 11:04 ` S, Venkatraman
2012-08-17 18:52 ` [PATCH 07/10] mmc: omap_hsmmc: consolidate flush posted writes for HSMMC IRQs Venkatraman S
2012-08-21 15:21 ` T Krishnamoorthy, Balaji
2012-08-27 11:02 ` S, Venkatraman
2012-08-17 18:52 ` [PATCH 08/10] mmc: omap_hsmmc: consolidate error report handling of HSMMC IRQ Venkatraman S
2012-08-17 18:52 ` [PATCH 09/10] mmc: omap_hsmmc: convert from IP timer to hrtimer Venkatraman S
2012-08-21 10:42 ` Felipe Balbi
2012-08-22 10:38 ` S, Venkatraman
2012-08-22 11:28 ` Felipe Balbi [this message]
2012-08-17 18:52 ` [PATCH 10/10] mmc: omap_hsmmc: Move to Maintained state in MAINTAINERS Venkatraman S
2012-08-21 10:43 ` [PATCH 00/10] Assorted MMC / OMAP HSMMC patches Felipe Balbi
2012-08-27 23:02 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120822112830.GB27029@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=balajitk@ti.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=svenkatr@ti.com \
--cc=vishp@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox