From: Felipe Balbi <balbi@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Felipe Balbi <balbi@ti.com>
Subject: [RFT/RFC/PATCH 11/31] arm: omap: irq: reorganize code a little bit
Date: Wed, 20 Nov 2013 12:08:58 -0600 [thread overview]
Message-ID: <1384970958-4118-12-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1384970958-4118-1-git-send-email-balbi@ti.com>
no functional changes, just moving code around.
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
arch/arm/mach-omap2/irq.c | 133 +++++++++++++++++++++++-----------------------
1 file changed, 66 insertions(+), 67 deletions(-)
diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
index b586317..45c5acc 100644
--- a/arch/arm/mach-omap2/irq.c
+++ b/arch/arm/mach-omap2/irq.c
@@ -57,10 +57,6 @@
* for each bank.. when in doubt, consult the TRM.
*/
-static struct irq_domain *domain;
-static void __iomem *omap_irq_base;
-static int omap_nr_irqs = 96;
-
/* Structure to save interrupt controller context */
struct omap_intc_regs {
u32 sysconfig;
@@ -70,6 +66,11 @@ struct omap_intc_regs {
u32 ilr[INTCPS_NR_ILR_REGS];
u32 mir[INTCPS_NR_MIR_REGS];
};
+static struct omap_intc_regs intc_context;
+
+static struct irq_domain *domain;
+static void __iomem *omap_irq_base;
+static int omap_nr_irqs = 96;
/* INTC bank register get/set */
static void intc_writel(u32 reg, u32 val)
@@ -82,6 +83,61 @@ static u32 intc_readl(u32 reg)
return readl_relaxed(omap_irq_base + reg);
}
+void omap_intc_save_context(void)
+{
+ int i;
+
+ intc_context.sysconfig =
+ intc_readl(INTC_SYSCONFIG);
+ intc_context.protection =
+ intc_readl(INTC_PROTECTION);
+ intc_context.idle =
+ intc_readl(INTC_IDLE);
+ intc_context.threshold =
+ intc_readl(INTC_THRESHOLD);
+
+ for (i = 0; i < omap_nr_irqs; i++)
+ intc_context.ilr[i] =
+ intc_readl((INTC_ILR0 + 0x4 * i));
+ for (i = 0; i < INTCPS_NR_MIR_REGS; i++)
+ intc_context.mir[i] =
+ intc_readl(INTC_MIR0 + (0x20 * i));
+}
+
+void omap_intc_restore_context(void)
+{
+ int i;
+
+ intc_writel(INTC_SYSCONFIG, intc_context.sysconfig);
+ intc_writel(INTC_PROTECTION, intc_context.protection);
+ intc_writel(INTC_IDLE, intc_context.idle);
+ intc_writel(INTC_THRESHOLD, intc_context.threshold);
+
+ for (i = 0; i < omap_nr_irqs; i++)
+ intc_writel(INTC_ILR0 + 0x4 * i,
+ intc_context.ilr[i]);
+
+ for (i = 0; i < INTCPS_NR_MIR_REGS; i++)
+ intc_writel(INTC_MIR0 + 0x20 * i,
+ intc_context.mir[i]);
+ /* MIRs are saved and restore with other PRCM registers */
+}
+
+void omap3_intc_prepare_idle(void)
+{
+ /*
+ * Disable autoidle as it can stall interrupt controller,
+ * cf. errata ID i540 for 3430 (all revisions up to 3.1.x)
+ */
+ intc_writel(INTC_SYSCONFIG, 0);
+}
+
+void omap3_intc_resume_idle(void)
+{
+ /* Re-enable autoidle */
+ intc_writel(INTC_SYSCONFIG, 1);
+}
+
/* XXX: FIQ and additional INTC support (only MPU at the moment) */
static void omap_ack_irq(struct irq_data *d)
{
@@ -125,6 +181,12 @@ int omap_irq_pending(void)
return 0;
}
+void omap3_intc_suspend(void)
+{
+ /* A pending interrupt would prevent OMAP from entering suspend */
+ omap_ack_irq(NULL);
+}
+
static __init void
omap_alloc_gc(void __iomem *base, unsigned int irq_start, unsigned int num)
{
@@ -257,69 +319,6 @@ void __init omap_intc_of_init(void)
of_irq_init(irq_match);
}
-static struct omap_intc_regs intc_context;
-
-void omap_intc_save_context(void)
-{
- int i;
-
- intc_context.sysconfig =
- intc_readl(INTC_SYSCONFIG);
- intc_context.protection =
- intc_readl(INTC_PROTECTION);
- intc_context.idle =
- intc_readl(INTC_IDLE);
- intc_context.threshold =
- intc_readl(INTC_THRESHOLD);
-
- for (i = 0; i < omap_nr_irqs; i++)
- intc_context.ilr[i] =
- intc_readl((INTC_ILR0 + 0x4 * i));
- for (i = 0; i < INTCPS_NR_MIR_REGS; i++)
- intc_context.mir[i] =
- intc_readl(INTC_MIR0 + (0x20 * i));
-}
-
-void omap_intc_restore_context(void)
-{
- int i;
-
- intc_writel(INTC_SYSCONFIG, intc_context.sysconfig);
- intc_writel(INTC_PROTECTION, intc_context.protection);
- intc_writel(INTC_IDLE, intc_context.idle);
- intc_writel(INTC_THRESHOLD, intc_context.threshold);
-
- for (i = 0; i < omap_nr_irqs; i++)
- intc_writel(INTC_ILR0 + 0x4 * i,
- intc_context.ilr[i]);
-
- for (i = 0; i < INTCPS_NR_MIR_REGS; i++)
- intc_writel(INTC_MIR0 + 0x20 * i,
- intc_context.mir[i]);
- /* MIRs are saved and restore with other PRCM registers */
-}
-
-void omap3_intc_suspend(void)
-{
- /* A pending interrupt would prevent OMAP from entering suspend */
- omap_ack_irq(NULL);
-}
-
-void omap3_intc_prepare_idle(void)
-{
- /*
- * Disable autoidle as it can stall interrupt controller,
- * cf. errata ID i540 for 3430 (all revisions up to 3.1.x)
- */
- intc_writel(INTC_SYSCONFIG, 0);
-}
-
-void omap3_intc_resume_idle(void)
-{
- /* Re-enable autoidle */
- intc_writel(INTC_SYSCONFIG, 1);
-}
-
asmlinkage void __exception_irq_entry omap3_intc_handle_irq(struct pt_regs *regs)
{
omap_intc_handle_irq(regs);
--
1.8.4.GIT
next prev parent reply other threads:[~2013-11-20 18:10 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 18:08 [RFT/RFC/PATCH 00/31] arm: omap: irq: cleanup INTC driver Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 01/31] arm: omap: irq: make omap_irq_base global Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 02/31] arm: omap: irq: define INTC_ILR0 register Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 03/31] arm: omap: irq: start to remove irq_banks array Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 04/31] arm: omap: irq: add a global omap_nr_irqs variable Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 05/31] arm: omap: irq: remove rest of irq_banks usage Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 06/31] arm: omap: irq: remove unused macro Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 07/31] arm: omap: irq: switch over to intc_readl on omap_intc_handle_irq Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 08/31] arm: omap: irq: remove unnecessary base_addr argument Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 09/31] arm: omap: irq: rename omap3_intc_regs Felipe Balbi
2013-11-20 18:08 ` [RFT/RFC/PATCH 10/31] arm: omap: irq: always define omap3 support Felipe Balbi
2013-11-20 18:08 ` Felipe Balbi [this message]
2013-11-20 18:08 ` [RFT/RFC/PATCH 12/31] arm: omap: irq: add suspend/resume methods Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 13/31] arm: omap: irq: remove last bits of our homebrew irqchip pm Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 14/31] arm: omap: irq: make intc_of_init static Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 15/31] arm: omap: irq: call set_handle_irq() from intc_of_init Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 16/31] arm: omap: irq: use IRQCHIP_DECLARE macro Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 17/31] arm: omap: irq: drop .handle_irq and .init_irq fields Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 18/31] arm: omap: irq: add specific compatibles for omap3 and am33xx devices Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 19/31] arm: omap: irq: use compatible flag to figure out number of IRQ lines Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 20/31] arm: boot: dts: am33xx/omap3: fix intc compatible flag Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 21/31] arm: omap: irq: drop ti,intc-size support Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 22/31] arm: boot: dts: omap2/3/am33xx: drop ti,intc-size Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 23/31] arm: omap: irq: move some more code around Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 24/31] arm: omap: irq: call set_handle_irq() from .init_irq Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 25/31] arm: omap: irq: drop omap3_intc_handle_irq() Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 26/31] arm: omap: irq: drop omap2_intc_handle_irq() Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 27/31] arm: omap: irq: drop omap_pending_irq() Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 28/31] arm: omap: irq: remove unnecessary header Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 29/31] arm: omap: irq: remove nr_irqs argument Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 30/31] arm: omap: irq: introduce omap_nr_pending Felipe Balbi
2013-11-20 18:09 ` [RFT/RFC/PATCH 31/31] arm: omap: irq: get rid of ifdef hack Felipe Balbi
2013-12-19 18:48 ` [RFT/RFC/PATCH 00/31] arm: omap: irq: cleanup INTC driver Tony Lindgren
2013-12-19 23:21 ` Felipe Balbi
2013-12-21 0:53 ` Tony Lindgren
2013-12-23 17:34 ` Felipe Balbi
2014-01-02 22:01 ` Felipe Balbi
2014-01-03 12:12 ` Rajendra Nayak
2014-01-03 16:40 ` Felipe Balbi
2014-07-15 9:14 ` Tony Lindgren
2014-07-15 19:56 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384970958-4118-12-git-send-email-balbi@ti.com \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox